From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA4EEA0526; Tue, 21 Jul 2020 07:40:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7CA4A1C027; Tue, 21 Jul 2020 07:40:28 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id D92521C000 for ; Tue, 21 Jul 2020 07:40:26 +0200 (CEST) IronPort-SDR: QIvQ6P5bXCD11n0wPmnc7DVRqZhtZs1O4CHCt2k1sRLEf4sZhq1+kKVmoFDZmKTu+vRdp1j+0r 8hrFsReqCQsg== X-IronPort-AV: E=McAfee;i="6000,8403,9688"; a="234920358" X-IronPort-AV: E=Sophos;i="5.75,377,1589266800"; d="scan'208";a="234920358" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2020 22:40:25 -0700 IronPort-SDR: 15SprF7CRTeAdEYBnf83dcyBboUgIh9YO7QfVih/xr/4c8fwVkX3tLVQGeQXuG+T5jLxg6fWvZ d4uisZzPwQOg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,377,1589266800"; d="scan'208";a="319786310" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga002.fm.intel.com with ESMTP; 20 Jul 2020 22:40:25 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 22:40:25 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.22]) by shsmsx102.ccr.corp.intel.com ([169.254.2.43]) with mapi id 14.03.0439.000; Tue, 21 Jul 2020 13:40:22 +0800 From: "Zhang, Qi Z" To: "Zhao1, Wei" , "Guo, Jia" CC: "bmcfall@redhat.com" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] net/e1000: fix segfault on tx done clean up Thread-Index: AQHWW1HFRJoW2slTYUisLMSm9Wmys6kRjBkA Date: Tue, 21 Jul 2020 05:40:22 +0000 Message-ID: <039ED4275CED7440929022BC67E70611548630CA@SHSMSX103.ccr.corp.intel.com> References: <20200716085354.57211-1-jia.guo@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] net/e1000: fix segfault on tx done clean up X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Zhao1, Wei > Sent: Thursday, July 16, 2020 5:16 PM > To: Guo, Jia > Cc: bmcfall@redhat.com; dev@dpdk.org > Subject: Re: [dpdk-dev] net/e1000: fix segfault on tx done clean up >=20 >=20 > Reviewed-by: Wei Zhao >=20 > > -----Original Message----- > > From: Guo, Jia > > Sent: Thursday, July 16, 2020 4:54 PM > > To: Zhao1, Wei > > Cc: bmcfall@redhat.com; dev@dpdk.org; Guo, Jia > > Subject: [dpdk-dev] net/e1000: fix segfault on tx done clean up > > > > As tx mbuf is not set for some advanced descriptors, if there is no > > mbuf checking before rte_pktmbuf_free_seg() function be called on the > > process of tx done clean up, that will cause a segfault. So add a NULL = pointer > check to fix it. > > > > Bugzilla ID: 501 > > Fixes: 8d907d2b79f7 (net/igb: free consumed Tx buffers on demand) > > > > Signed-off-by: Jeff Guo Applied to dpdk-next-net-intel. Thanks Qi