Re: [dpdk-dev] [PATCH] net/iavf: disable function simple xor for AVF RSS

Re: [dpdk-dev] [PATCH] net/iavf: disable function simple xor for AVF RSS

[Zhang, Qi Z]

> -----Original Message-----
> From: Guo, Junfeng <junfeng.guo@intel.com>
> Sent: Thursday, July 23, 2020 7:10 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Guo, Jia <jia.guo@intel.com>; Guo, Junfeng
> <junfeng.guo@intel.com>; Su, Simei <simei.su@intel.com>
> Subject: [PATCH] net/iavf: disable function simple xor for AVF RSS
> 
> Function simple_xor for AVF RSS is not required currently, thus we just return
> rte_flow error when the commandline has item simple_xor.
> 
> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

[dpdk-dev] [PATCH] net/iavf: disable function simple xor for AVF RSS

[Junfeng Guo]

Function simple_xor for AVF RSS is not required currently, thus we
just return rte_flow error when the commandline has item simple_xor.

Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
---
 drivers/net/iavf/iavf_hash.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c
index 40bb9dddc..dfc682298 100644
--- a/drivers/net/iavf/iavf_hash.c
+++ b/drivers/net/iavf/iavf_hash.c
@@ -4160,6 +4160,9 @@ iavf_hash_parse_action(const struct rte_flow_action actions[],
 			    RTE_ETH_HASH_FUNCTION_SIMPLE_XOR){
 				rss_meta->rss_algorithm =
 					VIRTCHNL_RSS_ALG_XOR_ASYMMETRIC;
+				return rte_flow_error_set(error, ENOTSUP,
+					RTE_FLOW_ERROR_TYPE_ACTION, action,
+					"function simple_xor is not supported");
 			} else if (rss->func ==
 				   RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ) {
 				rss_meta->rss_algorithm =
-- 
2.25.1