From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Sun, Chenmin" <chenmin.sun@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix a wrong bitmap free call
Date: Wed, 29 Jul 2020 00:07:15 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E7061154868448@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20200728125058.50292-1-chenmin.sun@intel.com>
> -----Original Message-----
> From: Sun, Chenmin <chenmin.sun@intel.com>
> Sent: Tuesday, July 28, 2020 8:51 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Sun, Chenmin <chenmin.sun@intel.com>
> Subject: [PATCH] net/i40e: fix a wrong bitmap free call
>
> From: Chenmin Sun <chenmin.sun@intel.com>
>
> This patch fixes the coverity warning #361024.
> rte_bitmap_free() is not a right way to free a bitmap, replacing it with
> rte_free().
>
Coverity issue: 361024
Fixes: febc61d350bf ("net/i40e: optimize flow director update rate")
> Signed-off-by: Chenmin Sun <chenmin.sun@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
> ---
> drivers/net/i40e/i40e_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 05d5f2861..a17bc9bab 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -1870,7 +1870,7 @@ i40e_fdir_memory_cleanup(struct i40e_pf *pf)
> if (fdir_info->hash_table)
> rte_hash_free(fdir_info->hash_table);
> if (fdir_info->fdir_flow_pool.bitmap)
> - rte_bitmap_free(fdir_info->fdir_flow_pool.bitmap);
> + rte_free(fdir_info->fdir_flow_pool.bitmap);
> if (fdir_info->fdir_flow_pool.pool)
> rte_free(fdir_info->fdir_flow_pool.pool);
> if (fdir_info->fdir_filter_array)
> --
> 2.17.1
prev parent reply other threads:[~2020-07-29 0:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 12:50 chenmin.sun
2020-07-29 0:07 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E7061154868448@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=chenmin.sun@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).