From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CAACAA053A; Tue, 4 Aug 2020 06:36:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 35E022BA8; Tue, 4 Aug 2020 06:36:39 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id A3FAAF04 for ; Tue, 4 Aug 2020 06:36:37 +0200 (CEST) IronPort-SDR: TR+F63k/L7hhR4BEFIDagIxKE+nZ7W0YYTYXZX+QhQTG/wTF6Ugcr8HV4GI6Dn9cbmSWx3HuVf pUP+p8jvj1Bg== X-IronPort-AV: E=McAfee;i="6000,8403,9702"; a="150050177" X-IronPort-AV: E=Sophos;i="5.75,432,1589266800"; d="scan'208";a="150050177" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2020 21:36:36 -0700 IronPort-SDR: HY1A/60yjroIhSydWJioa1KUrUSiffXNlpONV3ywnrD6q4f8DUGgHIKs403u9xq5txfmV4GMNH n8n/CEbNjd3w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,432,1589266800"; d="scan'208";a="324489571" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga002.fm.intel.com with ESMTP; 03 Aug 2020 21:36:36 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 3 Aug 2020 21:36:34 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 3 Aug 2020 21:36:34 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 3 Aug 2020 21:36:34 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.23]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.49]) with mapi id 14.03.0439.000; Tue, 4 Aug 2020 12:36:30 +0800 From: "Zhang, Qi Z" To: "Guo, Jia" , "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" , "Guo, Junfeng" , "Su, Simei" Thread-Topic: [PATCH v1] net/iavf: fix hash default set Thread-Index: AQHWagvHeredWdHH70C3nXEdQUYrwqknXNQA Date: Tue, 4 Aug 2020 04:36:29 +0000 Message-ID: <039ED4275CED7440929022BC67E7061154873F82@SHSMSX103.ccr.corp.intel.com> References: <20200804025831.99919-1-jia.guo@intel.com> In-Reply-To: <20200804025831.99919-1-jia.guo@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1] net/iavf: fix hash default set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Guo, Jia > Sent: Tuesday, August 4, 2020 10:59 AM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; Guo, Junfeng ; Su, Simei > ; Guo, Jia > Subject: [PATCH v1] net/iavf: fix hash default set >=20 > Different device has different hash capability, it should not be expected= that all > hash set would be successful to set into all devices by default. So remov= e the > return checking when hash default set. And remove gtpu hash default set, = iavf > only enable hash for general protocols. >=20 > Fixes: c94366cfc641 ("net/iavf: add GTPU in default hash") > Signed-off-by: Jeff Guo Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi