DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: Pawel Wodkowski <pawelwod@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhao1, Wei" <wei.zhao1@intel.com>, "Guo, Jia" <jia.guo@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix fdir flows with RTE_FLOW_ITEM_TYPE_RAW
Date: Mon, 31 Aug 2020 03:46:13 +0000
Message-ID: <039ED4275CED7440929022BC67E706115522E196@SHSMSX107.ccr.corp.intel.com> (raw)
In-Reply-To: <20200810203108.28770-1-pawelwod@gmail.com>



> -----Original Message-----
> From: Pawel Wodkowski <pawelwod@gmail.com>
> Sent: Tuesday, August 11, 2020 4:31 AM
> To: dev@dpdk.org
> Cc: Pawel Wodkowski <pawelwod@gmail.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>; Guo, Jia
> <jia.guo@intel.com>
> Subject: [PATCH] net/ixgbe: fix fdir flows with RTE_FLOW_ITEM_TYPE_RAW
> 
> Flows like IP4 / UDP / RAW are not working because after parsing
> RTE_FLOW_ITEM_TYPE_RAW item pointer is not advanced. This make whole
> parsing fail.
> 
> Fixes: f35fec63dde1 ("net/ixgbe: enable flex bytes for generic flow API")
> Cc: qi.z.zhang@intel.com
> Signed-off-by: Pawel Wodkowski <pawelwod@gmail.com>
> ---
>  drivers/net/ixgbe/ixgbe_flow.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
> index b2a2bfc02..a2cb599b1 100644
> --- a/drivers/net/ixgbe/ixgbe_flow.c
> +++ b/drivers/net/ixgbe/ixgbe_flow.c
> @@ -2251,6 +2251,8 @@ ixgbe_parse_fdir_filter_normal(struct rte_eth_dev
> *dev,
>  			(((uint16_t)raw_spec->pattern[1]) << 8) |
>  			raw_spec->pattern[0];
>  		rule->flex_bytes_offset = raw_spec->offset;
> +
> +		item = next_no_fuzzy_pattern(pattern, item);

why we need to advance item pointer?
The next branch will advance it and compare with RTe_FLOW_ITEM_TYPE_END.
Can you double check if your pattern is IPv4/UDP/RAW/END ?

>  	}
> 
>  	if (item->type != RTE_FLOW_ITEM_TYPE_END) {
> --
> 2.17.1


  reply	other threads:[~2020-08-31  3:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-10 20:31 Pawel Wodkowski
2020-08-31  3:46 ` Zhang, Qi Z [this message]
2020-09-02  8:51   ` Pawel Wodkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=039ED4275CED7440929022BC67E706115522E196@SHSMSX107.ccr.corp.intel.com \
    --to=qi.z.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=jia.guo@intel.com \
    --cc=pawelwod@gmail.com \
    --cc=wei.zhao1@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git