From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AFEF8A04AB; Mon, 31 Aug 2020 06:22:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E01711515; Mon, 31 Aug 2020 06:22:44 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 268E4137D; Mon, 31 Aug 2020 06:22:42 +0200 (CEST) IronPort-SDR: EE6G42que5CoI5KcHS2KhLFSw+7gCO7pqLs59Ev3j/14Mwh7fxHoOOlTQ+Gv7IZdYU31rv3vVR F3ULJ1lAIzKw== X-IronPort-AV: E=McAfee;i="6000,8403,9729"; a="154439395" X-IronPort-AV: E=Sophos;i="5.76,374,1592895600"; d="scan'208";a="154439395" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2020 21:22:42 -0700 IronPort-SDR: PjgkFYJRKZ/98rDTyqAlWifUpgwKg16H6W6/gKT3EkUEiRh49744xRd1+1z1xGYID+ZjEZ9Own cdY0oV59/7EA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,374,1592895600"; d="scan'208";a="338116657" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by FMSMGA003.fm.intel.com with ESMTP; 30 Aug 2020 21:22:42 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 30 Aug 2020 21:22:35 -0700 Received: from fmsmsx106.amr.corp.intel.com (10.18.124.204) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 30 Aug 2020 21:22:35 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 30 Aug 2020 21:22:34 -0700 Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.141]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.115]) with mapi id 14.03.0439.000; Mon, 31 Aug 2020 12:22:31 +0800 From: "Zhang, Qi Z" To: "Sun, GuinanX" , "dev@dpdk.org" CC: "Yang, Qiming" , "stable@dpdk.org" Thread-Topic: [PATCH] net/ice: fix flow validation for unsupported patterns Thread-Index: AQHWfOXx6DUnK5xtSUeMVZiDAHQhi6lRor3w Date: Mon, 31 Aug 2020 04:22:30 +0000 Message-ID: <039ED4275CED7440929022BC67E706115522E204@SHSMSX107.ccr.corp.intel.com> References: <20200828023328.62492-1-guinanx.sun@intel.com> In-Reply-To: <20200828023328.62492-1-guinanx.sun@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ice: fix flow validation for unsupported patterns X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Sun, GuinanX > Sent: Friday, August 28, 2020 10:33 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; Sun, GuinanX ; > stable@dpdk.org > Subject: [PATCH] net/ice: fix flow validation for unsupported patterns >=20 > When loading the OS default package and the pipeline mode is enabled by t= he > "pipeline-mode-support=3D1" operation. In this case, the wrong parser is = selected > for processing and it will cause the unsupported > patterns(pppoes/pfcp/l2tpv3/esp/ah) to be validated successfully. > This patch corrects the parser selection issue. >=20 > Fixes: 47d460d63233 ("net/ice: rework switch filter") > Cc: stable@dpdk.org >=20 > Signed-off-by: Guinan Sun > --- > drivers/net/ice/ice_switch_filter.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/ice/ice_switch_filter.c > b/drivers/net/ice/ice_switch_filter.c > index c4b00b6a2..884fbaae2 100644 > --- a/drivers/net/ice/ice_switch_filter.c > +++ b/drivers/net/ice/ice_switch_filter.c > @@ -1806,7 +1806,8 @@ ice_switch_init(struct ice_adapter *ad) > else > return -EINVAL; >=20 > - if (ad->devargs.pipe_mode_support) > + if (ad->devargs.pipe_mode_support && > + ad->active_pkg_type !=3D ICE_PKG_TYPE_OS_DEFAULT) > ret =3D ice_register_parser(perm_parser, ad); This is not correct, package type should not related with pipe line mode. > else > ret =3D ice_register_parser(dist_parser, ad); @@ -1824,7 +1825,8 @@ > ice_switch_uninit(struct ice_adapter *ad) > else > dist_parser =3D &ice_switch_dist_parser_os; >=20 > - if (ad->devargs.pipe_mode_support) > + if (ad->devargs.pipe_mode_support && > + ad->active_pkg_type !=3D ICE_PKG_TYPE_OS_DEFAULT) > ice_unregister_parser(perm_parser, ad); > else > ice_unregister_parser(dist_parser, ad); > -- > 2.17.1