From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 72DABA04AC; Mon, 31 Aug 2020 07:48:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2DF71137D; Mon, 31 Aug 2020 07:48:02 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 810BEDE0 for ; Mon, 31 Aug 2020 07:48:00 +0200 (CEST) IronPort-SDR: wRrcxuFxzr+n0b+4lBWLsgIhIJxfkejnBtP9jv5zLUeNsNOIzP3uPzFQOyreLfa8LvwnilEK68 Cp0k8/7ped3A== X-IronPort-AV: E=McAfee;i="6000,8403,9729"; a="154320348" X-IronPort-AV: E=Sophos;i="5.76,374,1592895600"; d="scan'208";a="154320348" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2020 22:47:59 -0700 IronPort-SDR: EmJK4B6GgIL3UzyH8EjPM6JQKGV0VvNHU8Rt3bWRaAPg39roZGkkR1MVNT/9jPMSbHCnvbjEtu 5kvRLPCeCaxg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,374,1592895600"; d="scan'208";a="282987806" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga008.fm.intel.com with ESMTP; 30 Aug 2020 22:47:58 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 30 Aug 2020 22:46:57 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 30 Aug 2020 22:46:57 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 30 Aug 2020 22:46:57 -0700 Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.141]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.32]) with mapi id 14.03.0439.000; Mon, 31 Aug 2020 13:46:54 +0800 From: "Zhang, Qi Z" To: "Wang, Haiyue" , "Guo, Junfeng" , "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/ice: add support for Auxiliary IP Offset Rx descriptor Thread-Index: AQHWe1hXlvcOt8wQfEmXUfVOw/TjlqlRM7+AgACJdnA= Date: Mon, 31 Aug 2020 05:46:32 +0000 Message-ID: <039ED4275CED7440929022BC67E706115522E2ED@SHSMSX107.ccr.corp.intel.com> References: <20200826032141.333400-1-junfeng.guo@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ice: add support for Auxiliary IP Offset Rx descriptor X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Wang, Haiyue > Sent: Monday, August 31, 2020 1:34 PM > To: Guo, Junfeng ; Zhang, Qi Z > ; Wu, Jingjing ; Xing, Beile= i > > Cc: dev@dpdk.org > Subject: RE: [PATCH] net/ice: add support for Auxiliary IP Offset Rx desc= riptor >=20 > > -----Original Message----- > > From: Guo, Junfeng > > Sent: Wednesday, August 26, 2020 11:22 > > To: Zhang, Qi Z ; Wu, Jingjing > > ; Xing, Beilei > > Cc: dev@dpdk.org; Wang, Haiyue ; Guo, Junfeng > > > > Subject: [PATCH] net/ice: add support for Auxiliary IP Offset Rx > > descriptor > > > > Add RXDID #25 to support Auxiliary IP Offset Rx descriptor, including > > FlexiMD.4: Outer/Single IPv4 Header offset > > FlexiMD.5: Outer/Single IPv6 Header offset And parse the valid IP > > Offset into mbuf by flexible descriptor section via devargs > > "proto_xtr" with "proto_xtr=3Dip_offset". > > > > This patch depends on: > > commit e0c8ed904083 (net/ice: optimize the FlexiMD hardware check) > > > > Signed-off-by: Junfeng Guo > > --- > > doc/guides/nics/ice.rst | 14 ++++- > > drivers/net/ice/base/ice_lan_tx_rx.h | 1 + > > drivers/net/ice/ice_ethdev.c | 10 +++- > > drivers/net/ice/ice_ethdev.h | 1 + > > drivers/net/ice/ice_rxtx.c | 77 +++++++++++++++++-------- > > drivers/net/ice/rte_pmd_ice.h | 13 +++++ > > drivers/net/ice/rte_pmd_ice_version.map | 1 + > > 7 files changed, 90 insertions(+), 27 deletions(-) > > >=20 > [...] >=20 > > +/** > > + * No need to check XTR_MD.#_VLD bit in Status/Error fields for > > + * Protocol Offset according to CPK HAS 7.9.8. > > + */ >=20 > These comments are no need, since HAS doc session is internal information= , > and the code is clean enough: if (chk_valid) ... else... >=20 > > +if (rte_le_to_cpu_16(desc->flex_ts.flex.aux0) !=3D 0xFFFF) metadata = =3D > > +rte_le_to_cpu_16(desc->flex_ts.flex.aux0); > > +else if (rte_le_to_cpu_16(desc->flex_ts.flex.aux1) !=3D 0xFFFF) > > +metadata =3D rte_le_to_cpu_16(desc->flex_ts.flex.aux1); >=20 > Others, >=20 > Acked-by: Haiyue Wang Applied to dpdk-next-net-intel after remove unnecessary comment. Thanks Qi >=20