DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: Li Han <han.li1@zte.com.cn>,
	"Wu, Jingjing" <jingjing.wu@intel.com>,
	"Xing, Beilei" <beilei.xing@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix default mac set fail issue
Date: Mon, 31 Aug 2020 08:27:01 +0000	[thread overview]
Message-ID: <039ED4275CED7440929022BC67E706115522E52E@SHSMSX107.ccr.corp.intel.com> (raw)
In-Reply-To: <1598324444-24734-1-git-send-email-han.li1@zte.com.cn>



> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Li Han
> Sent: Tuesday, August 25, 2020 11:01 AM
> To: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Li Han <han.li1@zte.com.cn>
> Subject: [dpdk-dev] [PATCH] net/iavf: fix default mac set fail issue
> 
> rte_is_valid_assigned_ether_addr retrun true if the given ethernet address is
> valid.
> 
> Signed-off-by: Li Han <han.li1@zte.com.cn>
> ---
>  drivers/net/iavf/iavf_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
> index c3aa4cd..18ce809 100644
> --- a/drivers/net/iavf/iavf_ethdev.c
> +++ b/drivers/net/iavf/iavf_ethdev.c
> @@ -973,7 +973,7 @@ static int iavf_config_rx_queues_irqs(struct
> rte_eth_dev *dev,
>  		return 0;
> 
>  	/* If the MAC address is configured by host, skip the setting */
> -	if (rte_is_valid_assigned_ether_addr(perm_addr))
> +	if (!rte_is_valid_assigned_ether_addr(perm_addr))

A valid mac address means it already be configured by host, so it should be skipped.

>  		return -EPERM;
> 
>  	ret = iavf_add_del_eth_addr(adapter, old_addr, false);
> --
> 1.8.3.1


      reply	other threads:[~2020-08-31  8:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25  3:00 Li Han
2020-08-31  8:27 ` Zhang, Qi Z [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=039ED4275CED7440929022BC67E706115522E52E@SHSMSX107.ccr.corp.intel.com \
    --to=qi.z.zhang@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=han.li1@zte.com.cn \
    --cc=jingjing.wu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).