From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: "Xueming(Steven) Li" <xuemingl@nvidia.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"xuan.ding@intel.com" <xuan.ding@intel.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
"stable@dpdk.org" <stable@dpdk.org>,
"chenbo.xia@intel.com" <chenbo.xia@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3 1/3] vhost: fix error path when setting memory tables
Date: Thu, 12 Nov 2020 18:00:18 +0100 [thread overview]
Message-ID: <03e3a2db-98da-c561-bf13-47c7f1cb6646@redhat.com> (raw)
In-Reply-To: <BY5PR12MB4324F4D0F859147B9509FB1DA1E80@BY5PR12MB4324.namprd12.prod.outlook.com>
On 11/11/20 7:06 AM, Xueming(Steven) Li wrote:
>> @@ -1012,16 +1018,13 @@ vhost_user_set_mem_table(struct virtio_net
>> **pdev, struct VhostUserMsg *msg,
>> if (memory->nregions > VHOST_MEMORY_MAX_NREGIONS) {
>> VHOST_LOG_CONFIG(ERR,
>> "too many memory regions (%u)\n", memory-
>>> nregions);
>> - return RTE_VHOST_MSG_RESULT_ERR;
>> + goto close_msg_fds;
>> }
>>
>> if (dev->mem && !vhost_memory_changed(memory, dev->mem)) {
>> VHOST_LOG_CONFIG(INFO,
>> "(%d) memory regions not changed\n", dev->vid);
>> -
>> - close_msg_fds(msg);
>> -
>> - return RTE_VHOST_MSG_RESULT_OK;
>> + goto close_msg_fds;
> Return code will be changed to RTE_VHOST_MSG_RESULT_ERR, is this ok?
>
Good catch, that is not OK to return RTE_VHOST_MSG_RESULT_ERR here.
Will fix in v3.
Thanks!
Maxime
next prev parent reply other threads:[~2020-11-12 17:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 12:16 [dpdk-dev] [PATCH v3 0/3] vhost: fix fd an memory leaks Maxime Coquelin
2020-11-09 12:16 ` [dpdk-dev] [PATCH v3 1/3] vhost: fix error path when setting memory tables Maxime Coquelin
2020-11-11 6:06 ` Xueming(Steven) Li
2020-11-12 17:00 ` Maxime Coquelin [this message]
2020-11-09 12:16 ` [dpdk-dev] [PATCH v3 2/3] vhost: fix fd leak in dirty logging setup Maxime Coquelin
2020-11-10 1:44 ` Xia, Chenbo
2020-11-11 6:13 ` Xueming(Steven) Li
2020-11-09 12:16 ` [dpdk-dev] [PATCH v3 3/3] vhost: fix fd leak in kick setup Maxime Coquelin
2020-11-11 6:01 ` Xueming(Steven) Li
2020-11-11 7:57 ` Xia, Chenbo
2020-11-12 17:06 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03e3a2db-98da-c561-bf13-47c7f1cb6646@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
--cc=xuan.ding@intel.com \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).