From: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com> To: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>, dev@dpdk.org, john.mcnamara@intel.com Cc: ruifeng.wang@arm.com, juraj.linkes@pantheon.tech, david.marchand@redhat.com, nd@arm.com, ian.betts@intel.com, stable@dpdk.org, "\"'Lukasz Wojciechowski'\"," <l.wojciechow@partner.samsung.com> Subject: Re: [dpdk-dev] [PATCH 2/2] examples/performance-thread: fix undef behavior Date: Wed, 21 Oct 2020 00:46:31 +0200 Message-ID: <04382a3f-66f0-4e85-bb52-588ac9ad0414@partner.samsung.com> (raw) In-Reply-To: <20201016060349.19940-2-honnappa.nagarahalli@arm.com> Looks good! W dniu 16.10.2020 o 08:03, Honnappa Nagarahalli pisze: > When the value of RTE_MAX_LCORE is small, it results in the > following compilation error. > > ../examples/performance-thread/l3fwd-thread/main.c:2338:34: error: > iteration 4 invokes undefined behavior > [-Werror=aggressive-loop-optimizations] > > Fixes: d48415e1fee3 ("examples/performance-thread: add l3fwd-thread app") > Cc: ian.betts@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com> Tested-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com> Reviewed-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com> > --- > examples/performance-thread/l3fwd-thread/main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/examples/performance-thread/l3fwd-thread/main.c b/examples/performance-thread/l3fwd-thread/main.c > index 818e483d2..dc34d4893 100644 > --- a/examples/performance-thread/l3fwd-thread/main.c > +++ b/examples/performance-thread/l3fwd-thread/main.c > @@ -599,8 +599,8 @@ struct thread_rx_conf rx_thread[MAX_RX_THREAD]; > struct thread_tx_conf { > struct thread_conf conf; > > - uint16_t tx_queue_id[RTE_MAX_LCORE]; > - struct mbuf_table tx_mbufs[RTE_MAX_LCORE]; > + uint16_t tx_queue_id[RTE_MAX_ETHPORTS]; > + struct mbuf_table tx_mbufs[RTE_MAX_ETHPORTS]; > > struct rte_ring *ring; > struct lthread_cond **ready; -- Lukasz Wojciechowski Principal Software Engineer Samsung R&D Institute Poland Samsung Electronics Office +48 22 377 88 25 l.wojciechow@partner.samsung.com
next prev parent reply other threads:[~2020-10-20 22:51 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20201016060420eucas1p12f301a94eb4b4d19a9ced5c5cbd59c77@eucas1p1.samsung.com> 2020-10-16 6:03 ` [dpdk-dev] [PATCH 1/2] test/rcu: fix array subscript is above array bounds Honnappa Nagarahalli 2020-10-16 6:03 ` [dpdk-dev] [PATCH 2/2] examples/performance-thread: fix undef behavior Honnappa Nagarahalli 2020-10-20 22:46 ` Lukasz Wojciechowski [this message] 2020-10-30 14:26 ` David Marchand 2020-10-20 0:06 ` [dpdk-dev] [PATCH 1/2] test/rcu: fix array subscript is above array bounds Lukasz Wojciechowski 2020-10-20 16:26 ` Honnappa Nagarahalli 2020-10-20 20:59 ` Lukasz Wojciechowski 2020-10-30 14:44 ` David Marchand
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=04382a3f-66f0-4e85-bb52-588ac9ad0414@partner.samsung.com \ --to=l.wojciechow@partner.samsung.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=honnappa.nagarahalli@arm.com \ --cc=ian.betts@intel.com \ --cc=john.mcnamara@intel.com \ --cc=juraj.linkes@pantheon.tech \ --cc=nd@arm.com \ --cc=ruifeng.wang@arm.com \ --cc=stable@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git