Re: [PATCH v5] app/testpmd: add help messages for multi-process

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 3/4/2022 6:26 AM, Min Hu (Connor) wrote:
> From: Huisong Li <lihuisong@huawei.com>
> 
> This patch adds help messages for multi-process.
> --num-procs <N>, where N is the total number of symmetric_mp instances
> that will be run side-by-side to perform packet processing. This parameter
> is used to configure the appropriate number of receive queues on each
> network port.
> 
> --proc-id <n>, where n is a numeric value in the range 0 <= n < N (number
> of processes, specified above). This identifies which symmetric_mp instance
> is being run, so that each process can read a unique receive queue on each
> network port.
> 
> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
> v5:
> * delete space
> v4:
> * update description for parameters.
> v3,v2:
> * adjust the position of parameters.
> ---
>   app/test-pmd/parameters.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
> index daf6a31b2b..6c4253ae61 100644
> --- a/app/test-pmd/parameters.c
> +++ b/app/test-pmd/parameters.c
> @@ -61,6 +61,8 @@ usage(char* progname)
>   	       "extended statistics to show. Used with --stats-period "
>   	       "specified or interactive commands that show Rx/Tx statistics "
>   	       "(i.e. 'show port stats').\n");
> +	printf("  --num-procs: the total number of symmetric_mp instances that will be run side-by-side\n");

I am not exactly sure what is 'symmetric' in 'symmetric_mp' here,
there is a sample application with this name but I guess 'symmetric'
is related to that sample functionality.

Would you mind if I change 'symmetric_mp' with 'multi-process'
while applying?

> +	printf("  --proc-id: the id of the current process (id < num-procs) to identify which symmetric_mp instance is being run\n");
>   	printf("  --nb-cores=N: set the number of forwarding cores "
>   	       "(1 <= N <= %d).\n", nb_lcores);
>   	printf("  --nb-ports=N: set the number of forwarding ports "