From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <maxime.coquelin@redhat.com> Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id A68311B6F7 for <dev@dpdk.org>; Fri, 22 Mar 2019 18:22:12 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EE4F13092664; Fri, 22 Mar 2019 17:22:11 +0000 (UTC) Received: from [10.36.112.59] (ovpn-112-59.ams2.redhat.com [10.36.112.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BA8236013D; Fri, 22 Mar 2019 17:22:07 +0000 (UTC) To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org Cc: wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com, ramirose@gmail.com, arybchenko@solarflare.com, ferruh.yigit@intel.com References: <1553076154-3907-1-git-send-email-david.marchand@redhat.com> <1553261824-1881-1-git-send-email-david.marchand@redhat.com> <1553261824-1881-5-git-send-email-david.marchand@redhat.com> From: Maxime Coquelin <maxime.coquelin@redhat.com> Message-ID: <0442d79f-0e74-3633-02c9-f6f4234881fb@redhat.com> Date: Fri, 22 Mar 2019 18:22:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <1553261824-1881-5-git-send-email-david.marchand@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Fri, 22 Mar 2019 17:22:12 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v4 4/4] app/testpmd: display/clear forwarding stats on demand X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 22 Mar 2019 17:22:12 -0000 On 3/22/19 2:37 PM, David Marchand wrote: > Add a new "show/clear fwd stats all" command to display fwd and port > statistics on the fly. > > To be able to do so, the (testpmd only) rte_port structure can't be used > to maintain any statistics. > Moved the stats dump parts from stop_packet_forwarding() and merge with > fwd_port_stats_display() into fwd_stats_display(). > fwd engine statistics are then aggregated into a local per port array. > > Signed-off-by: David Marchand <david.marchand@redhat.com> > --- > Changelog since v3: > - added description in testpmd usage > - renamed cmd_fwdall as cmd_showfwdall > > Changelog since v1: > - removed hunk from now deleted patch 3 > > --- > app/test-pmd/cmdline.c | 49 ++++ > app/test-pmd/testpmd.c | 425 +++++++++++++++------------- > app/test-pmd/testpmd.h | 9 +- > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 36 +++ > 4 files changed, 310 insertions(+), 209 deletions(-) > Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 513BEA00E6 for <public@inbox.dpdk.org>; Fri, 22 Mar 2019 18:22:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1DAD21B70B; Fri, 22 Mar 2019 18:22:14 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id A68311B6F7 for <dev@dpdk.org>; Fri, 22 Mar 2019 18:22:12 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EE4F13092664; Fri, 22 Mar 2019 17:22:11 +0000 (UTC) Received: from [10.36.112.59] (ovpn-112-59.ams2.redhat.com [10.36.112.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BA8236013D; Fri, 22 Mar 2019 17:22:07 +0000 (UTC) To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org Cc: wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com, ramirose@gmail.com, arybchenko@solarflare.com, ferruh.yigit@intel.com References: <1553076154-3907-1-git-send-email-david.marchand@redhat.com> <1553261824-1881-1-git-send-email-david.marchand@redhat.com> <1553261824-1881-5-git-send-email-david.marchand@redhat.com> From: Maxime Coquelin <maxime.coquelin@redhat.com> Message-ID: <0442d79f-0e74-3633-02c9-f6f4234881fb@redhat.com> Date: Fri, 22 Mar 2019 18:22:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <1553261824-1881-5-git-send-email-david.marchand@redhat.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Fri, 22 Mar 2019 17:22:12 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v4 4/4] app/testpmd: display/clear forwarding stats on demand X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190322172205.snN9TRFNaP4Mw2HsllVqly6S0Om-eyiGzitN88c2b40@z> On 3/22/19 2:37 PM, David Marchand wrote: > Add a new "show/clear fwd stats all" command to display fwd and port > statistics on the fly. > > To be able to do so, the (testpmd only) rte_port structure can't be used > to maintain any statistics. > Moved the stats dump parts from stop_packet_forwarding() and merge with > fwd_port_stats_display() into fwd_stats_display(). > fwd engine statistics are then aggregated into a local per port array. > > Signed-off-by: David Marchand <david.marchand@redhat.com> > --- > Changelog since v3: > - added description in testpmd usage > - renamed cmd_fwdall as cmd_showfwdall > > Changelog since v1: > - removed hunk from now deleted patch 3 > > --- > app/test-pmd/cmdline.c | 49 ++++ > app/test-pmd/testpmd.c | 425 +++++++++++++++------------- > app/test-pmd/testpmd.h | 9 +- > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 36 +++ > 4 files changed, 310 insertions(+), 209 deletions(-) > Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>