From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 0A8A92C01 for ; Mon, 25 Sep 2017 13:37:16 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP; 25 Sep 2017 04:37:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,436,1500966000"; d="scan'208";a="903578147" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by FMSMGA003.fm.intel.com with ESMTP; 25 Sep 2017 04:37:13 -0700 To: Zhiyong Yang , dev@dpdk.org Cc: thomas@monjalon.net, adrien.mazarguil@6wind.com References: <20170921083243.57991-1-zhiyong.yang@intel.com> <20170925032231.72897-1-zhiyong.yang@intel.com> <20170925032231.72897-3-zhiyong.yang@intel.com> From: Ferruh Yigit Message-ID: <044eece2-d213-a5fa-7d1a-a4c1a621ebba@intel.com> Date: Mon, 25 Sep 2017 12:37:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170925032231.72897-3-zhiyong.yang@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 2/5] ethdev: increase port_id range X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Sep 2017 11:37:17 -0000 On 9/25/2017 4:22 AM, Zhiyong Yang wrote: > Extend port_id definition from uint8_t to uint16_t in lib and drivers > data structures, specifically rte_eth_dev_data. Modify the APIs, > drivers and app using port_id at the same time. > > Fix some checkpatch issues from the original code and remove some > unnecessary cast operations. > > release_17_11 and deprecation have been updated in this patch. > > Signed-off-by: Zhiyong Yang > Acked-by: Adrien Mazarguil Reviewed-by: Ferruh Yigit This is very hard to be sure everything covered. Also this patch will cause lots of merge conflict against next-net. I would suggest getting this patch as soon as possible, to give more time to possible fixes. Thanks, ferruh