From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>
Cc: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] mbuf: display more fields in dump
Date: Thu, 21 Nov 2019 18:04:07 +0100 [thread overview]
Message-ID: <044f01d5a08d$affd9d78$0a04a8c0@smartsharesys.local> (raw)
I think the name also changed from in_port.Sent from a smartphone. Please pardon brevity and spelling.
-------- Oprindelig besked --------Fra: Stephen Hemminger <stephen@networkplumber.org> Dato: 21/11/2019 17.43 (GMT+01:00) Til: Morten Brørup <mb@smartsharesystems.com> Cc: dev@dpdk.org Emne: Re: [dpdk-dev] [PATCH] mbuf: display more fields in dump On Thu, 21 Nov 2019 17:16:42 +0100Morten Brørup <mb@smartsharesystems.com> wrote:> Are all these explicit type casts really needed? buf_iova is already uint64_t, buflen is uint16_t, data_off is uint16_t, rte_mbuf_refcnt_read() returns uint16_t, pkt_len is uint32_t, nb_segs is uint16_t, port is uint16_t, vlan_tci is uint16_t.Normally, they are not needed.If you turn up some of the warning levels in Gcc, then yes.> > m->port is not only the input port anymore (ref. the mbuf documentation), so please change in_port=%u to port=%u.Makes sense, but since this in internal would rather keep existing to print the name of the field.> > For consistency with ol_flags and vlan_tci format, consider changing iova=% to iova=%#.good idea, personal preference is to always use %#x over %x
next reply other threads:[~2019-11-21 17:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 17:04 Morten Brørup [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-11-20 17:41 Stephen Hemminger
2019-11-21 16:16 ` Morten Brørup
2019-11-21 16:43 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='044f01d5a08d$affd9d78$0a04a8c0@smartsharesys.local' \
--to=mb@smartsharesystems.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).