DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ray Kinsella <mdr@ashroe.eu>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, stephen@networkplumber.org,
	bruce.richardson@intel.com, ferruh.yigit@intel.com,
	konstantin.ananyev@intel.com, jerinj@marvell.com,
	olivier.matz@6wind.com, nhorman@tuxdriver.com,
	maxime.coquelin@redhat.com, john.mcnamara@intel.com,
	marko.kovacevic@intel.com, hemant.agrawal@nxp.com,
	ktraynor@redhat.com, aconole@redhat.com
Subject: Re: [dpdk-dev] [PATCH v6 0/4] doc: changes to abi policy introducing major abi versions
Date: Mon, 21 Oct 2019 11:10:08 +0100	[thread overview]
Message-ID: <045a297d-27d7-87b4-b236-786cc2221ecd@ashroe.eu> (raw)
In-Reply-To: <4306711.lZEasSuxhK@xps>



On 21/10/2019 10:50, Thomas Monjalon wrote:
> 27/09/2019 18:54, Ray Kinsella:
>> TL;DR abbreviation:
>> A major ABI version that all DPDK releases during a one year period
>> support. ABI versioning is managed at a project-level, in place of library-level
>> management. ABI changes to add new features are permitted, as long as ABI
>> compatibility with the major ABI version is maintained.
>>
>> Detail:
>> This patch introduces major ABI versions, supported for one year and released
>> aligned with the LTS release. This ABI version is then supported by all
>> subsequent releases within that one year period. The intention is that the one
>> year support period, will then be reviewed after the initial year with the
>> intention of lengthing the support period for the next ABI version.
> 
> For the record, I would prefer a v7 saying it is a fixed period of time,
> being one year at first and should be longer next.
> Please don't state "supported for one year", which can be understood as a general truth.

Well I was very careful to only state an _intention_ to lengthen the fix period,
I though it prudent to avoid words like "should", as nothing is known until the year is behind us. 

Where I used the word "support", I talk about "abi support".
I suggest rewording as follows:-

This patch introduces major ABI versions, released aligned with the LTS release,
maintained for one year through all subsequent releases within that one year period. 
The intention is that the one year abi support period, will then be reviewed after 
the initial year with the intention of lengthening the period for the next ABI version.

> 
>> ABI changes that preserve ABI compatibility with the major ABI version are
>> permitted in subsequent releases. ABI changes, follow similar approval rules as
>> before with the additional gate of now requiring technical board approval. The
>> merging and release of ABI breaking changes would now be pushed to the
>> declaration of the next major ABI version.
>>
>> This change encourages developers to maintain ABI compatibility with the major
>> ABI version, by promoting a permissive culture around those changes that
>> preserve ABI compatibility. This approach begins to align DPDK with those
>> projects that declare major ABI versions (e.g. version 2.x, 3.x) and support
>> those versions for some period, typically two years or more.
>>
>> To provide an example of how this might work in practice:
>>
>>  * DPDK v20 is declared as the supported ABI version for one year, aligned with
>>    the DPDK v19.11 (LTS) release. All library sonames are updated to reflect the
>>    new ABI version, e.g. librte_eal.so.20, librte_acl.so.20...
>>  * DPDK v20.02 .. v20.08 releases are ABI compatible with the DPDK v20 ABI. ABI
>>    changes are permitted from DPDK v20.02 onwards, with the condition that ABI
>>    compatibility with DPDK v20 is preserved.
>>  * DPDK v21 is declared as the new supported ABI version for two years, aligned
>>    with the DPDK v20.11 (LTS) release. The DPDK v20 ABI is now depreciated,
>>    library sonames are updated to v21 and ABI compatibility breaking changes may
>>    be introduced.
> 
> OK I agree with these explanations.
> 
> 

  reply	other threads:[~2019-10-21 10:10 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-27 16:54 Ray Kinsella
2019-09-27 16:54 ` [dpdk-dev] [PATCH v6 1/4] doc: separate versioning.rst into version and policy Ray Kinsella
2019-10-01 12:50   ` Hemant Agrawal
2019-10-01 13:19     ` Ray Kinsella
2019-10-21  9:53   ` Thomas Monjalon
2019-10-25 11:36     ` Ray Kinsella
2019-09-27 16:54 ` [dpdk-dev] [PATCH v6 2/4] doc: changes to abi policy introducing major abi versions Ray Kinsella
2019-10-15 15:11   ` David Marchand
2019-10-25 11:43     ` Ray Kinsella
2019-10-24  0:43   ` Thomas Monjalon
2019-10-25  9:10     ` Ray Kinsella
2019-10-28 10:02       ` Thomas Monjalon
2019-10-25 12:45     ` Ray Kinsella
2019-09-27 16:54 ` [dpdk-dev] [PATCH v6 3/4] doc: updates to versioning guide for " Ray Kinsella
2019-09-27 16:54 ` [dpdk-dev] [PATCH v6 4/4] doc: add maintainer for abi policy Ray Kinsella
2019-10-21  9:50 ` [dpdk-dev] [PATCH v6 0/4] doc: changes to abi policy introducing major abi versions Thomas Monjalon
2019-10-21 10:10   ` Ray Kinsella [this message]
2019-10-21 14:38     ` Thomas Monjalon
2019-10-22  8:12       ` Ray Kinsella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=045a297d-27d7-87b4-b236-786cc2221ecd@ashroe.eu \
    --to=mdr@ashroe.eu \
    --cc=aconole@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerinj@marvell.com \
    --cc=john.mcnamara@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=ktraynor@redhat.com \
    --cc=marko.kovacevic@intel.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=nhorman@tuxdriver.com \
    --cc=olivier.matz@6wind.com \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).