From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 255FFA034F; Thu, 25 Feb 2021 07:52:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A8834406B4; Thu, 25 Feb 2021 07:52:07 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 56A254069B for ; Thu, 25 Feb 2021 07:52:06 +0100 (CET) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 7FD847F578; Thu, 25 Feb 2021 09:52:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 7FD847F578 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1614235925; bh=EfYurl2AUTlZ01lv0A/AzY/PbxmDx701l+LBAKUe7go=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=O5EOj+hbewRdqNm1+OP7ESkt7SLSL20w37qRpHpQVWHjs4FQHQD5epA+xsTG4aONX dyd6GDN/f5VydPBX7zNQdl2wz4PPX9P9sTUKLAZWuMy5WXIgUs4rSQKStm5yEkX51n XE80PZkDMR+u6thwusttC1xHS8WbmW2SPeLb/Z54= To: Lance Richardson , Xiaoyun Li , Olivier Matz , Jerin Jacob , Ajit Khaparde , Somnath Kotur , Beilei Xing , Jeff Guo , David Christensen , Bruce Richardson , Konstantin Ananyev , Ruifeng Wang , Jingjing Wu , Qiming Yang , Qi Zhang , Haiyue Wang , Nithin Dabilpuram , Kiran Kumar K , Rasesh Mody , Shahed Shaikh , Jiawen Wu , Jian Wang Cc: dev@dpdk.org, Ferruh Yigit References: <20210224162432.337182-1-lance.richardson@broadcom.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <046ae7de-0a21-f2f8-d2ce-b544bbf036d7@oktetlabs.ru> Date: Thu, 25 Feb 2021 09:52:05 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210224162432.337182-1-lance.richardson@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] mbuf: rename outer ip checksum macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/24/21 7:24 PM, Lance Richardson wrote: > Rename PKT_RX_EIP_CKSUM_BAD to PKT_RX_OUTER_IP_CKSUM_BAD and > deprecate the original name. The new name is better aligned > with existing PKT_RX_OUTER_* flags, which should help reduce > confusion about its purpose. > > Suggested-by: Ferruh Yigit > Signed-off-by: Lance Richardson Acked-by: Andrew Rybchenko I think deprecation notice should be added. > diff --git a/lib/librte_mbuf/rte_mbuf_core.h b/lib/librte_mbuf/rte_mbuf_core.h > index 9d1609336..796ef8059 100644 > --- a/lib/librte_mbuf/rte_mbuf_core.h > +++ b/lib/librte_mbuf/rte_mbuf_core.h > @@ -73,9 +73,18 @@ extern "C" { > */ > #define PKT_RX_IP_CKSUM_BAD (1ULL << 4) > > - /** External IP header checksum error. */ > +/** > + * Deprecated. > + * This flag has been renamed, use PKT_RX_OUTER_IP_CKSUM_BAD instead. > + */ > #define PKT_RX_EIP_CKSUM_BAD (1ULL << 5) > > +/** > + * This flag is set when the outermost IP header checksum is detected as > + * wrong by the hardware. > + */ > +#define PKT_RX_OUTER_IP_CKSUM_BAD (1ULL << 5) > + I think this one should be keep, but old one should be: #define PKT_RX_EIP_CKSUM_BAD PKT_RX_OUTER_IP_CKSUM_BAD with a comment as you have above. > /** > * A vlan has been stripped by the hardware and its tci is saved in > * mbuf->vlan_tci. This can only happen if vlan stripping is enabled >