From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D64FA0A0F; Fri, 16 Apr 2021 11:41:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4F9A1141C46; Fri, 16 Apr 2021 11:41:42 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 6EFDD141B83 for ; Fri, 16 Apr 2021 11:41:40 +0200 (CEST) IronPort-SDR: uMNFSJEY8Hdf6wIBykBsZ3buy9ey+W5gQ78lBY5hoXziyd2mXmzpC796KBPXxrqmq4p0LjhkaD q1EbEqcuYuaA== X-IronPort-AV: E=McAfee;i="6200,9189,9955"; a="280335142" X-IronPort-AV: E=Sophos;i="5.82,226,1613462400"; d="scan'208";a="280335142" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2021 02:41:39 -0700 IronPort-SDR: vmId632RcTNI0uJH6XNBMDfXlRxoYpejKpsJ/jlCjWM0P0ECYQ+oDIFZf01PN6td6qd+sPx7oC WD0AAgYwoUeg== X-IronPort-AV: E=Sophos;i="5.82,226,1613462400"; d="scan'208";a="453283343" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.207.150]) ([10.213.207.150]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2021 02:41:38 -0700 To: Thomas Monjalon , Lijun Ou Cc: dev@dpdk.org, linuxarm@openeuler.org, mdr@ashroe.eu References: <1618454426-21457-1-git-send-email-oulijun@huawei.com> <1618562810-20304-1-git-send-email-oulijun@huawei.com> <2292057.lhpI95xzKh@thomas> From: Ferruh Yigit X-User: ferruhy Message-ID: <04c856eb-7112-adf3-f072-ea1a5323c775@intel.com> Date: Fri, 16 Apr 2021 10:41:34 +0100 MIME-Version: 1.0 In-Reply-To: <2292057.lhpI95xzKh@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH V4] ethdev: add queue state when retrieve queue information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/16/2021 9:58 AM, Thomas Monjalon wrote: > 16/04/2021 10:46, Lijun Ou: >> Currently, upper-layer application could get queue state only >> through pointers such as dev->data->tx_queue_state[queue_id], >> this is not the recommended way to access it. So this patch >> add get queue state when call rte_eth_rx_queue_info_get and >> rte_eth_tx_queue_info_get API. >> >> Note: After add queue_state field, the 'struct rte_eth_rxq_info' size >> remains 128B, and the 'struct rte_eth_txq_info' size remains 64B, so >> it could be ABI compatible. > [...] >> --- a/doc/guides/rel_notes/release_21_05.rst >> +++ b/doc/guides/rel_notes/release_21_05.rst >> @@ -251,6 +251,12 @@ ABI Changes >> function was already marked as internal in the API documentation for it, >> and was not for use by external applications. >> >> +* Added new field ``queue_state`` to ``rte_eth_rxq_info`` structure >> + to provide indicated rxq queue state. >> + >> +* Added new field ``queue_state`` to ``rte_eth_txq_info`` structure >> + to provide indicated txq queue state. > > Not sure we should add a note here for additions which > do not break ABI compatibility. > It may be confusing. > Hi Thomas, What do about adding the documentation to "API Changes" section? Since 'rte_eth_rx_queue_info_get()'/'rte_eth_tx_queue_info_get()' can get 'queue_state' now, which may taken as API change.