From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <markus.theil@tu-ilmenau.de>
Received: from smail.rz.tu-ilmenau.de (smail.rz.tu-ilmenau.de [141.24.186.67])
 by dpdk.org (Postfix) with ESMTP id 7C5C12C15
 for <dev@dpdk.org>; Fri,  1 Sep 2017 00:07:06 +0200 (CEST)
Received: from [141.24.212.108] (thunderstorm.prakinf.tu-ilmenau.de
 [141.24.212.108])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by smail.rz.tu-ilmenau.de (Postfix) with ESMTPSA id 3054B580070;
 Fri,  1 Sep 2017 00:07:06 +0200 (CEST)
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, ferruh.yigit@intel.com
References: <1503408514-20079-1-git-send-email-markus.theil@tu-ilmenau.de>
 <1504174949-25656-1-git-send-email-markus.theil@tu-ilmenau.de>
 <1504174949-25656-3-git-send-email-markus.theil@tu-ilmenau.de>
 <20170831083207.3a95c3a7@xeon-e3>
From: Markus Theil <markus.theil@tu-ilmenau.de>
Organization: TU Ilmenau
Message-ID: <04f8dd98-16b8-a110-959c-525f4e60b3fb@tu-ilmenau.de>
Date: Fri, 1 Sep 2017 00:07:06 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20170831083207.3a95c3a7@xeon-e3>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [dpdk-dev] [PATCH v4 3/3] igb_uio: MSI IRQ mode
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 31 Aug 2017 22:07:06 -0000



On 31.08.2017 17:32, Stephen Hemminger wrote:
> On Thu, 31 Aug 2017 12:22:29 +0200
> Markus Theil <markus.theil@tu-ilmenau.de> wrote:
>
>> +/*
>> + * It masks the msi on/off of generating MSI messages.
>> + */
>> +static void
>> +igbuio_msi_mask_irq(struct pci_dev *pdev, struct msi_desc *desc, int32_t state)
>> +{
>> +	u32 mask_bits = desc->masked;
>> +	u32 offset = desc->irq - pdev->irq;
>> +	u32 mask = 1 << offset;
>> +	u32 flag = !!state << offset;
>> +
>> +	if (!desc->msi_attrib.maskbit)
>> +		return;
>> +
>> +	mask_bits &= ~mask;
>> +	mask_bits |= flag;
>> +
>> +	if (mask_bits != desc->masked) {
>> +		pci_write_config_dword(pdev, desc->mask_pos, mask_bits);
>> +		desc->masked = mask_bits;
>> +	}
>> +}
>> +
> Why not use the existing kernel API pci_msi_mask_irq()?
Thanks for the advice, I have considered it in v5.