From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Thomas Monjalon'" <thomas@monjalon.net>
Cc: <dev@dpdk.org>, <zaiyuwang@trustnetic.com>,
"'Stephen Hemminger'" <stephen@networkplumber.org>
Subject: RE: [PATCH 02/12] net/txgbe: refactor FDIR filter to improve functionality
Date: Thu, 12 Jun 2025 09:42:34 +0800 [thread overview]
Message-ID: <055701dbdb3b$44eedda0$cecc98e0$@trustnetic.com> (raw)
In-Reply-To: <11711540.2WqB4rESCP@thomas>
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Thursday, June 12, 2025 8:30 AM
> To: Jiawen Wu <jiawenwu@trustnetic.com>
> Cc: dev@dpdk.org; zaiyuwang@trustnetic.com; Stephen Hemminger <stephen@networkplumber.org>
> Subject: Re: [PATCH 02/12] net/txgbe: refactor FDIR filter to improve functionality
>
> 06/06/2025 10:01, Jiawen Wu:
> > There were some defects in the original configuration for flow director
> > filter. Now make the following improvements:
> >
> > 1) Fix incorrect parsing to ntuple filter when set the pattern likes:
> > flow create ... ipv4 / udp dst is ... / raw ... / end actions ... / end
> > 2) Fix flex offset base to set item RAW relative = 1, and convert RAW
> > pattern string to hex bytes to match the hardware identification.
> > 3) Fix to create FDIR rules for VXLAN/GRE/NVGRE/GENEVE packets, they will
> > match the rules in the inner layers.
> > 4) Support IPv6 perfect mode.
> > 5) Add packet type mask to match more types of packets if the pattern is
> > default.
>
> That's a lot of various changes for a single patch.
> Please could you split it?
I'll try to do it.
Should I send v3 patches for the whole series? Or just these split patches.
next prev parent reply other threads:[~2025-06-12 1:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250606080117.183198-1-jiawenwu@trustnetic.com>
2025-06-06 8:01 ` [PATCH 01/12] net/txgbe: support flow filter for VF Jiawen Wu
2025-06-06 8:01 ` [PATCH 02/12] net/txgbe: refactor FDIR filter to improve functionality Jiawen Wu
2025-06-06 16:23 ` Stephen Hemminger
2025-06-12 0:29 ` Thomas Monjalon
2025-06-12 1:42 ` Jiawen Wu [this message]
2025-06-12 1:53 ` Thomas Monjalon
2025-06-06 8:01 ` [PATCH 03/12] net/txgbe: fix reserved extra FDIR headroom Jiawen Wu
2025-06-06 8:01 ` [PATCH 04/12] net/txgbe: support RSS offload for SCTP port Jiawen Wu
2025-06-06 8:01 ` [PATCH 05/12] net/ngbe: " Jiawen Wu
2025-06-06 8:01 ` [PATCH 06/12] net/txgbe: fix MAC control frame forwarding Jiawen Wu
2025-06-06 8:01 ` [PATCH 07/12] net/ngbe: " Jiawen Wu
2025-06-06 8:01 ` [PATCH 08/12] net/txgbe: fix incorrect device statistics Jiawen Wu
2025-06-06 8:01 ` [PATCH 09/12] net/ngbe: " Jiawen Wu
2025-06-06 8:01 ` [PATCH 10/12] net/txgbe: restrict VLAN strip configuration on VF Jiawen Wu
2025-06-06 8:01 ` [PATCH 11/12] net/ngbe: " Jiawen Wu
2025-06-06 8:01 ` [PATCH 12/12] net/txgbe: add missing LRO flag in mbuf when LRO enabled Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='055701dbdb3b$44eedda0$cecc98e0$@trustnetic.com' \
--to=jiawenwu@trustnetic.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
--cc=zaiyuwang@trustnetic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).