From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4BDC43AB3; Thu, 8 Feb 2024 02:03:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 53ABF409FA; Thu, 8 Feb 2024 02:03:04 +0100 (CET) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2087.outbound.protection.outlook.com [40.107.95.87]) by mails.dpdk.org (Postfix) with ESMTP id 6FE47406BC for ; Thu, 8 Feb 2024 02:03:02 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kCkmYwVCgR/G9tFAUGw9tSltsQ5cXDm/kDdUwvKLlaDV1IY4l4pnwjJCnKJ7Q1RA6675HNju/lnPABdeTJFzjgc9+mwBQeUynpKOYCg9Gs4i3pnBMbc9t6dpQEcLH4NvDj1bHBSJr1yeBXHjtgoWqWohcvsr/+z5jXd01KbnrRyvnYejodNzbdkJ2ACHn8JeWYZ50VmFauBRqD1HKORKnLjm1YsfsfjNxMo/LUpXSZwef4RX9nliqMrowJsmNJ/K8VRt1YBe3eAxhmYvenalUKJUe/b4e2KPR/UQDWOgLCnx/67Whvy3Lu42A96um+vDAq7IG9mJe70/cCzgTTWLng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2JQsfk8WpnGGppqL1jd9aCb7OvnGIaD0L5tjI7hb8Rc=; b=odi5lh7qzrATAIv1JU8uZAF+8B1b8ZmuFJBINwnnUjRg//zkz7r7UHVdDF7CrLp+tSMMUl9UYO6s/khHZ+AfjmMfAEzQcmEpKIOmSTlbMxOioM+YzT8FguKVysXKpy0f1yaL5C6zp8nuhDo/i5FvGJ7ztUHQAhrIBFRQR55U5zAxLGryLSppPzUEvkGpQKl9snkA55GIYMO+7TsR2N+jXDxH07qf6RuKgNmOvuFH51xCZlrCQfLJBsOqKelgzwM4SoUBcGm6HmtfPHaXA+3U2/Yd5RTUYMg66GSDvmBhmZd8TmbIjsaeOQRUxLeELZa51EGy3bO7CnBTMEX5Mz91Zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2JQsfk8WpnGGppqL1jd9aCb7OvnGIaD0L5tjI7hb8Rc=; b=oG1UdedxSgUdnWbtLF3lMf5CH3MyuBP8ZWiXzapOnXn1KQMhL0Tx9/v3SxUESVrk3+Jk2wK7WKsQawv2ODd/S2EsHpk5lFzBeAKEkhjTz4l8f7CJu2zhvc1RcFuaYlBZvC8WrxjaTiBlFprx3+CSGgxad4XMdyJVsKcR98poyoo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH2PR12MB4309.namprd12.prod.outlook.com (2603:10b6:610:a4::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.17; Thu, 8 Feb 2024 01:03:00 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7292.009; Thu, 8 Feb 2024 01:03:00 +0000 Message-ID: <055f868d-1bb0-4871-bb13-85cb53b5a89c@amd.com> Date: Thu, 8 Feb 2024 01:02:56 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] net/nfb: driver cleanups Content-Language: en-US To: Martin Spinler , Stephen Hemminger Cc: dev@dpdk.org, Thomas Monjalon References: <20231206175326.116375-1-stephen@networkplumber.org> <20231207185720.19913-1-stephen@networkplumber.org> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P123CA0027.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:313::19) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH2PR12MB4309:EE_ X-MS-Office365-Filtering-Correlation-Id: faf0b0d7-7b86-4075-9e99-08dc2841b1b5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BuXPCCbOX9K+oUFXva11VTJUm42iyIHB5CtBm2ZEzemfFSknk20WQyEgfvpfWX4gYKxNM+uMzAg963w7EHwtLUCSgXyndj1DLX/r/OAMpD1sqxrRfZGZpzsond11o+2mAwZEGGc/bMlgl00Ix4ps6AKlkMbB1ctRwgBxqlk6Pc8BnouUhAICs9XqRuMkcrxFdQImT/Fb754DNvhv/8fLUSSxmLgPMWqhoxSB5c1Cz/rn6Ajkvi9O72UN4ZwGjPG/H6gK8IFqOUKQ5ae18EBNS3+j1she5f39kgulBy4K/urP69lKh222y+ykzx8XTGtMDoUdwo8b1Xtm4zEBNQUOapRZejm/nYkLVnxovCyemUeeiOHEOI75pOnRuYy2XHT38qN8Viluag/bqsP7u5YAaCuygloCwDWYKzLeXo8+wxkp4O5zZmiyRFaP/kb0f82YH3Sn05Jeli+kBYaY/QNU+KUfpUOyXKrLklbQN00thrbalzRPcAtyQFNmT/UTTNQWpz3i9BTuWZRpp2e+YMABvIgdpFS3HLwDYpaVcBFk2YM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(376002)(346002)(396003)(136003)(39860400002)(230922051799003)(451199024)(64100799003)(1800799012)(186009)(66556008)(31696002)(41300700001)(6486002)(86362001)(36756003)(8676002)(966005)(316002)(8936002)(4326008)(66946007)(5660300002)(53546011)(110136005)(6506007)(66476007)(2906002)(38100700002)(478600001)(6666004)(6512007)(2616005)(44832011)(26005)(31686004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZHpCd01ESUUvZy9ndlZMWlE1ajhMekVjUmJVZWI0UUxXeVdCcDhDMG1Gci82?= =?utf-8?B?SHAyOWlVNnpNWGxzWDdMcm5IWVJVZHBmZ21wR3ZRWDExUS9OZlN2dHh1aXRC?= =?utf-8?B?cE4zalBET003d3J5WU5admRzeDR0by9yckFCenhESXRHaVEza2tDb2ZZTi90?= =?utf-8?B?KzhOczNsU1ZwYWNnbHI1ZjAwUnF2eXJOcDdhRDlkeWlWT2hVeGZiSUNKV2dY?= =?utf-8?B?QW53bXpzR1k0TysrOW9pT1ZiZ0RIdS9tdmdTYUlra0RrRGo5WDFWZ2oxbEo1?= =?utf-8?B?QjdhWXJHM2gzZFNwUmZCYXpjMytkRVUvUEdNQVRBSWhlQW1RdkFVVHJFMFg2?= =?utf-8?B?R0ZWYXJCaGxOVTNMeFk0dnVVdVpES0FzWmNENWJpWDZmdXRTT3VjNXcraGtS?= =?utf-8?B?TDh1bUplU3ZCM25QazYzczZsZHFCaTY3T3lsOFdGZTVZdEF3aUpnTjhaTUlm?= =?utf-8?B?RjJhQ1JRb3NiYkxjVDVhd05mSHRPRjFxRW9jdGxOb3VScGJsQ1pJeEI2VDRz?= =?utf-8?B?NnBMVUFQUko0SGdhWlBYQmcyQ3NHUElWTHVzMlRiSndySnRwYnByTHRSZ3RS?= =?utf-8?B?R1djbWpQTXJ2MGlkbW9jaDQwK0g2dmdRTzNiR1VmR05LTHpCK2E1QUpGYVFl?= =?utf-8?B?bU1DZGFUaWR0bTUrNWE4ZmdzQVAyRjBGc29xb1pMc1RQaEs5cDNJamZwZTg5?= =?utf-8?B?R2lKbHp0MGdjUnJYL3dSaHlQZWQxNzZaMVEvQUtPb1M1WmRpRHR2Zm9KZi9S?= =?utf-8?B?Y0Q2R0hMcXRhS1AzMlNJaktCV1ZlYjNJK2J4bHBLRjE2RUFmcG1oT3ZGTWda?= =?utf-8?B?RDhBZWRtOG1FSUNSYWlOSWlmdVpqUUFqTFNNZWhSTTRNWWdNdVAyWDFWZFNa?= =?utf-8?B?OEhTY1NmQXc3NEpkNmQ3a2l5UmJNalVJYnJjVDZjYUpkV3Jsem12MVk1Z1Vm?= =?utf-8?B?WFcxY2tNT3A0RHRmaFY0WEU1bTREb1d4MklMSnVjTWJzaUk2SXhjSW1EQVh2?= =?utf-8?B?RFBHTkVTNVQxSUw2bGoxcE12UEgvVEJoTVp6K2srRG8vWjRVOHpxQTNUazhk?= =?utf-8?B?TU9DUlJqZkVEdm9Tc3JNUEJPUy9vV1lJemhCaFQrendQUkxobmJSS0xuMDJs?= =?utf-8?B?WkNiWGdUVXFqU2lmU2JjTUhHbnRUWElaQ3hvN0hSUlJOU1l2Zm1tb0xsZTF1?= =?utf-8?B?RjRZT0k4ZktmQ1RsNmpybUpRYVpraWNXaFVvVVpWY2VHa2xPaXk0Z2U0anRP?= =?utf-8?B?aDVBdmtmRXNEclhNaFBkQmhzRGJ6aDlqY0xmd20ybEpnQndnS3B3Sm9Wc0Rx?= =?utf-8?B?VjZ4U2ZDQmZyaHNFWVU3dWhLKzJuY2pDYVpxR08rd2E3bmx1QUVJM3NxR3ZC?= =?utf-8?B?Rm1hYXQyaXNuVVNGbDR3c0VHRVF4b3AvT0NDbW0yeUk3MkpreGRLZVcyVlVu?= =?utf-8?B?VGxSaUJvcFgxclVlRWlqTFExQTZoUTF0cXZMcURoVTNQdWg5SWRtYXZrNEtz?= =?utf-8?B?bmprOXYwV0xkUmZsL0ZsRlN4aUtiTXp0NlpzdFUyUUhKSVJmSVpZb1ZkNUQ1?= =?utf-8?B?MmZIdGREQUxmalZ6K3VaUlM3Q1FHN2wyQkR5M29ENldBTVpNV0lEL0MzUEZz?= =?utf-8?B?OFBMdlo2b05sUzFqekRzL1VvQVY0dHVtMFdGYUROMEx0VmdRd0cvTk9OQXVy?= =?utf-8?B?R1VhanJ2bXAwTDF2bElkYnppdmhNWUlremFIY3ZrWkRLemkrMjEzSHJ6eUV3?= =?utf-8?B?T2N3RktaR1QxeFVQQXJwSHlLR0dHTEdkcWUvRDVBem10bTlUUVdwTnVORWtU?= =?utf-8?B?UW9vakhzclpvdjJhWVpKRkFGblhCaURvclBpbDJWSmsxSjg2VjFaZVpaR0Ji?= =?utf-8?B?ODBDcEV6WVk3Q1l6bzZNR3I0cUpjaEtkV1BUSDFXQmJHTldjbW9HVHdZVi81?= =?utf-8?B?em1mZUFpeVE2RHB4L2VUMDRrdFJrT1d3OGhvNGljcWd0NzFXNTN3VWxuSVJo?= =?utf-8?B?Sy9ENERXWlloYVpXa1lPQnhscVpxZk0xcUdUQmN3WnFWU21JTTRaSml1YVE2?= =?utf-8?B?Zk9YbmtDc3hKcWZ2VzFXQTVtZ0NhSldnakVFUWJFMnN3aDVkU2RQWENCV05v?= =?utf-8?Q?LJX1P17WKGFEkFZs0peKwYoHY?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: faf0b0d7-7b86-4075-9e99-08dc2841b1b5 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2024 01:03:00.1752 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XpJUsdhlFMkHP0+B7yWjHW18TmXewDAAumXx+gr4RrssWoJyzgL/G6IkUeTtDXtB X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4309 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/12/2024 1:50 PM, Martin Spinler wrote: > Tested-by: Martin Spinler > Acked-by: Martin Spinler > > --- > > Hi! Thanks for the cleanup. I've tested that patchset and works fine. > > I'm just not sure, if the "net/nfb: use dynamic logtype" patch merges > with the "Remove uses of PMD logtype" series as they slightly differs > (both links below). > Stephen, would it make sense to remove the last patch from this series? > > https://patchwork.dpdk.org/project/dpdk/patch/20231207185720.19913-4-stephen@networkplumber.org/ > https://patchwork.dpdk.org/project/dpdk/patch/20231222171820.8778-9-stephen@networkplumber.org/ > Second one is larger set with multiple components involved, this one is more specific, I will proceed with this one. @Thomas may drop the nfp patch in that series. > > On Fri, 2024-01-12 at 12:16 +0000, Ferruh Yigit wrote: >> On 12/7/2023 6:56 PM, Stephen Hemminger wrote: >>> Replace static logtype with dynamic logtype and >>> remove dead code. Compile tested on Fedora. >>> >>> Stephen Hemminger (3): >>> net/nfb: remove unused device args >>> net/nfb: make device path local to init function >>> net/nfb: use dynamic logtype >>> >>> >> >> Hi Martin, >> >> Can you please review the set? >