From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7AA2BA052A; Wed, 27 Jan 2021 18:46:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F1C15141009; Wed, 27 Jan 2021 18:46:13 +0100 (CET) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id 220AA140FFB for ; Wed, 27 Jan 2021 18:46:13 +0100 (CET) Received: by mail-pl1-f176.google.com with SMTP id 31so1441466plb.10 for ; Wed, 27 Jan 2021 09:46:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=sisbJgmX52daogiRwfjRZeE1xkKAoyUW4lXvHJLVXxQ=; b=OMtHXiu+t74HHQkbAlftzVm4BfdwJ1HTFBODXHaE3d0DVkqg8ev0mX/cdtZ4Ov34BT e7UO5LKTR1xgivZelTdf3+XlaxSIjsTZn1lFbrQIC7iLdwTaZhs8p6VvsOYBshL/W6Sn nxknhmZMAxc5gjpeI83/Q4Ik54g8i2q+l76+Ba4q7wHEYgPrDGyUhWj2lG1jZISY8M8O Jxov7udzefmy7JX7lsr9BmPV9oMUzGv0sseazJpJKCmFNqih0dSYH4LGEEp1LvE+qdFN ot6spabkb3l0eZ+I2UuFdKrmcHrqXxl33EaB58OgJx+VBqQT8ytX6+Cqi9shxcxYccMe V/cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=sisbJgmX52daogiRwfjRZeE1xkKAoyUW4lXvHJLVXxQ=; b=GRZASVieWvrWLM6oYX5D21d8YAWTwobLmfuXCDqsM2ahpNHG+a8LpZ77celZMUuLGL +rhzXN7GFalwcFWrnqKTyztV0OkSEVq1pCd5CEbXKmhlIiKi0LC2RA76S3UL/8nR7pJQ llRJ8CVS4cTiNKVO+1557gZeWvQoCJjy/kg3Z2y4FG9STqUR0aRcsRWmj1Pkw/ZjNISJ nPB78r0SJnSt+dBOhNbWbxtI1XQV8WW9n/o3WGeDPuNicdfbckxucxca9bUc7iabKgUM 7Z/D43nbWcfAH2ZWygn2SczaQ6rhOknbiTBN+/uE7OBmlSISiOG7ZahcD0YkVG/m9P6o aViw== X-Gm-Message-State: AOAM532DrPQJhEju/u3mihQdncwmIdnA18NQ2threDQ23inZaiZZS/gT DQUyrIvb5KQF5hiufU2OZkbTZQ== X-Google-Smtp-Source: ABdhPJxjxcNVXk7G3MDnxbwCbnuAfxcDWQdiGa6FxfqIrb27KJ2IA7Z8qYe7oq241OTwm781qYFwKg== X-Received: by 2002:a17:90a:de97:: with SMTP id n23mr7020923pjv.216.1611769572315; Wed, 27 Jan 2021 09:46:12 -0800 (PST) Received: from ?IPv6:2600:1700:6b0:fde0:8db4:403d:f1a5:aac2? ([2600:1700:6b0:fde0:8db4:403d:f1a5:aac2]) by smtp.gmail.com with ESMTPSA id m195sm3083215pfd.215.2021.01.27.09.46.10 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Jan 2021 09:46:11 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) From: Andrew Boyer In-Reply-To: Date: Wed, 27 Jan 2021 12:46:09 -0500 Cc: dev , Alfredo Cardigliano , Ray Kinsella , Thomas Monjalon Content-Transfer-Encoding: quoted-printable Message-Id: <05689D29-7F81-4DC6-817C-300358F0EFFE@pensando.io> References: <20210118203508.1332-1-aboyer@pensando.io> <20210118203508.1332-7-aboyer@pensando.io> To: Ferruh Yigit X-Mailer: Apple Mail (2.3608.120.23.2.4) Subject: Re: [dpdk-dev] [PATCH 06/13] net/ionic: clean up Tx queue version support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Jan 27, 2021, at 12:30 PM, Ferruh Yigit = wrote: >=20 > On 1/18/2021 8:35 PM, Andrew Boyer wrote: >> The ionic PMD only supports TX queue version 1 or greater. >> Version 1 introduced a new SGL format with support for more >> fragments per descriptor. >> Signed-off-by: Andrew Boyer >=20 > <...> >=20 >> @@ -925,6 +925,11 @@ ionic_lif_alloc(struct ionic_lif *lif) >> ionic_lif_queue_identify(lif); >> + if (lif->qtype_info[IONIC_QTYPE_TXQ].version < 1) { >> + IONIC_PRINT(ERR, "FW too old, please upgrade"); >> + return -ENXIO; >> + } >> + >=20 > Will this affect the end users, if they were using old FW? >=20 > Can you please document this new limitation in the diriver = documentation and in the release notes? I will come up with something. We don=E2=80=99t believe it=E2=80=99s possible for anyone to be using FW = that old; there were only a few customers with cards back then and all = have been upgraded. We decided that locking old FW out would be better = than adding complexity in the hot path to handle the old data = structures. -Andrew