From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id EA5D18D3B for ; Mon, 11 Jan 2016 11:47:17 +0100 (CET) Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O0S0035TBAS79A0@mailout1.w1.samsung.com> for dev@dpdk.org; Mon, 11 Jan 2016 10:47:16 +0000 (GMT) X-AuditID: cbfec7f5-f79b16d000005389-c9-569388336a8c Received: from eusync2.samsung.com ( [203.254.199.212]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id D5.65.21385.33883965; Mon, 11 Jan 2016 10:47:15 +0000 (GMT) Received: from fedinw7x64 ([106.109.131.169]) by eusync2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0O0S00HDXBAR3OA0@eusync2.samsung.com>; Mon, 11 Jan 2016 10:47:15 +0000 (GMT) From: Pavel Fedin To: 'Jianfeng Tan' , dev@dpdk.org References: <1451956062-45932-1-git-send-email-jianfeng.tan@intel.com> In-reply-to: <1451956062-45932-1-git-send-email-jianfeng.tan@intel.com> Date: Mon, 11 Jan 2016 13:47:14 +0300 Message-id: <056b01d14c5d$6f814f70$4e83ee50$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQDlwXz9dMi3ZzNgDudYNg1I3lsEGqDNNwYw Content-language: ru X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDLMWRmVeSWpSXmKPExsVy+t/xK7rGHZPDDLZfNbZ492k7k0X37C9s DkwevxYsZfVYvOclUwBTFJdNSmpOZllqkb5dAlfGpmlHmAsWClb8ejGXvYHxN28XIyeHhICJ xL9NdxghbDGJC/fWs3UxcnEICSxllDjx+jYThPOdUWLJ9YOsIFVsAuoSp79+YAGxRQQsJT69 +ccMYgsJuElMmNwJNImDg1PAXeLeHnGQsLBAiMTOK7+YQGwWAVWJ402tbCA2L1Drscb/LBC2 oMSPyffAbGYBLYnN25pYIWx5ic1r3jJDHKcgsePsa0aItUYSbSfWMkLUiEhM+3ePeQKj4Cwk o2YhGTULyahZSFoWMLKsYhRNLU0uKE5KzzXSK07MLS7NS9dLzs/dxAgJ4687GJceszrEKMDB qMTDO2PXpDAh1sSy4srcQ4wSHMxKIry7syeHCfGmJFZWpRblxxeV5qQWH2KU5mBREueduet9 iJBAemJJanZqakFqEUyWiYNTqoHReJ6G5Iebkrt3R04R6Zq3U7bgld9RwYd7K0/Y2b70DFmq UStreeixefb6hPgLOXpfO7hlkn11P/h1rm2oYOW5dZPTWC9IJ6ON86z4sX0Vs5O+PJdJOrjS a+/e2osHaiUedFZsP6W2WlNHfkoKX9S242mSvHqvu7sOTYpanvsk9Sv/ctVCkV9KLMUZiYZa zEXFiQD1If9fXwIAAA== Subject: Re: [dpdk-dev] [PATCH] pmd/virtio: fix cannot start virtio dev after stop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jan 2016 10:47:18 -0000 Hello! I tried to apply your patch to master and got compile errors. See inline. > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jianfeng Tan > Sent: Tuesday, January 05, 2016 4:08 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] pmd/virtio: fix cannot start virtio dev after stop > > Fix the issue that virtio device cannot be started after stopped. > > The field, hw->started, should be changed by virtio_dev_start/stop instead > of virtio_dev_close. > > Signed-off-by: Jianfeng Tan > --- > drivers/net/virtio/virtio_ethdev.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index d928339..07fe271 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -490,11 +490,13 @@ virtio_dev_close(struct rte_eth_dev *dev) > > PMD_INIT_LOG(DEBUG, "virtio_dev_close"); > > + if (hw->started == 1) > + virtio_dev_stop(eth_dev); > + 'dev', but not 'eth_dev' here. > /* reset the NIC */ > if (pci_dev->driver->drv_flags & RTE_PCI_DRV_INTR_LSC) > vtpci_irq_config(hw, VIRTIO_MSI_NO_VECTOR); > vtpci_reset(hw); > - hw->started = 0; > virtio_dev_free_mbufs(dev); > virtio_free_queues(dev); > } > @@ -1408,10 +1410,9 @@ eth_virtio_dev_uninit(struct rte_eth_dev *eth_dev) > if (rte_eal_process_type() == RTE_PROC_SECONDARY) > return -EPERM; > > - if (hw->started == 1) { > - virtio_dev_stop(eth_dev); > - virtio_dev_close(eth_dev); > - } > + /* Close it anyway since there's no way to know if closed */ > + virtio_dev_close(eth_dev); > + > pci_dev = eth_dev->pci_dev; > > eth_dev->dev_ops = NULL; > @@ -1615,6 +1616,8 @@ virtio_dev_stop(struct rte_eth_dev *dev) > > PMD_INIT_LOG(DEBUG, "stop"); > > + hw->started = 0; > + 'hw' is not declared in this function, you have to add it. > if (dev->data->dev_conf.intr_conf.lsc) > rte_intr_disable(&dev->pci_dev->intr_handle); > > -- > 2.1.4 Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia