From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7CC0BA04A2;
	Tue, 12 May 2020 10:29:11 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id A80C11C06D;
	Tue, 12 May 2020 10:29:06 +0200 (CEST)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 81C401C038;
 Tue, 12 May 2020 10:29:04 +0200 (CEST)
IronPort-SDR: Rbh8UU/TM+MTeWMeymwep4U5LNs2zI1pdFHEsq+ihJ4gFgWzJx+xK+837XKE273AAz6210r2xn
 qj79jFy00SWw==
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 12 May 2020 01:29:03 -0700
IronPort-SDR: 4scxfLslhYmUO8mYq18tyOurLWvzy1EcuVCl9DabcBIMw7GqcjVN+fxJVSmdbWHn6SkhiNM/au
 mWahnAgfLo9Q==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.73,383,1583222400"; d="scan'208";a="371492563"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
 by fmsmga001.fm.intel.com with ESMTP; 12 May 2020 01:29:03 -0700
Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by
 FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Tue, 12 May 2020 01:29:03 -0700
Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by
 FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Tue, 12 May 2020 01:29:03 -0700
Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.225]) by
 SHSMSX105.ccr.corp.intel.com ([169.254.11.92]) with mapi id 14.03.0439.000;
 Tue, 12 May 2020 16:28:59 +0800
From: "Sun, GuinanX" <guinanx.sun@intel.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "stable@dpdk.org" <stable@dpdk.org>, "Guo, Jia" <jia.guo@intel.com>
Thread-Topic: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow
 control	mode
Thread-Index: AQHWJy/3Vcw3Q3gQyUuryDnDs3WEhKikH9zQ
Date: Tue, 12 May 2020 08:28:59 +0000
Message-ID: <05758BDAD7FC8E4BAED63D0390A8A955848232@SHSMSX101.ccr.corp.intel.com>
References: <20200508082939.32525-1-guinanx.sun@intel.com>
 <MWHPR11MB1391F5DA13530185C862D6A6B7A10@MWHPR11MB1391.namprd11.prod.outlook.com>
In-Reply-To: <MWHPR11MB1391F5DA13530185C862D6A6B7A10@MWHPR11MB1391.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow
 control	mode
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi zhaowei

> -----Original Message-----
> From: Zhao1, Wei
> Sent: Monday, May 11, 2020 9:03 AM
> To: Sun, GuinanX <guinanx.sun@intel.com>; dev@dpdk.org
> Cc: Sun, GuinanX <guinanx.sun@intel.com>; stable@dpdk.org; Guo, Jia
> <jia.guo@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow c=
ontrol
> mode
>=20
>=20
> Hi, Guinan
>=20
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Guinan Sun
> > Sent: Friday, May 8, 2020 4:30 PM
> > To: dev@dpdk.org
> > Cc: Sun, GuinanX <guinanx.sun@intel.com>; stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow
> > control mode
> >
> > The register autoneg can't be updated synchronously with flow control
> > mode setting in the state of port start , so NIC statistics error
> > occurs. The patch fixes the issue.
> >
> > Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
> > ---
> >  drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > index cf5f1fe70..e6c747aef 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > @@ -2543,6 +2543,8 @@ ixgbe_flow_ctrl_enable(struct rte_eth_dev *dev,
> > struct ixgbe_hw *hw)  int err;  uint32_t mflcn;
> >
> > +hw->mac.ops.setup_fc(hw);
>=20
> 1. please use base code API ixgbe_setup_fc(), do not use internal functio=
n
> directly.
> 2. please more info for this patch, what register error you want to fix, =
and why it
> can fix.

V2 patch will be send to resolve the problems.

>=20
>=20
> > +
> >  err =3D ixgbe_fc_enable(hw);
> >
> >  /* Not negotiated is not an error case */
> > --
> > 2.17.1
>=20