From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6363FA0093; Mon, 15 Jun 2020 08:28:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8B47C54AE; Mon, 15 Jun 2020 08:28:58 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 916D35323 for ; Mon, 15 Jun 2020 08:28:56 +0200 (CEST) IronPort-SDR: 5mGRLIwLPaZANXhrqC0sZyH/JSJxPswbqDnWAW4Os8AA6n1YZtvrFSxdLsqd4c4vvLV+udUMxe pr0tMbe7wg7w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2020 23:28:55 -0700 IronPort-SDR: wCZqxYJXLcyoRV0YqEYrfxfBZAClLPbrl8agg6SCU74BEDnHv+0R2vpGF5OtV1ei0RCV4UkyF9 O5ccdRaZ33EA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,514,1583222400"; d="scan'208";a="449181626" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga005.jf.intel.com with ESMTP; 14 Jun 2020 23:28:54 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 14 Jun 2020 23:28:54 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 14 Jun 2020 23:28:53 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.85]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.253]) with mapi id 14.03.0439.000; Mon, 15 Jun 2020 14:28:50 +0800 From: "Sun, GuinanX" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "Xing, Beilei" , "Guo, Jia" Thread-Topic: [dpdk-dev] [PATCH] net/i40e: enable port filter by switch filter Thread-Index: AQHWP7GtRiN+juemnk6tFjgwN9JHDqjYsnGAgACJVfA= Date: Mon, 15 Jun 2020 06:28:49 +0000 Message-ID: <05758BDAD7FC8E4BAED63D0390A8A955867F90@SHSMSX101.ccr.corp.intel.com> References: <20200611052416.14592-1-guinanx.sun@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: enable port filter by switch filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi zhaowei > -----Original Message----- > From: Zhao1, Wei > Sent: Monday, June 15, 2020 2:13 PM > To: Sun, GuinanX ; dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia ; S= un, > GuinanX > Subject: RE: [dpdk-dev] [PATCH] net/i40e: enable port filter by switch fi= lter >=20 > Hi, Guinan >=20 > > -----Original Message----- > > From: dev On Behalf Of Guinan Sun > > Sent: Thursday, June 11, 2020 1:24 PM > > To: dev@dpdk.org > > Cc: Xing, Beilei ; Guo, Jia > > ; Sun, GuinanX > > Subject: [dpdk-dev] [PATCH] net/i40e: enable port filter by switch > > filter > > > > This patch enables the filter that supports to create following two > > rules for the same packet type: > > One is to select source port only as input set and the other is for > > destination port only. > > > > Signed-off-by: Guinan Sun > > --- > > doc/guides/rel_notes/release_20_08.rst | 7 + > > drivers/net/i40e/i40e_ethdev.c | 195 ++++++++++++++++++++- > > drivers/net/i40e/i40e_ethdev.h | 17 ++ > > drivers/net/i40e/i40e_flow.c | 223 > > +++++++++++++++++++++++++ > > 4 files changed, 441 insertions(+), 1 deletion(-) > > > > diff --git a/doc/guides/rel_notes/release_20_08.rst > > b/doc/guides/rel_notes/release_20_08.rst > > index 7a67c960c..16870100d 100644 > > --- a/doc/guides/rel_notes/release_20_08.rst > > +++ b/doc/guides/rel_notes/release_20_08.rst > > @@ -68,6 +68,13 @@ New Features > > > > * Added new PMD devarg ``reclaim_mem_mode``. > > > > +* **Updated Intel i40e driver.** > > + > > + Updated i40e PMD with new features and improvements, including: > > + > > + * Added a new type of cloud filter to support the coexistence of the > > + following two rules. One selects L4 destination as input set and > > + the other one selects L4 source port. > > > > Removed Items > > ------------- > > diff --git a/drivers/net/i40e/i40e_ethdev.c > > b/drivers/net/i40e/i40e_ethdev.c index 970a31cb2..97e6e948a 100644 > > --- a/drivers/net/i40e/i40e_ethdev.c > > +++ b/drivers/net/i40e/i40e_ethdev.c > > @@ -7956,6 +7956,13 @@ i40e_dev_tunnel_filter_set(struct i40e_pf *pf, > > #define I40E_TR_GRE_KEY_MASK0x400 #define > > I40E_TR_GRE_KEY_WITH_XSUM_MASK0x800 > > #define I40E_TR_GRE_NO_KEY_MASK0x8000 >=20 > > +#define I40E_AQC_REPLACE_CLOUD_CMD_INPUT_PORT_TR_WORD0 0x49 >=20 > A confused question, this 0x49 seems to be a field vector index? Filed ve= ctor > table is 128 byte long, why does this can large than 64? >=20 This is not field vector. Examples of filed vector use are as follows I40E_AQC_ADD_CLOUD_FV_FLU_0X11_WORD1 or=20 I40E_AQC_ADD_CLOUD_FV_FLU_0X10_WORD1. >=20 > > #define > > +I40E_AQC_REPLACE_CLOUD_CMD_INPUT_DIRECTION_WORD0 0x41 > #define > > +I40E_AQC_REPLACE_CLOUD_CMD_INPUT_INGRESS_WORD0 0x80 #define > > +I40E_DIRECTION_INGRESS_KEY0x8000 #define I40E_TR_L4_TYPE_TCP0x2 > > +#define I40E_TR_L4_TYPE_UDP0x4 #define I40E_TR_L4_TYPE_SCTP0x8 > > > > static enum > > i40e_status_code i40e_replace_mpls_l1_filter(struct i40e_pf *pf) @@ > > -8254,6 +8261,131 @@ i40e_status_code > > i40e_replace_gtp_cloud_filter(struct i40e_pf *pf) return status; >=20