From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 364C7A052B; Fri, 31 Jul 2020 06:09:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F144B1C00D; Fri, 31 Jul 2020 06:09:12 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 271941BFFD; Fri, 31 Jul 2020 06:09:10 +0200 (CEST) IronPort-SDR: oggRI5ou0qD+2sU7ycv8qpxfrzsA/3WF+FcGKJmYdHnG71uZZuxp9XFCBQjwKjz3oFX704P59J UwHIS4aMc09w== X-IronPort-AV: E=McAfee;i="6000,8403,9698"; a="131295473" X-IronPort-AV: E=Sophos;i="5.75,417,1589266800"; d="scan'208";a="131295473" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2020 21:09:10 -0700 IronPort-SDR: qJJ3DqZWpMHVdJe7JP52LJtQEmuuZPBgtjR7FFgWyFYOxhD0lhMMkZIYy+Us+gCc37kpk2zy/N wobqAU09crbA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,417,1589266800"; d="scan'208";a="465500784" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga005.jf.intel.com with ESMTP; 30 Jul 2020 21:09:09 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 30 Jul 2020 21:09:09 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 30 Jul 2020 21:09:09 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.22]) by shsmsx102.ccr.corp.intel.com ([169.254.2.43]) with mapi id 14.03.0439.000; Fri, 31 Jul 2020 12:09:04 +0800 From: "Sun, GuinanX" To: "Xing, Beilei" , "Wang, ShougangX" , "Guo, Jia" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] net/i40e: fix link status Thread-Index: AQHWZl0a8Thki3ldTEqmYGo+DwC/qakgcgqAgAACRQCAABQygIAAixcQ Date: Fri, 31 Jul 2020 04:09:04 +0000 Message-ID: <05758BDAD7FC8E4BAED63D0390A8A95587FFF5@SHSMSX101.ccr.corp.intel.com> References: <20200730082539.24104-1-guinanx.sun@intel.com> <20200730102527.49884-1-guinanx.sun@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix link status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Beilei > -----Original Message----- > From: Xing, Beilei > Sent: Friday, July 31, 2020 11:50 AM > To: Wang, ShougangX ; Sun, GuinanX > ; Guo, Jia ; dev@dpdk.org > Cc: Sun, GuinanX ; stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] net/i40e: fix link status >=20 >=20 >=20 > > -----Original Message----- > > From: Wang, ShougangX > > Sent: Friday, July 31, 2020 10:38 AM > > To: Xing, Beilei ; Sun, GuinanX > > ; Guo, Jia ; dev@dpdk.org > > Cc: Sun, GuinanX ; stable@dpdk.org > > Subject: RE: [dpdk-dev] [PATCH v2] net/i40e: fix link status > > > > Hi Beilei > > > > > -----Original Message----- > > > From: dev On Behalf Of Xing, Beilei > > > Sent: Friday, July 31, 2020 10:30 AM > > > To: Sun, GuinanX ; Guo, Jia > > > ; dev@dpdk.org > > > Cc: Sun, GuinanX ; stable@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix link status > > > > > > > > > > > > > -----Original Message----- > > > > From: dev On Behalf Of Guinan Sun > > > > Sent: Thursday, July 30, 2020 6:25 PM > > > > To: Xing, Beilei ; Guo, Jia > > > > ; dev@dpdk.org > > > > Cc: Sun, GuinanX ; stable@dpdk.org > > > > Subject: [dpdk-dev] [PATCH v2] net/i40e: fix link status > > > > > > > > If the PF driver supports the new speed reporting capabilities > > > > then use link_event_adv instead of link_event to get the speed. > > > > > > > > Fixes: 2a73125b7041 ("i40evf: fix link info update") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Guinan Sun > > > > --- > > > > v2: > > > > * Modify commit log. > > > > * Add code comments. > > > > * Delete useless codes. > > > > --- > > > > drivers/net/i40e/base/virtchnl.h | 16 +++++++++++- > > > > drivers/net/i40e/i40e_ethdev_vf.c | 42 > > > +++++++++++++++++++++++++++++-- > > > > 2 files changed, 55 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/drivers/net/i40e/base/virtchnl.h > > > > b/drivers/net/i40e/base/virtchnl.h > > > > index 4f498ca45..9c64fd469 100644 > > > > --- a/drivers/net/i40e/base/virtchnl.h > > > > +++ b/drivers/net/i40e/base/virtchnl.h > > > > @@ -240,7 +240,8 @@ VIRTCHNL_CHECK_STRUCT_LEN(16, > > > > virtchnl_vsi_resource); #define > > > > VIRTCHNL_VF_OFFLOAD_ENCAP0X00100000 > > > > #define VIRTCHNL_VF_OFFLOAD_ENCAP_CSUM0X00200000 > > > > #define VIRTCHNL_VF_OFFLOAD_RX_ENCAP_CSUM0X00400000 > > > > - > > > > +/* Define below the capability flags that are not offloads */ > > > > +#define VIRTCHNL_VF_CAP_ADV_LINK_SPEED0x00000080 > > > > > > You defined the new capability VIRTCHNL_VF_CAP_ADV_LINK_SPEED in the > > > patch, but didn't request the capability for i40evf? > > > > This capability is given by i40e kernel pf if > > VIRTCHNL_VF_CAP_ADV_LINK_SPEED is defined. So vf doesn't need to > > request it. >=20 > All the capabilities for VF is required by VF, please check > i40evf_get_vf_resource. I will double check for it. New Patch will fix it. Thank you. >=20 > > > > Thanks. > > Shougang