From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69219A0C53; Wed, 1 Sep 2021 09:04:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E174E4013F; Wed, 1 Sep 2021 09:04:41 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 6C09940041 for ; Wed, 1 Sep 2021 09:04:40 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 05F827F523; Wed, 1 Sep 2021 10:04:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 05F827F523 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1630479880; bh=d0Kcz3JkuwmtqoxZRVYMgDM8O7sil7aAoGarGBQs9Qg=; h=Subject:To:References:From:Date:In-Reply-To; b=VVH8+PsxxCjlcL2ZjqEeO+EErZz1nujXTVICGi1T7oqgdT0DgC0q0+PTan6Oq/WNo bXs7e09sm4rDtyti+0Ocw7uur4rQWHYmWfjPHcPIlGISUnsM9USYEox+X/P1H/D/ak 4gQqPPGFFz48JminPAKM7xfncxrBlt/HoJQKtAWE= To: Stephen Hemminger , dev@dpdk.org References: <20210831200839.93556-1-stephen@networkplumber.org> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <057efbd9-f3ec-b4c7-5add-fdf7baeebbee@oktetlabs.ru> Date: Wed, 1 Sep 2021 10:04:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210831200839.93556-1-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal: make rte_lcore_cpuset and rte_lcore_to_cpu_id stable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/31/21 11:08 PM, Stephen Hemminger wrote: > These were converted from inline to functions in 19.11 > and should be marked as stable now. > > Signed-off-by: Stephen Hemminger > --- > lib/eal/include/rte_lcore.h | 8 -------- > lib/eal/version.map | 4 ++-- > 2 files changed, 2 insertions(+), 10 deletions(-) > > diff --git a/lib/eal/include/rte_lcore.h b/lib/eal/include/rte_lcore.h > index 1550b75da0a5..cf6203a9af79 100644 > --- a/lib/eal/include/rte_lcore.h > +++ b/lib/eal/include/rte_lcore.h > @@ -172,9 +172,6 @@ unsigned int > rte_lcore_to_socket_id(unsigned int lcore_id); > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change without prior notice. > - * > * Return the id of the lcore on a socket starting from zero. > * > * @param lcore_id > @@ -182,23 +179,18 @@ rte_lcore_to_socket_id(unsigned int lcore_id); > * @return > * The relative index, or -1 if not enabled. > */ > -__rte_experimental > int > rte_lcore_to_cpu_id(int lcore_id); > > #ifdef RTE_HAS_CPUSET > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change without prior notice. > - * > * Return the cpuset for a given lcore. > * @param lcore_id > * the targeted lcore, which MUST be between 0 and RTE_MAX_LCORE-1. > * @return > * The cpuset of that lcore > */ > -__rte_experimental > rte_cpuset_t > rte_lcore_cpuset(unsigned int lcore_id); I'm wondering why negative lcore_id is supported above with special meaning, but not supported here. > > diff --git a/lib/eal/version.map b/lib/eal/version.map > index beeb986adcaf..14565aa10df4 100644 > --- a/lib/eal/version.map > +++ b/lib/eal/version.map > @@ -98,9 +98,11 @@ DPDK_22 { > rte_keepalive_register_core; # WINDOWS_NO_EXPORT > rte_keepalive_register_relay_callback; # WINDOWS_NO_EXPORT > rte_lcore_count; > + rte_lcore_cpuset; > rte_lcore_has_role; > rte_lcore_index; > rte_lcore_is_enabled; > + rte_lcore_to_cpu_id; > rte_lcore_to_socket_id; > rte_log; > rte_log_cur_msg_loglevel; > @@ -322,8 +324,6 @@ EXPERIMENTAL { > > # added in 19.08 > rte_intr_ack; > - rte_lcore_cpuset; > - rte_lcore_to_cpu_id; > rte_mcfg_timer_lock; > rte_mcfg_timer_unlock; > rte_rand_max; # WINDOWS_NO_EXPORT >