DPDK patches and discussions
 help / color / mirror / Atom feed
From: Pavel Fedin <p.fedin@samsung.com>
To: 'Jianfeng Tan' <jianfeng.tan@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] pmd/virtio: fix cannot start virtio dev after stop
Date: Mon, 11 Jan 2016 18:03:20 +0300	[thread overview]
Message-ID: <058b01d14c81$362854c0$a278fe40$@samsung.com> (raw)
In-Reply-To: <1452492973-123936-1-git-send-email-jianfeng.tan@intel.com>

 Tested-by: Pavel Fedin <p.fedin@samsung.com>

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia


> -----Original Message-----
> From: Jianfeng Tan [mailto:jianfeng.tan@intel.com]
> Sent: Monday, January 11, 2016 9:16 AM
> To: dev@dpdk.org
> Cc: p.fedin@samsung.com; yuanhan.liu@linux.intel.com; Jianfeng Tan
> Subject: [PATCH v2] pmd/virtio: fix cannot start virtio dev after stop
> 
> v2 changes:
>     - Address compiling error.
>     - Add Reported-by.
> 
> Fix the issue that virtio device cannot be started after stopped.
> 
> The field, hw->started, should be changed by virtio_dev_start/stop instead
> of virtio_dev_close.
> 
> Reported-by: Pavel Fedin <p.fedin@samsung.com>
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> 
> ---
>  drivers/net/virtio/virtio_ethdev.c | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> index d928339..5bdd305 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -490,11 +490,13 @@ virtio_dev_close(struct rte_eth_dev *dev)
> 
>  	PMD_INIT_LOG(DEBUG, "virtio_dev_close");
> 
> +	if (hw->started == 1)
> +		virtio_dev_stop(dev);
> +
>  	/* reset the NIC */
>  	if (pci_dev->driver->drv_flags & RTE_PCI_DRV_INTR_LSC)
>  		vtpci_irq_config(hw, VIRTIO_MSI_NO_VECTOR);
>  	vtpci_reset(hw);
> -	hw->started = 0;
>  	virtio_dev_free_mbufs(dev);
>  	virtio_free_queues(dev);
>  }
> @@ -1408,10 +1410,9 @@ eth_virtio_dev_uninit(struct rte_eth_dev *eth_dev)
>  	if (rte_eal_process_type() == RTE_PROC_SECONDARY)
>  		return -EPERM;
> 
> -	if (hw->started == 1) {
> -		virtio_dev_stop(eth_dev);
> -		virtio_dev_close(eth_dev);
> -	}
> +	/* Close it anyway since there's no way to know if closed */
> +	virtio_dev_close(eth_dev);
> +
>  	pci_dev = eth_dev->pci_dev;
> 
>  	eth_dev->dev_ops = NULL;
> @@ -1612,9 +1613,12 @@ static void
>  virtio_dev_stop(struct rte_eth_dev *dev)
>  {
>  	struct rte_eth_link link;
> +	struct virtio_hw *hw = dev->data->dev_private;
> 
>  	PMD_INIT_LOG(DEBUG, "stop");
> 
> +	hw->started = 0;
> +
>  	if (dev->data->dev_conf.intr_conf.lsc)
>  		rte_intr_disable(&dev->pci_dev->intr_handle);
> 
> --
> 2.1.4

  reply	other threads:[~2016-01-11 15:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-05  1:07 [dpdk-dev] [PATCH] " Jianfeng Tan
2016-01-07  2:50 ` Yuanhan Liu
2016-01-11  6:16 ` [dpdk-dev] [PATCH v2] " Jianfeng Tan
2016-01-11 15:03   ` Pavel Fedin [this message]
2016-01-11 10:47 ` [dpdk-dev] [PATCH] " Pavel Fedin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='058b01d14c81$362854c0$a278fe40$@samsung.com' \
    --to=p.fedin@samsung.com \
    --cc=dev@dpdk.org \
    --cc=jianfeng.tan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).