From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout3.w1.samsung.com (mailout3.w1.samsung.com [210.118.77.13]) by dpdk.org (Postfix) with ESMTP id 0125A5A26 for ; Mon, 11 Jan 2016 16:03:22 +0100 (CET) Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O0S001S2N5LW550@mailout3.w1.samsung.com> for dev@dpdk.org; Mon, 11 Jan 2016 15:03:21 +0000 (GMT) X-AuditID: cbfec7f5-f79b16d000005389-fe-5693c439b13a Received: from eusync2.samsung.com ( [203.254.199.212]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id 68.72.21385.934C3965; Mon, 11 Jan 2016 15:03:21 +0000 (GMT) Received: from fedinw7x64 ([106.109.131.169]) by eusync2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0O0S003D6N5KDA00@eusync2.samsung.com>; Mon, 11 Jan 2016 15:03:21 +0000 (GMT) From: Pavel Fedin To: 'Jianfeng Tan' , dev@dpdk.org References: <1451956062-45932-1-git-send-email-jianfeng.tan@intel.com> <1452492973-123936-1-git-send-email-jianfeng.tan@intel.com> In-reply-to: <1452492973-123936-1-git-send-email-jianfeng.tan@intel.com> Date: Mon, 11 Jan 2016 18:03:20 +0300 Message-id: <058b01d14c81$362854c0$a278fe40$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQDlwXz9dMi3ZzNgDudYNg1I3lsEGgHwhHGyoL37OiA= Content-language: ru X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrILMWRmVeSWpSXmKPExsVy+t/xK7qWRyaHGZyaJWPx7tN2Jovu2V/Y LK5PuMDqwOzxa8FSVo/Fe14yecw7GRjAHMVlk5Kak1mWWqRvl8CVMacnv+CZUMXN5nbWBsZl /F2MnBwSAiYS56d3s0DYYhIX7q1nA7GFBJYySvz9V9LFyAVkf2eUWP33NytIgk1AXeL01w9g DSIClhKf3vxjBrGZBeQlvs9/xgLR0MIo8erzIbBJnAIeEk/uXgdrFhbwktgzfR8TiM0ioCrR c+ge2CBeoEHNj9ewQdiCEj8mQ8SZBbQkNm9rYoVZsHnNW2aISxUkdpx9zQhxhJXE1bvdUPUi EtP+3WOewCg0C8moWUhGzUIyahaSlgWMLKsYRVNLkwuKk9JzjfSKE3OLS/PS9ZLzczcxQgL+ 6w7GpcesDjEKcDAq8fDO2DUpTIg1say4MvcQowQHs5IIr9r2yWFCvCmJlVWpRfnxRaU5qcWH GKU5WJTEeWfueh8iJJCeWJKanZpakFoEk2Xi4JRqYJy8Zvt+WYfv3J+O8/FHBbDvahStLJ77 5GzpRfGJDWLSZ7o5y1gP6xy8+uDhZ6E/V9d9PqZ11nJBgKi3vtw59Z3frhw9ckSCs65m9c1N a1Jka5XL5ztXus6UVtx+/vfNuzdkXpsrKqybIPHEwmV3q7Gw4fKb6yY7abl6eqd+NLn9dq+Z 3OLCC5+VWIozEg21mIuKEwH3g2LcdAIAAA== Subject: Re: [dpdk-dev] [PATCH v2] pmd/virtio: fix cannot start virtio dev after stop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jan 2016 15:03:23 -0000 Tested-by: Pavel Fedin Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia > -----Original Message----- > From: Jianfeng Tan [mailto:jianfeng.tan@intel.com] > Sent: Monday, January 11, 2016 9:16 AM > To: dev@dpdk.org > Cc: p.fedin@samsung.com; yuanhan.liu@linux.intel.com; Jianfeng Tan > Subject: [PATCH v2] pmd/virtio: fix cannot start virtio dev after stop > > v2 changes: > - Address compiling error. > - Add Reported-by. > > Fix the issue that virtio device cannot be started after stopped. > > The field, hw->started, should be changed by virtio_dev_start/stop instead > of virtio_dev_close. > > Reported-by: Pavel Fedin > Signed-off-by: Jianfeng Tan > Acked-by: Yuanhan Liu > > --- > drivers/net/virtio/virtio_ethdev.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index d928339..5bdd305 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -490,11 +490,13 @@ virtio_dev_close(struct rte_eth_dev *dev) > > PMD_INIT_LOG(DEBUG, "virtio_dev_close"); > > + if (hw->started == 1) > + virtio_dev_stop(dev); > + > /* reset the NIC */ > if (pci_dev->driver->drv_flags & RTE_PCI_DRV_INTR_LSC) > vtpci_irq_config(hw, VIRTIO_MSI_NO_VECTOR); > vtpci_reset(hw); > - hw->started = 0; > virtio_dev_free_mbufs(dev); > virtio_free_queues(dev); > } > @@ -1408,10 +1410,9 @@ eth_virtio_dev_uninit(struct rte_eth_dev *eth_dev) > if (rte_eal_process_type() == RTE_PROC_SECONDARY) > return -EPERM; > > - if (hw->started == 1) { > - virtio_dev_stop(eth_dev); > - virtio_dev_close(eth_dev); > - } > + /* Close it anyway since there's no way to know if closed */ > + virtio_dev_close(eth_dev); > + > pci_dev = eth_dev->pci_dev; > > eth_dev->dev_ops = NULL; > @@ -1612,9 +1613,12 @@ static void > virtio_dev_stop(struct rte_eth_dev *dev) > { > struct rte_eth_link link; > + struct virtio_hw *hw = dev->data->dev_private; > > PMD_INIT_LOG(DEBUG, "stop"); > > + hw->started = 0; > + > if (dev->data->dev_conf.intr_conf.lsc) > rte_intr_disable(&dev->pci_dev->intr_handle); > > -- > 2.1.4