From: "Wiles, Roger Keith" <keith.wiles@windriver.com>
To: "<dev@dpdk.org>" <dev@dpdk.org>
Subject: [dpdk-dev] [PATCH v2] rte_mempool_dump() crashes with NULL rte_mempool pointer.
Date: Sun, 28 Sep 2014 05:28:44 +0000 [thread overview]
Message-ID: <05E7C1C5-2730-4BE3-B808-6F69821F7898@windriver.com> (raw)
In-Reply-To: <DAE811FA-C1F1-444D-980C-311BCCE7FF3C@windriver.com>
Check the FILE *f and rte_mempool *mp pointers for NULL and
return plus print out a message if RTE_LIBRTE_MEMPOOL_DEBUG is enabled.
Signed-off-by: Keith Wiles <keith.wiles@windriver.com>
---
lib/librte_mempool/rte_mempool.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c
index 332f469..0f71f10 100644
--- a/lib/librte_mempool/rte_mempool.c
+++ b/lib/librte_mempool/rte_mempool.c
@@ -765,6 +765,9 @@ rte_mempool_dump(FILE *f, const struct rte_mempool *mp)
unsigned common_count;
unsigned cache_count;
+ RTE_VERIFY(f != NULL);
+ RTE_VERIFY(mp != NULL);
+
fprintf(f, "mempool <%s>@%p\n", mp->name, mp);
fprintf(f, " flags=%x\n", mp->flags);
fprintf(f, " ring=<%s>@%p\n", mp->ring->name, mp->ring);
--
2.1.0
Keith Wiles, Principal Technologist with CTO office, Wind River mobile 972-213-5533
next prev parent reply other threads:[~2014-09-28 5:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-27 18:35 [dpdk-dev] [PATCH] " Wiles, Roger Keith
2014-09-28 0:37 ` Neil Horman
2014-09-28 1:10 ` Wiles, Roger Keith
2014-09-28 1:14 ` Wiles, Roger Keith
2014-09-28 1:55 ` Neil Horman
2014-09-28 5:38 ` Wiles, Roger Keith
2014-09-28 12:25 ` Neil Horman
2014-09-28 5:28 ` Wiles, Roger Keith [this message]
2014-09-28 12:27 ` [dpdk-dev] [PATCH v2] " Neil Horman
2014-09-28 14:37 ` Wiles, Roger Keith
2014-10-01 13:36 ` Thomas Monjalon
2014-10-01 15:02 ` Neil Horman
2014-10-01 15:43 ` Bruce Richardson
2014-10-01 15:57 ` Wiles, Roger Keith
2014-10-01 16:01 ` Neil Horman
2014-10-01 16:05 ` Bruce Richardson
2014-10-02 7:47 ` Thomas Monjalon
2014-10-02 11:37 ` Neil Horman
2014-11-27 16:32 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05E7C1C5-2730-4BE3-B808-6F69821F7898@windriver.com \
--to=keith.wiles@windriver.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).