From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by dpdk.org (Postfix) with ESMTP id 7749C1F7 for ; Sun, 28 Sep 2014 07:22:16 +0200 (CEST) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.14.9/8.14.5) with ESMTP id s8S5Sjaw007291 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL) for ; Sat, 27 Sep 2014 22:28:45 -0700 (PDT) Received: from ALA-MBB.corp.ad.wrs.com ([169.254.1.18]) by ALA-HCA.corp.ad.wrs.com ([147.11.189.40]) with mapi id 14.03.0174.001; Sat, 27 Sep 2014 22:28:45 -0700 From: "Wiles, Roger Keith" To: "" Thread-Topic: [dpdk-dev] [PATCH v2] rte_mempool_dump() crashes with NULL rte_mempool pointer. Thread-Index: AQHP2t0S8e1ctlbauEatlaiZR/WDLw== Date: Sun, 28 Sep 2014 05:28:44 +0000 Message-ID: <05E7C1C5-2730-4BE3-B808-6F69821F7898@windriver.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.25.40.166] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2] rte_mempool_dump() crashes with NULL rte_mempool pointer. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Sep 2014 05:22:17 -0000 Check the FILE *f and rte_mempool *mp pointers for NULL and return plus print out a message if RTE_LIBRTE_MEMPOOL_DEBUG is enabled. Signed-off-by: Keith Wiles --- lib/librte_mempool/rte_mempool.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_memp= ool.c index 332f469..0f71f10 100644 --- a/lib/librte_mempool/rte_mempool.c +++ b/lib/librte_mempool/rte_mempool.c @@ -765,6 +765,9 @@ rte_mempool_dump(FILE *f, const struct rte_mempool *mp) unsigned common_count; unsigned cache_count; + RTE_VERIFY(f !=3D NULL); + RTE_VERIFY(mp !=3D NULL); + fprintf(f, "mempool <%s>@%p\n", mp->name, mp); fprintf(f, " flags=3D%x\n", mp->flags); fprintf(f, " ring=3D<%s>@%p\n", mp->ring->name, mp->ring); --=20 2.1.0 Keith Wiles, Principal Technologist with CTO office, Wind River mobile 972-= 213-5533