DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
To: Nicholas Pratte <npratte@iol.unh.edu>,
	dmarx@iol.unh.edu, luca.vizzarro@arm.com,
	Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com,
	probb@iol.unh.edu, jspewock@iol.unh.edu,
	yoan.picchi@foss.arm.com
Cc: dev@dpdk.org
Subject: Re: [PATCH v2] dts: Testbed And Node Configuration Split
Date: Tue, 10 Sep 2024 11:19:05 +0200	[thread overview]
Message-ID: <05a03b0a-5e1e-4e93-a187-b34ba12cca04@pantheon.tech> (raw)
In-Reply-To: <20240703145749.23416-2-npratte@iol.unh.edu>

>   create mode 100644 dts/execution_conf.yaml

As Jeremy mentioned, this is a duplicate. I guess this patch needs to be 
rebased as it mentions executions all over the place.

>   create mode 100644 dts/node_conf.yaml
>   create mode 100644 dts/testbed_conf.yaml

And this should be named test_run_conf.yaml or testrun_conf.yaml (it's 
not just testbed conf, but also other things used in test runs). Or 
maybe we can come up with an abbreviation or initialism for test run.

> diff --git a/dts/framework/config/__init__.py b/dts/framework/config/__init__.py
> index df60a5030e..2322f3d996 100644
> --- a/dts/framework/config/__init__.py
> +++ b/dts/framework/config/__init__.py
> @@ -573,29 +573,39 @@ def from_dict(cls, d: ConfigurationDict) -> Self:
>           return cls(test_runs=test_runs)
>   
>   
> -def load_config(config_file_path: Path) -> Configuration:
> +def load_config(node_config_file_path: Path, exec_config_file_path: Path) -> Configuration:
>       """Load DTS test run configuration from a file.
>   
> -    Load the YAML test run configuration file
> +    Load both the YAML testbed and execution configuration files
>       and :download:`the configuration file schema <conf_yaml_schema.json>`,
> -    validate the test run configuration file, and create a test run configuration object.
> +    validate both configuration files to create a test run configuration object.

Now that you're removed the last "and" the sentence feels like it's 
missing something. If we add then to "then validate both" then it sounds 
fine.


> diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/config/conf_yaml_schema.json
> index f02a310bb5..1962ed05dd 100644
> --- a/dts/framework/config/conf_yaml_schema.json
> +++ b/dts/framework/config/conf_yaml_schema.json
> @@ -211,192 +211,192 @@

> +  "oneOf": [

Again, as mentioned in the other comment, splitting the schema would 
make more sense. We'd probably have to make some doc modifications (in 
guides/tools/dts.rtst)




  parent reply	other threads:[~2024-09-10  9:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-10 19:34 [PATCH v1] " Nicholas Pratte
2024-06-10 19:37 ` Nicholas Pratte
2024-06-14 18:32   ` Jeremy Spewock
2024-09-10  8:57     ` Juraj Linkeš
2024-06-14 18:27 ` Jeremy Spewock
2024-09-10  9:00   ` Juraj Linkeš
2024-07-03 14:57 ` [PATCH v2] " Nicholas Pratte
2024-07-16 14:11   ` Jeremy Spewock
2024-09-10  9:19   ` Juraj Linkeš [this message]
2024-11-18 17:25   ` Luca Vizzarro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05a03b0a-5e1e-4e93-a187-b34ba12cca04@pantheon.tech \
    --to=juraj.linkes@pantheon.tech \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=dev@dpdk.org \
    --cc=dmarx@iol.unh.edu \
    --cc=jspewock@iol.unh.edu \
    --cc=luca.vizzarro@arm.com \
    --cc=npratte@iol.unh.edu \
    --cc=paul.szczepanek@arm.com \
    --cc=probb@iol.unh.edu \
    --cc=yoan.picchi@foss.arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).