From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 12D6CA00C5; Tue, 15 Feb 2022 11:06:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B383C410F3; Tue, 15 Feb 2022 11:06:30 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 117FD40E78 for ; Tue, 15 Feb 2022 11:06:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644919589; x=1676455589; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=UkJtVBcXgoCaTPhnVrdk3T4RTa/sZz4nBeNssVgyHzw=; b=JPtV/IoO+Zynh7D5AetMMCuC7ZIpxNxEYYT0OSGVENRiwu5Ml2v9EnRM xuO/X1GW/m9vKtQa4/xPvf0+WN1OicLkspML5Ngupc9ZdtLql4ReyUApz SxZgseSy8H58Fn+WqYRh7vU8xEWdEEl1wU7Jk/SaL/ZbKCHFPloGCQDz+ 8DCvD71x6kQ5PksrY1J62RJiN2f22IaBSKw8u0Nr4twtkg3JNGMxJe0Qu M3X5w2ej/Wo7pN9oqm8CQ4Lc3mxuRCBVq7f6b9J+vu8SskiN5C5nF0biA PZ2M5MpcI4qKvYLe+keKVE4bWwzP5/izHbui4lsDOESQR4+QF1loCdjmN g==; X-IronPort-AV: E=McAfee;i="6200,9189,10258"; a="233858763" X-IronPort-AV: E=Sophos;i="5.88,370,1635231600"; d="scan'208";a="233858763" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2022 02:06:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,370,1635231600"; d="scan'208";a="496985952" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga006.jf.intel.com with ESMTP; 15 Feb 2022 02:06:27 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 15 Feb 2022 02:06:27 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 15 Feb 2022 02:06:27 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 15 Feb 2022 02:06:27 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.170) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 15 Feb 2022 02:06:26 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dAXfzSRKPwy3YGaMesTFgtabozWnB166pPd/UxE1Hn/tUvxvv7WgmCvmZt4okbW/ssnbIkmX9K8SKoFyLwkKshYzn2PnKdoRrIzFnfq+WNcYEdSdvwGdhCw1ecUXMYh/C8SeeJv5rc8nojPBrcfD4m6Og0274ZB4pUOZexQlV/oGp6SzCnJM9/dmI7vXsveVMXNw9HLf9n1VogNTpViGPp5x3Vlf9DmPQP5WX4jHRSIGuHkafSjFR8K5RqBDIIj/zRVeUtx3yW+c59WIetWNDjyGnUtX10gGtos91KIlJCNp6Dpis6Zei7x/DFkTani3Nu6IO8tiIFYRAFojjbRV0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n6VF4GVfOHlxgfGM63WBssaNc5PnCAnI1TAtcZUAsCM=; b=ZH19HYFuzQMQ1JNm7GEBLYL0NPHFk9OGfQamgvSLXJfZFgnf1AFCSFJw/H7GECvMsmo1+MSfmLc3ke04W0QuFzxP2vlRg9uJrUHq5Cz9oyA318+ubOl3sW9kQx+hQp+jGj0ayesTKpyDjdkuJKTKiYwTnk/zB0CzbR9MjGvVoBdn+cRH0PFTqb0mQRM4XXJ0WtWl6dH/Ctn6FqP4o2RF5PPtO60HabK32gUWZ9H7Q44Y2HrauCpF4UPlsvzWhLs6U/NTuH1MLedjzLyEKfFU72dT4egxVJ2HYaK2/4DeYMhj89jyUFHGdTPgcJ8Do5XeTXGgIfVeKw5E1C+QYMFuKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by DM5PR1101MB2234.namprd11.prod.outlook.com (2603:10b6:4:5a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.17; Tue, 15 Feb 2022 10:06:25 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022 10:06:25 +0000 Message-ID: <05a27976-6664-190c-38b7-9b63c7294973@intel.com> Date: Tue, 15 Feb 2022 10:06:19 +0000 Content-Language: en-US To: Radu Nicolau , Jingjing Wu , Beilei Xing CC: , , Kevin Traynor , Luca Boccassi References: <20220210130923.1442905-1-radu.nicolau@intel.com> From: Ferruh Yigit Subject: Re: [PATCH] net/iavf: fix segmentation offload buffer size X-User: ferruhy In-Reply-To: <20220210130923.1442905-1-radu.nicolau@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0007.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:150::12) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 42180f0f-d474-4f7b-4f81-08d9f06ad323 X-MS-TrafficTypeDiagnostic: DM5PR1101MB2234:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:519; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NlIm/3omVG7bKJVJ+D/TJ+gdobmFs6kyV+mCQOpa/U39Axa7nCqxqpZ/ZX6BK7WNVc5WRC2H5LGtwxe/XgEbdNiRjWinqD5MiyEHF9myNPAySaIbxdvSuGhpIvROwAAhoBfJIqzBPtQX4SXzB4fvojpMpuxpXR0ulyiK9x16Q0rXF4t/9xaU4umprt3wEwGrgJe1LdaeSgnffNPRrZEtlQeLRs1QJwmJMt8u1CUM5Zykgap/6W5p1Dvi4fZDuG1zkDve+ks46Sb9Xz5KK1Qd+FHHvNpXIkTZaX+5Pjq9O+31xSCOE+OT0yVPYmYwN92f46tCWV5ralEA7qNQMRDBQP9JQ6tE8SOORwC5bcsaqE9EAWb3+yBvnmIO0DnNV9uwM8e7J+BMw0JeKg4h1KNCL8yaUPzC8ESzhHb8Yhp9+hNUqFWwkbre+xP95FeEtKL+BZoGpzdFTUK6DKzr9KKHx3j8B07YJ9GtBcGSAwWNe5uyqNichYGB/8UI27HzXylS+2YZN6Lab98PiQnFPPHGrnvETuoZ93jND3jUw+NoRa8/s4AN0zD1IsjsPMPo1+SgD11c2pZh76mn9GPeE7qUUQ1J6x0FGjMdGGhkIP0HJJETEGiXdO1MxGpZlH0mt2AJjkKcUpsg/4hRtJMe/S9ME3F/LLu7jYVhUsvWPPM3h80QRKNIoa3u45kDV/bnZtlxf7MSzd2CfslYOiEvnWul4w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(8676002)(31696002)(6512007)(2906002)(86362001)(6506007)(53546011)(8936002)(44832011)(5660300002)(6666004)(83380400001)(54906003)(110136005)(508600001)(6636002)(26005)(82960400001)(66556008)(66476007)(31686004)(6486002)(4326008)(36756003)(316002)(66946007)(38100700002)(186003)(2616005)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d3ZsaytKTDZVTk1qdTFzSXZ1SDhuL3djdStMaTVybmZ6NUE5RlZtZHJRem9F?= =?utf-8?B?Z09sL1Jra2ZQU0lhZWIwL3VUSml3VERVZTNqNFVZS045ckxUOG9JQkIwcVBR?= =?utf-8?B?L2huOGxNL2JnOEFPTytTQVd4anZSN0VyOGx0Z2lNUlRuamlkY3pCVmREKzVT?= =?utf-8?B?T2FXcGF6d1FtR05PRksraTlmR3QzdWwyKzZNcHFVMDNQV0dackdnOEVieEdY?= =?utf-8?B?Y0Zma09WWWdwNzB5OEpOc1ZCUk5SRkovL0VPRG4zamJ0MncrMkF2aVZNWGhs?= =?utf-8?B?alJ5SUw2V2VLaStZNThTQzY1amdlekk3RFNsbGpKVndLSkl3Q28vMFg1TzlW?= =?utf-8?B?OE1ESms0QTFWbWZianZBOCs4S0FDVEFHMmg4d3pmRnAySXlHSWhweGhwMUQv?= =?utf-8?B?VVFRT0JuWjdQcnVHT1hJU3d0dVk2bWF2N3AvaGVoN0dVOFRoNkFhRjVEZzFN?= =?utf-8?B?NzFVWDVwMnV3K05FWHV5OTdpaEV2QTlaRDBja0dKWGpjRHRmbUtreXlPdGJr?= =?utf-8?B?NXVsclI1WFVPODRTdmdLTjl1NS9ZTUUzZVhSK0lITzB3OEh6cWRIYktrNk9t?= =?utf-8?B?djhOeGc4bkpqYVA0RzRFVUVBWkJpS3ZuK3ZoS0hGMTgySTZqVWxjNWFPMTRH?= =?utf-8?B?cm1YUjlhYVJRN00vdWZkczZYd0pSZzY3bHNRU25CbU9ac2ZPTE0wWmJGL095?= =?utf-8?B?UWxMUkgwWDlhamQ4dC9nU3dmeWdtK3UrZUVZekg2dkMzNFNFVzBLdENjaEpy?= =?utf-8?B?RHlCeFgzSU1uMGhtRCs0UzlXWWdqdllkSUdEVFpsMVVaQjJVZlFQR0RCRFZ2?= =?utf-8?B?OWVvSWIvblR4Y2tXRXlQL2FudHZpVVRJWG93ajhSb0owR3Z6ekR2TXloVUF5?= =?utf-8?B?V1A2cUVxRThndHI3WTFKazFTdHp0OXpJL0dtKzZtV1ZTQ3JJQTcxMmh5bko2?= =?utf-8?B?bkRBQXNTemYyeVY2WUZvYVVta1F6ek9TSFArWWlsUm1jeXFPR0RKaVVYVVRG?= =?utf-8?B?YmUvbmJ0NitoYkZOS0U0YWk0dEI4S2s4dFhxRkJwa25DcTN5OG1FS05mSjFy?= =?utf-8?B?M1pqcm52UmRmdUVaZ20rZXM5Y3dEc0JoZnF3NVQ2MWc4eEpMb2JkMFlaRzNX?= =?utf-8?B?elJwc1VMd2lOOGxYODVLY00xYnFBK0VoUnR5VjBoSTkzbHR0Zm9mOWh1cTJM?= =?utf-8?B?NjdCeDhlWHhjR3RJTU9LMk1UOGdFeW5HbnZwaWd0R0FidnpiU1ZHWTlqOHVO?= =?utf-8?B?SzZFZU5taTA2bVRZK3VKOTJEcm9EMnBmazdqaUlWNWRuTUQvSXRIUU5ZcVd6?= =?utf-8?B?aS9LSXpWTXNheHNUVVZ2RU1oR0ppd1hHQkx0UGJJQkk3bDlqd2xFcVFtLzQx?= =?utf-8?B?RDM4T1dYRnE3ZDNUbWo4Rk1hb29pVzF6V01LR1V2cDVwbHJVWWdxUTRmTWJO?= =?utf-8?B?WDFvNlB0aCthTlB0azRsVUVYNmZqbWRJalJieTcwV3NRdWRLVDJ4WmUvN01L?= =?utf-8?B?OVhKNjZINkZ6L1laYWtCdTBsd1h2UnAySVE4TXhVM3RIUkpmeDJkd2c2M29x?= =?utf-8?B?dm4wZ2tOY1BTT29HSFVvYTZqd2ZDcDEyT3JJTnhXcHd2L2pPYUpVWUVjMmph?= =?utf-8?B?Y0tOQ05LcGJuazJaNEt2THY5SXBRZjU2VlVUcU1JWWdoVERjdlhoWXpINWVG?= =?utf-8?B?RkVJRnJHNWxxNDM2VDVRYW15Wm44bDdrT0xqUGJoM1VPZU1oQW14V2VXcTE3?= =?utf-8?B?YWFTK2x4Z21NWFcyeExINjBIMlpFWVBUc3JvV3MrZWdvYTJ1Y0RZRjJtL2pk?= =?utf-8?B?Q2t3YTdtSFZHbnhWcHRyemVDZFlNNDR5Mm00bHFuS20xWHoxeXp4UzZsemMw?= =?utf-8?B?cE5VYkExSU5acmhReVp2MHdSUVdwV3g1UTI5SUVEOXc3MlJPK29VWWhYaGxS?= =?utf-8?B?anBnd3k4S1JFeUpFNHVnZjQ0azhwazZFZ09EbzBqNERuZGZrVnY1SGhNb2cv?= =?utf-8?B?V3dublNYVWZKODVpWUN4R0JtK0IyeHVRMWYwT2ZhN3Y0dVdoNzNpNTc4Z1gx?= =?utf-8?B?aTJkUGhGNnNzRVBHSFh3VmRvZEIwa0pKbVY4ODNYQzhQeUdBaUp5Y1QyallV?= =?utf-8?B?alpkSW5wWkRwSjRVNVhMdm5zYk5qajlnSjJIcS95QTZTWllLQmd4UUp3M2RD?= =?utf-8?Q?J8LzEhV0si9a2k0CkInuTs8=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 42180f0f-d474-4f7b-4f81-08d9f06ad323 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 10:06:25.1797 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UFGgij8tTFGn8huMIDuzau7rXdZBmgVYmrdESBhZUALcPNWSJOgOVVtXPn/g+QYW3du5CEF4H5JKbK+KCVUCOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2234 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/10/2022 1:09 PM, Radu Nicolau wrote: > This reverts commit ff8b8bcd2ebe, which resulted in incorrect buffer size > being computed for TSO packets. > > Fixes: ff8b8bcd2ebe ("net/iavf: fix segmentation offload condition") > Commit 'ff8b8bcd2ebe' was already fixing segmentation offload, are we having the initial issue back when this patch reverted? Is there a fix for that initial issue? +Kevin, Luca, Since this patch reverts a fix done after 21.11, is there a way to stop that fix to be merged for 21.11.x? > Signed-off-by: Radu Nicolau > --- > drivers/net/iavf/iavf_rxtx.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c > index b0fed1b992..ba272bb211 100644 > --- a/drivers/net/iavf/iavf_rxtx.c > +++ b/drivers/net/iavf/iavf_rxtx.c > @@ -2464,9 +2464,10 @@ iavf_fill_data_desc(volatile struct iavf_tx_desc *desc, > desc->buffer_addr = rte_mbuf_data_iova(m); > > /* calculate data buffer size less set header lengths */ > - if (m->ol_flags & (RTE_MBUF_F_TX_TCP_SEG | RTE_MBUF_F_TX_UDP_SEG)) { > - if (m->ol_flags & RTE_MBUF_F_TX_TUNNEL_MASK) > - hdrlen += m->outer_l3_len; > + if ((m->ol_flags & RTE_MBUF_F_TX_TUNNEL_MASK) && > + (m->ol_flags & (RTE_MBUF_F_TX_TCP_SEG | > + RTE_MBUF_F_TX_UDP_SEG))) { > + hdrlen += m->outer_l3_len; > if (m->ol_flags & RTE_MBUF_F_TX_L4_MASK) > hdrlen += m->l3_len + m->l4_len; > else