From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 29831532C for ; Thu, 8 Sep 2016 19:15:03 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP; 08 Sep 2016 10:15:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,301,1470726000"; d="scan'208";a="1047439374" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.92]) ([10.237.220.92]) by orsmga002.jf.intel.com with ESMTP; 08 Sep 2016 10:15:00 -0700 To: Stephen Hemminger , zhouyangchao References: <1473389167-2758-1-git-send-email-zhouyates@gmail.com> <20160908094442.4dfa5b01@xeon-e3> Cc: dev@dpdk.org, Thomas Monjalon From: Ferruh Yigit Message-ID: <05b14d74-b168-69b2-b107-124ee951dc27@intel.com> Date: Thu, 8 Sep 2016 18:15:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20160908094442.4dfa5b01@xeon-e3> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] kni: unregister an unregisterd net_device could cause a kernel crash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Sep 2016 17:15:03 -0000 On 9/8/2016 5:44 PM, Stephen Hemminger wrote: ... > But then again the whole KNI driver fails completely when > running kernel style check. > Yes, it generates lots of warnings. I can fix them (excluding ethtool/*), that wouldn't take much time but how syntax only patches welcomed? Another concern is it trashes git blame. Regards, ferruh