From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 86BEDA0C43;
Fri, 17 Sep 2021 17:37:57 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 1036A410EC;
Fri, 17 Sep 2021 17:37:57 +0200 (CEST)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
by mails.dpdk.org (Postfix) with ESMTP id E7117410E9
for <dev@dpdk.org>; Fri, 17 Sep 2021 17:37:55 +0200 (CEST)
X-IronPort-AV: E=McAfee;i="6200,9189,10110"; a="222478371"
X-IronPort-AV: E=Sophos;i="5.85,301,1624345200"; d="scan'208";a="222478371"
Received: from orsmga001.jf.intel.com ([10.7.209.18])
by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
17 Sep 2021 08:37:53 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.85,301,1624345200"; d="scan'208";a="517167211"
Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81])
by orsmga001.jf.intel.com with ESMTP; 17 Sep 2021 08:37:52 -0700
Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by
fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.12; Fri, 17 Sep 2021 08:37:51 -0700
Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by
fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.12 via Frontend Transport; Fri, 17 Sep 2021 08:37:51 -0700
Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.47) by
edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2242.12; Fri, 17 Sep 2021 08:37:51 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=F6+aSANbPRL0WtEejJSL25Kc3V06CtPuhnyYP2bT82jUlzvEYs3mvmTWuX/fJV74U7SQ1VX4RGcuyo4sTeTu0/8zjqIb385uk+ezgYagfVjQcDrrLFgmaCtbcT6yLwSxYegnWh5veS+u6dG67sLRq3G80zvqgqn5eNjigIF6MGOCqlx9rCkohP9wB8i+opTPWWF32gx9bhafhbrRPDCpCIVJPz4hcxx5Xh16QhwX8ZUwJNr19LPkVBycGxZ9lJmnS+gfvBbQaRZ2YFt0qZeZ8cpdNkx9Rvrh5yZLZCLyfkYcHUs3Cn+WxJTiMBPQ++qLpgf2VbUjz7x2fywmuHsUMA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
bh=jWVznVYB/PHlFiTd4jYiA+Vxp7GN6M9IutBRtdbCSuU=;
b=m2FvJ8nAx1f9L59i9O7Zx05IKv6GVsFgH6drc/McGnda4gEeeXP1S9QaiSHROs3sFUhKB+2aNIppIpO3ahWAnWSdRbE7RQjj/Qn+wURIR9JV/pLSRxwXQiQG9DLvPCNCv4nIu/19sS8FwT5KkXlzuiWGkDNaRw598UMPciFJA58nAdEdGk1iUGUs2P4wGPM7WL0mxs/7QB2UK3X6ePayq8gseZPnC1+yK/xF2nyMmZu4RMDyUZgQP2/Q7SKqRzZDZ6F+SYNV60SDDtBAle+j+2qwfpbmOcdTpCfjedOfFz86W66bCHb4rnTV1vu2F36ubJbKTBiLRCcVZo3OGB8mGA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;
s=selector2-intel-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=jWVznVYB/PHlFiTd4jYiA+Vxp7GN6M9IutBRtdbCSuU=;
b=AQfZfb7zD21ywwHvcMjOzDAxA0UjuTS6RBehcKCGE3ovOlvOq8Kh2QLiEcZ8m5LAeX9EKTiWpdmv4MmWOqXfkez+NRpJWJvnH6jBPNu6/Ke/efHk+d/kHFc6gQ+VghCJaMwMM1BRk5KZtXmzViwmllSfiMTziP9jMEOQexbWjys=
Authentication-Results: monjalon.net; dkim=none (message not signed)
header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com;
Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19)
by PH0PR11MB5063.namprd11.prod.outlook.com (2603:10b6:510:3d::9) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Fri, 17 Sep
2021 15:37:50 +0000
Received: from PH0PR11MB5000.namprd11.prod.outlook.com
([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com
([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4523.017; Fri, 17 Sep 2021
15:37:50 +0000
To: David Marchand <david.marchand@redhat.com>, "Xia, Chenbo"
<chenbo.xia@intel.com>
CC: dev <dev@dpdk.org>, "Dumitrescu, Cristian"
<cristian.dumitrescu@intel.com>, Thomas Monjalon <thomas@monjalon.net>
References: <20210910022402.26620-1-chenbo.xia@intel.com>
<20210910022402.26620-7-chenbo.xia@intel.com>
<CAJFAV8waBzgRJs5w2Njx3E33NmH18hUKMeAk+rG_EFESFs5Nhw@mail.gmail.com>
<MN2PR11MB406323DEB43615339EC2DE099CDD9@MN2PR11MB4063.namprd11.prod.outlook.com>
<CAJFAV8x1cWRZABzMSv_jW5FHHZwO4y7uk-Qbh0d_maEXWhFv=A@mail.gmail.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
X-User: ferruhy
Message-ID: <05c42ef2-db1e-ecc8-e7b5-83c70d6341e4@intel.com>
Date: Fri, 17 Sep 2021 16:37:45 +0100
In-Reply-To: <CAJFAV8x1cWRZABzMSv_jW5FHHZwO4y7uk-Qbh0d_maEXWhFv=A@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: DB6P193CA0022.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::32)
To PH0PR11MB5000.namprd11.prod.outlook.com
(2603:10b6:510:41::19)
MIME-Version: 1.0
Received: from [192.168.0.206] (37.228.236.146) by
DB6P193CA0022.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::32) with Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.4523.14 via Frontend Transport; Fri, 17 Sep 2021 15:37:49 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: faca1266-a03c-4f30-3225-08d979f11b68
X-MS-TrafficTypeDiagnostic: PH0PR11MB5063:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <PH0PR11MB506331834C5DB93D37D80E3095DD9@PH0PR11MB5063.namprd11.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4714;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 7A6ESdjCoVYhT9vgGDUOvbNOaRM+ICBaR+WD8fgTta6CFOiOwqFnK5lJfTEH5IxFcAfWvj5+XfIPQ1FnB3k+GUio/4k37oCIv/7DuoN+cpQgCht8M+8RnR2HE6BS+oOfUyu2EWp7QAU/rf24Nqv6dqNS60zvd/dMN637ZfQFZMnVmIMykgVC3c/Tp1F+09IQ0Z/n531Bc1RadY+U9yZEizq2PamIVMJZkhGc2Nw9+/GnoHmLUx6BabcSVojbeYLZCN5Fdqh7lEmv57QPL9eJJwkrU1lcYERrfYx59wpvRpUNXYEIBL/g+s/wwsuqjHkFrqP1RDzX8MW0Mms/moJLZ/5xTkwWJyt98F1rJuose3LDnbUd+mMrcqC2g6OJYtNKZd8cJfYvvrkbv8NVV8JcB9Y0z6RS+8kbsJVqY6usIEFUOP4E8IqVY43VPXIrED9seEv+DPaMFnNsQ43fYYlNjYJNPUs+BidTNxZq5QgvVm1MR990Vd/gYrMzgeEC4dVKlonA6J8DU8RTLzxTy0Dkn1w8E5McXGmM0pHQhpiQwpvAaanxKZfnqrFDQUT7TEVE9La21L5rcb+3ic8tgumy3v8EhKHOgrz3HJj04ua5CKFDvWN0hgLY7GxJkotc/l4u+myEm236hjnAE0pMiM9KaSueRyyynPp3Owr7fHxh1ue7/1YcBs1/WivMYjH1jE3U0aftgiS6+cLeoLfhBXZtFA==
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(4636009)(366004)(2906002)(6486002)(38100700002)(54906003)(6636002)(44832011)(16576012)(316002)(110136005)(36756003)(2616005)(5660300002)(31686004)(956004)(53546011)(26005)(66476007)(66556008)(66946007)(4326008)(31696002)(186003)(86362001)(508600001)(6666004)(8676002)(8936002)(45980500001);
DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VXRIQkhXT2dma3hidS93c3krT2JTWVlQSkVnSzNmV1hWanVwUUw1akVtN1ZS?=
=?utf-8?B?QzJpbDNkb2daWlNHVWluZU9sUVF2Tldmc2hQY3dQemNkRW1RVEo0b0lnM3d0?=
=?utf-8?B?Rjl2T3NhRHhiMEJac2ZrTkNxeEJvTFZ5STB4emdKRVA0S3VoNCsvdDhNMEU4?=
=?utf-8?B?ZFdaRDR3WUsxTjdram45NTdGOHRxN0dKQ2ZKS0p0U3ZtY2FvcElrNjZ4M1FW?=
=?utf-8?B?a0xoaEdnd1pWWGVSRTV2Y0lTZHg4all0akNMMDlnS01sVG5EV1kzU2tzYWJK?=
=?utf-8?B?Y0hSa0ZFc3dCREJ4VXgrUDZRSTVYYUpleWM1VHRjUHovaDJMcUVkNnhFODV0?=
=?utf-8?B?bmhacUwrNXJHOWVRdnhWMFpSeHNjNWIrbkNsbnp6Y0NuZGYwakNjK2IvZlQy?=
=?utf-8?B?N2xCVmdKdnZvSEsyQ2luaXJBNXFiczdoQWNOeGR2VlhwU1hwcFIybFJ3cjg1?=
=?utf-8?B?WVVGckFmd25CYklGVWlBTlBJMlZUbWd0aVdtZkJ2RzRLc1ZGMXJ1LzlGN0Z6?=
=?utf-8?B?b0s3Ty95T1VETVZwRXBMUnRZWGpjNWtsR1ZpVnFwR2dha3lUUmZtVVdNUlJG?=
=?utf-8?B?SlBjNTBqY1YrOTQ5aEgxTFRsZmo3VWlOSWE2TkRaUHF5MytmL0JYTnNFZVR3?=
=?utf-8?B?MGVYazQxMHNUMGQ0eFJVamZGUmVwREFmc0ZwTGN0V0dHWndQMmVkYnBoeFNI?=
=?utf-8?B?VHF4S1h5WUkyOEZNNytyLzNBNTh3ajdBc3BXb3libkRXKzI5M0lUZFV5K25Q?=
=?utf-8?B?ZkZ1QjNPQXZQeVdzSmN6K2ZwWi93eHBTVGZlQkUrRjBrdXZlVjNNZ2ZWVVIr?=
=?utf-8?B?Mk05bXMvUXUySnZscmRva2JpLzdRYk8vbi9mcWNJWDFJTlRzMkVWNXNocVlv?=
=?utf-8?B?UjZuOUJsR1BFM1U3MUVDdHowNTB1VkczRCtVSWdNcGhLcTBoeUY4dUhqWW5D?=
=?utf-8?B?Z2t1WWhPaDN5QmJtaldSSlpYcHpqSzhVeWRVS24vekRWcnhVUktzME43aWcv?=
=?utf-8?B?d1hEMTBwSVFaQlJFQ2hITDk3N2o0UEUvU1k1L2thZHhLdFN6a3hHY3NhUW9s?=
=?utf-8?B?RHN3Y29KUmh3RVZQWjlhZ1ZueWpvTmcySHlLRkVsTWdlZllOMUhLWW9BOGF3?=
=?utf-8?B?R1FQdVluK2xTUDZ5NUFiQnM0UGhUd1RKdW43SXVXV2RKeXRXWXVJMC9kcjFG?=
=?utf-8?B?OWJReVA5NmhoUFNSNUhLRGZmTXdOYTc0SWhVREVIOFNKOXk2N0JhYW52WWgx?=
=?utf-8?B?dmRkdnc1RG5pNm5LV2FURThhTWcwNFB3NE5rVnJJYXFXVHJHWTcvZ1dMWlFk?=
=?utf-8?B?Y3BxVDZMK080U3hjWWorRVZqNzhlNFdDd2c1UlJTYjFXejlMQTVxV3hDdmsr?=
=?utf-8?B?V2ExL0ZxZmhKWjNqVXU3WjNWeU5nY0NnWmowVk9VQjNBeXVHZlhoR09PS1k1?=
=?utf-8?B?TEVnSkk4YjhReUsyVjBlMjZNN21wSmVwMnZzT0JLVFRPUWZMK0IrQUxQNnFD?=
=?utf-8?B?b3NpeGJLVFNBMzBrZkpRNVFTaHE5RkJPTkRaUHlpY3ZwaWdZTVBaRVE4c1Ix?=
=?utf-8?B?cU4vcGNGcjlGbUpzeXpuaGxqYytpajkxMk80U05oTVpaUTNReSt1bGtBMEZI?=
=?utf-8?B?cTBUZkRoZ2Q2YjFOallCaXBWYS9Zdm9icnd3N0hPSmhPWWxWcmlkM1hRb2cx?=
=?utf-8?B?NERwOHZRZEk3d0p6SUczUUlpU0puRlBxb0lUMTlzdmJZZGV3OEI3aEdyZ01y?=
=?utf-8?Q?26zRXYaYAwJva94R4xTEi394JJo4eBc79t5dovg?=
X-MS-Exchange-CrossTenant-Network-Message-Id: faca1266-a03c-4f30-3225-08d979f11b68
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2021 15:37:50.5957 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wP6P/R6Fxr888qB4kTOiHzTvL/XfUA2BFfY1goGqZlExr/OTKb1l7Fd9f0kph/NaP4MBRhs+GQ1RqObw/q5iAg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5063
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [PATCH 6/8] examples/ip_pipeline: remove setting of
PCI ID and address
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 9/17/2021 12:55 PM, David Marchand wrote:
> Hi Chenbo,
>
> On Fri, Sep 17, 2021 at 5:09 AM Xia, Chenbo <chenbo.xia@intel.com> wrote:
>>>> PCI ID and address in structure rte_kni_conf are never used and
>>>> will be removed in kni library. So remove the setting of them
>>>> first in the example.
>>>>
>>>> Signed-off-by: Chenbo Xia <chenbo.xia@intel.com>
>>>
>>> (forgot to Cc: Ferruh in previous comment)
>>> Ditto patch 5.
>>>
>>> I would tag with a Fixes: on ethtool removal.
>>> Plus, this is the same kind of cleanup wrt kni, you can squash those
>>> two patches together.
>>
>> A question about squash patch 5 and 6, then how should I title the combined
>> patch? Because there're both test change and example change. I'd like know
>> your suggestion.
>>>
>
> This is a cleanup on unused fields wrt KNI.
> "kni: remove unused PCI info from test and example" lgtm.
>
> Ferruh, opinion?
>
Make sense to merge them and above suggestion looks good. Thanks.
> And mark with:
> Fixes: ea6b39b5b847 ("kni: remove ethtool support")
>
>