From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D706AA0A02;
	Thu, 25 Mar 2021 18:12:00 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 7F111140F2E;
	Thu, 25 Mar 2021 18:11:36 +0100 (CET)
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by mails.dpdk.org (Postfix) with ESMTP id 4AC4C140F25
 for <dev@dpdk.org>; Thu, 25 Mar 2021 18:11:33 +0100 (CET)
IronPort-SDR: SkDLraeArR0YzD2LsGXmrQEWfZuJXXmsDi5fWjWd1wdiuMeceqwWjkYYFGrpF6KbD4oVCrPfI1
 ArmLEGSdsxUg==
X-IronPort-AV: E=McAfee;i="6000,8403,9934"; a="187674283"
X-IronPort-AV: E=Sophos;i="5.81,278,1610438400"; d="scan'208";a="187674283"
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 25 Mar 2021 10:10:54 -0700
IronPort-SDR: ak1FbrDMFo2cAmT52Vrfz10VJZV+W3InUoA+WRLk+jsQffVcMSmHIhS84v0iUds8Oxz55qGWkE
 E97Czp8Gudpw==
X-IronPort-AV: E=Sophos;i="5.81,278,1610438400"; d="scan'208";a="391821159"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.15.136])
 ([10.252.15.136])
 by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 25 Mar 2021 10:10:51 -0700
To: Jiawei Wang <jiaweiw@nvidia.com>, viacheslavo@nvidia.com,
 xiaoyun.li@intel.com, Ori Kam <orika@nvidia.com>
Cc: dev@dpdk.org, Andrew Rybchenko <arybchenko@solarflare.com>,
 Thomas Monjalon <thomas@monjalon.net>
References: <1615295935-11197-1-git-send-email-jiaweiw@nvidia.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
X-User: ferruhy
Message-ID: <05ca2fef-575c-7e95-2033-2a09dcc453c3@intel.com>
Date: Thu, 25 Mar 2021 17:10:47 +0000
MIME-Version: 1.0
In-Reply-To: <1615295935-11197-1-git-send-email-jiaweiw@nvidia.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH] doc: add sampling and mirroring in testpmd
 guide
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/9/2021 1:18 PM, Jiawei Wang wrote:
> Update documentation for sample action usage in testpmd and
> show the command line example.
> 

+1 to document this.

Indeed for all testpmd flow update, it must be mandatory to update "Flow rules 
management" section for it, Ori what do you think?

> Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

<...>

> +Sample Sampling/Mirroring rules
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +
> +Sample/Mirroring rules can be set by the following commands
> +
> +NIC-RX Sampling rule, the matched ingress packets are duplicated and sent to
> +the queue 1, and each second packets are marked with 0x1234 and sent to
> +queue 0.
> +

Also each second packets duplicated to queue 1, isn't it, because of 'ratio 2'?

> +::
> +
> + testpmd> set sample_actions 0 mark id  0x1234 / queue index 0 / end
> + testpmd> flow create 0 ingress group 1 pattern eth / end actions
> +        sample ratio 2 index 0 / queue index 1 / end
> +
> +E-Switch Sampling rule, the matched ingress packets are duplicated and sent
> +to port id 2, and each second packets are sent to eswitch manager.
> +

what is 'E-Switch', or "eswitch manager", isn't the mirror rule generic?