DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Richael Zhuang <richael.zhuang@arm.com>, dev@dpdk.org
Cc: nd@arm.com, David Hunt <david.hunt@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1 1/1] power: add support for cppc cpufreq
Date: Thu, 22 Apr 2021 10:06:11 +0100	[thread overview]
Message-ID: <05d09823-3b20-0192-b03c-9f086b041b36@intel.com> (raw)
In-Reply-To: <20210422061540.23304-2-richael.zhuang@arm.com>

On 22-Apr-21 7:15 AM, Richael Zhuang wrote:
> Currently in DPDK only acpi_cpufreq and pstate_cpufreq drivers are
> supported, which are both not available on arm64 platforms. Add
> support for cppc_cpufreq driver which works on most arm64 platforms.
> 
> Signed-off-by: Richael Zhuang <richael.zhuang@arm.com>
> ---

Just a general note: this looks like a copy-paste of pstate code. Which 
is perfectly fine, except that we can do better than copying some faults 
of the pstate code to other drivers. I've submitted a patch [1] 
attempting to fix some of the pressing issues and code duplication in 
pstate driver, but i'm sure with a fresh driver, you can do even better :)

[1] 
http://patches.dpdk.org/project/dpdk/patch/20210402092701.258316-1-anatoly.burakov@intel.com/

-- 
Thanks,
Anatoly

  reply	other threads:[~2021-04-22  9:06 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-22  6:15 [dpdk-dev] [PATCH v1 0/1] power: add support for cppc cpufreq driver Richael Zhuang
2021-04-22  6:15 ` [dpdk-dev] [PATCH v1 1/1] power: add support for cppc cpufreq Richael Zhuang
2021-04-22  9:06   ` Burakov, Anatoly [this message]
2021-04-22  9:29     ` Richael Zhuang
2021-04-22  9:59       ` Burakov, Anatoly
2021-04-22 10:02         ` Richael Zhuang
2021-04-23 11:37           ` Burakov, Anatoly
2021-04-24  7:03             ` Richael Zhuang
2021-05-12  3:49   ` [dpdk-dev] [PATCH v2 0/2] power: add support for cppc cpufreq driver Richael Zhuang
2021-05-12  3:49     ` [dpdk-dev] [PATCH v2 1/2] power: add support for cppc cpufreq Richael Zhuang
2021-05-12  3:49     ` [dpdk-dev] [PATCH v2 2/2] test/power: round cpuinfo cur freq only when using CPPC cpufreq Richael Zhuang
2021-05-12  3:57   ` [dpdk-dev] [PATCH v3 0/2] power: add support for cppc cpufreq driver Richael Zhuang
2021-05-12  3:57     ` [dpdk-dev] [PATCH v3 1/2] power: add support for cppc cpufreq Richael Zhuang
2021-06-23  3:55       ` [dpdk-dev] [PATCH v4 0/2] power: add support for cppc cpufreq driver Richael Zhuang
2021-06-23  3:55         ` [dpdk-dev] [PATCH v4 1/2] power: add support for cppc cpufreq Richael Zhuang
2021-06-23 14:10           ` David Hunt
2021-06-24  2:13             ` Richael Zhuang
2021-06-25  2:02           ` [dpdk-dev] [PATCH v5 0/2] power: add support for cppc cpufreq driver Richael Zhuang
2021-06-25  2:02             ` [dpdk-dev] [PATCH v5 1/2] power: add support for cppc cpufreq Richael Zhuang
2021-07-07 13:47               ` David Hunt
2021-07-08  2:09                 ` Richael Zhuang
2021-07-08  2:34               ` [dpdk-dev] [PATCH v6 0/2] power: add support for cppc cpufreq driver Richael Zhuang
2021-07-08  2:34                 ` [dpdk-dev] [PATCH v6 1/2] power: add support for cppc cpufreq Richael Zhuang
2021-07-08  8:27                   ` David Hunt
2021-07-08 13:30                   ` David Marchand
2021-07-08 20:43                     ` David Marchand
2021-07-09  2:37                     ` Richael Zhuang
2021-07-09  3:34                   ` [dpdk-dev] [PATCH v7 0/2] power: add support for cppc cpufreq driver Richael Zhuang
2021-07-09  3:34                     ` [dpdk-dev] [PATCH v7 1/2] power: add support for cppc cpufreq Richael Zhuang
2021-07-09  9:10                       ` David Marchand
2021-07-09 10:35                         ` Richael Zhuang
2021-07-09  9:52                       ` David Hunt
2021-07-09 10:55                       ` [dpdk-dev] [PATCH v8 0/2] power: add support for cppc cpufreq driver Richael Zhuang
2021-07-09 10:55                         ` [dpdk-dev] [PATCH v8 1/2] power: add support for cppc cpufreq Richael Zhuang
2021-07-09 10:55                         ` [dpdk-dev] [PATCH v8 2/2] test/power: round cpuinfo cur freq only in CPPC cpufreq Richael Zhuang
2021-07-09 14:07                         ` [dpdk-dev] [PATCH v8 0/2] power: add support for cppc cpufreq driver David Marchand
2021-07-12  2:05                           ` Richael Zhuang
2021-07-09  3:34                     ` [dpdk-dev] [PATCH v7 2/2] test/power: round cpuinfo cur freq only in CPPC cpufreq Richael Zhuang
2021-07-08  2:34                 ` [dpdk-dev] [PATCH v6 " Richael Zhuang
2021-07-08  8:27                   ` David Hunt
2021-06-25  2:02             ` [dpdk-dev] [PATCH v5 2/2] test/power: round cpuinfo cur freq only when using " Richael Zhuang
2021-06-23  3:55         ` [dpdk-dev] [PATCH v4 " Richael Zhuang
2021-06-23 14:13           ` David Hunt
2021-05-12  3:57     ` [dpdk-dev] [PATCH v3 " Richael Zhuang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05d09823-3b20-0192-b03c-9f086b041b36@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=david.hunt@intel.com \
    --cc=dev@dpdk.org \
    --cc=nd@arm.com \
    --cc=richael.zhuang@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).