From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id C0E42EE2F for ; Tue, 17 Apr 2018 17:48:20 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2018 08:48:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,464,1517904000"; d="scan'208";a="217284160" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by orsmga005.jf.intel.com with ESMTP; 17 Apr 2018 08:48:18 -0700 Received: from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com [10.237.217.45]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id w3HFmIW7031003; Tue, 17 Apr 2018 16:48:18 +0100 Received: from sivswdev01.ir.intel.com (localhost [127.0.0.1]) by sivswdev01.ir.intel.com with ESMTP id w3HFmIJd024786; Tue, 17 Apr 2018 16:48:18 +0100 Received: (from aburakov@localhost) by sivswdev01.ir.intel.com with LOCAL id w3HFmI9B024782; Tue, 17 Apr 2018 16:48:18 +0100 From: Anatoly Burakov To: dev@dpdk.org Cc: thomas@monjalon.net, anatoly.burakov@intel.com Date: Tue, 17 Apr 2018 16:48:15 +0100 Message-Id: <05d5fd855d95a7427da810166ec715b470d73e8e.1523979264.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 1.7.0.7 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-dev] [PATCH 3/5] malloc: fix potential negative return X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 15:48:21 -0000 Return from rte_socket_id_by_idx() may be negative, which would result in negative array index. Coverity issue: 272590 Fixes: 1403f87d4fb8 ("malloc: enable memory hotplug support") Cc: anatoly.burakov@intel.com Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/malloc_heap.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/librte_eal/common/malloc_heap.c b/lib/librte_eal/common/malloc_heap.c index 5cf7231..f81aaf3 100644 --- a/lib/librte_eal/common/malloc_heap.c +++ b/lib/librte_eal/common/malloc_heap.c @@ -563,6 +563,10 @@ malloc_heap_alloc(const char *type, size_t size, int socket_arg, /* try other heaps */ for (i = 0; i < (int) rte_socket_count(); i++) { cur_socket = rte_socket_id_by_idx(i); + if (cur_socket < 0) { + RTE_LOG(ERR, EAL, "Invalid socket index: %i\n", i); + continue; + } if (cur_socket == socket) continue; ret = heap_alloc_on_socket(type, size, cur_socket, flags, -- 2.7.4