From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7AB8941E1E; Wed, 8 Mar 2023 11:20:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F5C940FAE; Wed, 8 Mar 2023 11:20:57 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2059.outbound.protection.outlook.com [40.107.237.59]) by mails.dpdk.org (Postfix) with ESMTP id 9F0EC40ED6; Wed, 8 Mar 2023 11:20:56 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SDpKsWDY9CJVI60GtjbLSdFc73biWumMCD5cvAW9Vla2PvlEAF7/6FkF0wdcypSn+KlfRtcaQYXXJE0vz66kwTkeEOfGRKQJ1+PwFDxYdUe4PvEE1/HsYDd5zHLqM7V99MvC5khyBXSZCMeSoYL2iDYFplqZvpXkASuB+v7/1ATCn9kuUxHn41YX0bNskQ1geqb10BfkV6qw22p1BZx2T9c4EhlBRtdbQNauWQ7Tis43jL4BfOguQ3WNEjivowJgeK7yv4TL6aYUEYgjONhLpzHYMx6/qYJWlxtgEyfbOd2QMaQ8EDKVgybI+HNhABBsot+/v22xTOZpj0nqAyT5kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8d4G3OZukxZ3mkG+7C4MByQKY6FL15H7aetSKECzq4g=; b=lnydZDfHGyTg/Lz+X0jCYkQs0wgZsn4nK4lDFK/lJD4rfXNIsHm3WukyeLD01R+LadzFMMKiDLqwOTeloFYiHKm7ob9ckgfVlH6H7OH4TXArR+nhJw6AfxnMK2SSmi9weuDeAkC/ho9CZHHm7dAQ/KT0h2XM7hpSovx67/6joy1k/2taLQf4XASYB56A6OooqQXU+748/RhQk3Xd9nxM4vDZpA6/Yw2FoN5QODKQAwXR70K8n1ZbrjZ5V5FZtN9YyRE7buo1sugcpB7qwrGNqwy4BA6M0XGZzWt9obsDKRV97PHEY+Sw0RYmOrLj3MC4TUEq7WsI20u17ejjOY51LA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8d4G3OZukxZ3mkG+7C4MByQKY6FL15H7aetSKECzq4g=; b=bNENIwnAqE0gzZNlubiLlhozWM0506d+qkTZU976pO4t8PO0NVQBwKU0vyugo5QWef3vbOJHbnb8QOsfRwSejtMLzdWUvKivrB4Zu9WZJWh9j8T0P6svqRwzwXC5iJ5tV60ADZY7bNSdzPN5PQG8JQHLl2QjwaSrwpdFvdrzMsA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA0PR12MB7479.namprd12.prod.outlook.com (2603:10b6:806:24b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.28; Wed, 8 Mar 2023 10:20:53 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640%4]) with mapi id 15.20.6156.029; Wed, 8 Mar 2023 10:20:53 +0000 Message-ID: <05efd62f-3470-6c39-6e2e-2a474a53b16c@amd.com> Date: Wed, 8 Mar 2023 10:20:44 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4] app/testpmd: fix secondary process not forwarding Content-Language: en-US To: Shiyang He , dev@dpdk.org Cc: yidingx.zhou@intel.com, stable@dpdk.org, Aman Singh , Yuying Zhang , Anatoly Burakov , Matan Azrad , Dmitry Kozlyuk References: <20230223144106.707999-1-shiyangx.he@intel.com> <20230308161947.700659-1-shiyangx.he@intel.com> From: Ferruh Yigit In-Reply-To: <20230308161947.700659-1-shiyangx.he@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP265CA0027.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5c::15) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA0PR12MB7479:EE_ X-MS-Office365-Filtering-Correlation-Id: b2df0e2e-6e23-4061-9a49-08db1fbecb9e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sQkU/oFnYvAQZCrEi0aLy6Sq9V20yUxfVQQFBMutsEzojqpYPZq+vVIfitVT1d3ayDY1EYfX8lkpVYmlCZrkXY+BF0qwUW4Q0SPUQ6IVEQyirPc1jv7Q3fA5iqMJr+ll/tGZznlzSZsFJzlC8cFlJLQuOlWVbIs4JjVjtWEuySc1HukcV+TEObXXxdqKPU6Vsf2L8KSvuRe0PNtC/EjCTweyo4AqUNW4nvBBkJZIRnOGEYmjelZTtz9LEg3cqXl4vxVkoTYi3ej7IEDaf19vSsZprlxZxEHogQkXxZaXCwVpTYmMCzRzi7D7kY+R83BtjWGMQw3bk/alodoLrjxwLM8Hsg4x/SpEj/FdtTYjWo4k0WYgM8Z6/LdjsMTd4HU6WmTy5U64d3ZRudxlKfNerdniT5B7mly/ZhuqldaJRufL8XxWPN7NMOzagXbO/eMeLw3Gvyq3VynwjHerumVi09oeZ5HnFAXMXei1QiWB1diTnJfg5wO5GD2/rTlZnAxSVnrO79PiVIK7Mn4nw8jNI+yd4z8xJODPtFe/NofSmMd6oxw+SuM7uFdcIQVJ0UM/6Cdn4d/Jfl6M7YtSw6MczlNrlvRvwORyx9mS1HDf3JxhCnidIyE5/GTLTfq6u7lBrJu3LiF2XJiGMLDDjW844xCi5WTS03z5kBlA1z3syjwrhSw/XL5qNOX7KEnD21621T4hdcDOA6h+yDdFBBiTc5OrGXYw+EUxlrUrfaiRsxI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(136003)(396003)(366004)(39860400002)(346002)(376002)(451199018)(31686004)(36756003)(31696002)(2906002)(86362001)(8936002)(5660300002)(38100700002)(478600001)(26005)(186003)(66476007)(6506007)(6512007)(53546011)(6486002)(6666004)(2616005)(4744005)(66556008)(316002)(4326008)(44832011)(8676002)(66946007)(41300700001)(54906003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z1QrYXYvYS85a0dXOUN6RnVESmo3dEpPVldFb1ZYeXhZSktiN25ZZ243KzIw?= =?utf-8?B?cjZVcnBVa095MURxQjF5OUxWaWN6NndBOVhEeDc0aDUzNmxyazdYYm1MQTB3?= =?utf-8?B?UCtKdDdGYW1NdmVTaklydk9GQjlSUGRhcUxlOFBaZ083NHFGMzhwQjVESFJo?= =?utf-8?B?aU1zdmdOQnByK3hFUkJHM3JxcXVqYkRPT0QzaDc5T0U1eDZjcDBqSzZ6Tkw5?= =?utf-8?B?dUFSbCthbFV4UkJmR2xscmZmVS9wTm9XYThNTWlWTUpsT3lOK3ArQnlrblhU?= =?utf-8?B?bGhSZHlLRDJQL1FRRWZ0cmwrY1B6d0E3MFRvN240MmhHREgwa3NkUktVdEpJ?= =?utf-8?B?NE85U2M0NUZwQ3dabFp5dllEZ2pMb3FCTm9wQlpUQXRkYlNvRlk5MTMzcjIz?= =?utf-8?B?TmpsVWRib0hwOVdBVjNFTE1FcVdUSFB2b2o3dDhMN2kvNGl1RzVDczFiYVJs?= =?utf-8?B?Q3BjRmE3U0ZyMzNabzRHblVhSTFNd0pMdUdRZVhmL2M3QmoxSnhQWitzTDBF?= =?utf-8?B?RDZKdk5BTUJXMVZKa2kwZXIwRUtJOHFYNG5pZEhpV21xaVdIR3hZWlRlRWxa?= =?utf-8?B?MFNncXI3dzI0Wmg0ME5PUzZNcWZaME9tMlBiQUgwVFR5cTd5MlVjU1huVHY5?= =?utf-8?B?SERKOUEzZ2NPWmV0b0N6czRibUZjZFdqWG9oQjdDL1NmZFZna0pHZGtaZmdU?= =?utf-8?B?MVQxVmlUTmJ4NWJZTWowS21nekJKaTIxVjFvMXZad0JyU0JIWFhTZXAvT1pn?= =?utf-8?B?M0N4aXMyYk91b2VES3lveDQrelhoTEJPWVJId3Nmc0dwQVRmL3lWcnllblNu?= =?utf-8?B?OU53b2x4UHFBVkFxbkpxem5HNzRvN3lueU1pWXVwYzQ0MmRFRUZvY0NjczNU?= =?utf-8?B?S0NpNTdyU2VwREZqL095ZHBHNXlpSXNlUTFZdnVaQndZQTYzUThJN1BjUDZC?= =?utf-8?B?Z0RaT1BoVmp0SHdiVXdOVnBrT1VTalgxNUtIai9ZR1hOQU9wMElWMWNjWkhj?= =?utf-8?B?RVdLQURScTNySjJGZm5ZRVJsaWgwa1lVNTdocGd5Q1gzQ2w5bi9sTkZqMW5H?= =?utf-8?B?T2YwT3djZWhHZ1JnRU4wdXFBZUJuZmF3UUVqRW9za2Q1d1lUa1RJZFhJWC9Y?= =?utf-8?B?OXIzYVk5VzVNMWZRdE00ODdsNmQxM3c3Q0NtNHVZU3g0YVcrK2pHaUIwckNU?= =?utf-8?B?VjltRUVvL240NmhkTWs4REpWaUNxR1A1VXl3RGFKYlpwa3VMcnBYLzVYQTll?= =?utf-8?B?c0x6Tlg3cElueTN0V3htMkpOVGw5ZFdlRlhoMi92bFZLdWkwb2tYR0JFLzhM?= =?utf-8?B?MmI3eURHQThhci9UcTJRZ29CeVZnUjlWWmtmMWRoZHp4Z2prRUQxdVBCK1Ju?= =?utf-8?B?VGFOSWo4WFU2c0J0RlFweGxadWZaaDVEZzV1QWNwcUlkV04rK1ltVm1DOGZP?= =?utf-8?B?WkpoNGlMK0lENlNPdjNsVEI1elBxU1dxUTZ3UWFMMHR4Vys4Q005SGNLWmxH?= =?utf-8?B?UXIrenlBaDdnRm1sU243R2pESGVTdnVTRisySXRYK0I2QTFlL2U3Z0VXckJE?= =?utf-8?B?b1JkZW5tcVdGR0wyNXVnblA4OE9UTldsT3EzeExjY2E0OUhwTTN6dDVvdjI0?= =?utf-8?B?cEsxTjhkdGhBRW9tR0JwYlduaU9WcWxiWTA4dmNvVTQzUmlRaGw5TTJPSnBN?= =?utf-8?B?TXpJVHpQRTd4NjArRURWZVg1TWp1SjNSNXI1M0hoVkVWY3BiNFdrTDRBQi9R?= =?utf-8?B?bWR2S1A5N0pDSkt0MlI5bFdnQmVRVVI5TVRBMG5vM0Z1Ylp4SUZOamsrUjRC?= =?utf-8?B?UFliQk0waU5vb2piRXBKY2tjaldkVXliZnhrdmc4WUFERlhVV3RMNS9IaDdj?= =?utf-8?B?djJxNGYxMDlQUkluTVpxNndmeW1sSUdCS0NaQzgyNEFRWFFtUW1qRlNqc0hP?= =?utf-8?B?VDc4NC9BUVc4Nm93c1VTenVIcXBkcnZiSWFsaW15TkkvdGkzdmdsVWFsMCt2?= =?utf-8?B?emMydlA5eFVoN05TM2hqWDZ4MU8zNTFPUnJtMjRhYWt4aGtpakRkZmRQWGZz?= =?utf-8?B?RzJUNFl3MUd0VmljZ1puMUdTYW9DSnVsU1RvOXBPUmp3bWt0U0M2a3hzZUdU?= =?utf-8?Q?cvz0v2s4NCyWmP2hAIWQJz2GS?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b2df0e2e-6e23-4061-9a49-08db1fbecb9e X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2023 10:20:52.5348 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FxMkTwZMdroTLNEtne4a/aYlPjA+Qr3aXiN8TeBSAZYtuOIaKm/L5FK+nZYqk6vp X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB7479 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/8/2023 4:19 PM, Shiyang He wrote: > Under multi-process scenario, the secondary process gets queue state > from the wrong location (the global variable 'ports'). Therefore, the > secondary process can not forward since "stream_init" is not called. > > This commit fixes the issue by calling 'rte_eth_rx/tx_queue_info_get' > to get queue state from shared memory. > > Fixes: 3c4426db54fc ("app/testpmd: do not poll stopped queues") > Cc: stable@dpdk.org > > Signed-off-by: Shiyang He Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.