* Re: [PATCH] ipsec: remove unneccessary null check
2023-01-13 18:44 [PATCH] ipsec: remove unneccessary null check Stephen Hemminger
@ 2023-01-13 19:04 ` Tyler Retzlaff
2023-01-16 9:16 ` Zhang, Fan
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Tyler Retzlaff @ 2023-01-13 19:04 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev, kai.ji, Pablo de Lara, Ciara Power
On Fri, Jan 13, 2023 at 10:44:25AM -0800, Stephen Hemminger wrote:
> The function rte_ring_free() accepts NULL as vaild input
> like free() and other functions.
>
> Found with null_free_check.cocci.
>
> Fixes: 16d6ebb65d59 ("crypto/ipsec_mb: fix null checks")
> Cc: kai.ji@intel.com
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
> index 71e02cd0513d..3e52f9567401 100644
> --- a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
> +++ b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
> @@ -139,15 +139,12 @@ int
> ipsec_mb_qp_release(struct rte_cryptodev *dev, uint16_t qp_id)
> {
> struct ipsec_mb_qp *qp = dev->data->queue_pairs[qp_id];
> - struct rte_ring *r = NULL;
>
> if (!qp)
> return 0;
>
> if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
> - r = rte_ring_lookup(qp->name);
> - if (r)
> - rte_ring_free(r);
> + rte_ring_free(rte_ring_lookup(qp->name));
>
> #if IMB_VERSION(1, 1, 0) > IMB_VERSION_NUM
> if (qp->mb_mgr)
> --
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ipsec: remove unneccessary null check
2023-01-13 18:44 [PATCH] ipsec: remove unneccessary null check Stephen Hemminger
2023-01-13 19:04 ` Tyler Retzlaff
@ 2023-01-16 9:16 ` Zhang, Fan
2023-01-16 23:28 ` Ji, Kai
2023-01-31 8:17 ` [EXT] " Akhil Goyal
3 siblings, 0 replies; 5+ messages in thread
From: Zhang, Fan @ 2023-01-16 9:16 UTC (permalink / raw)
To: dev
On 1/13/2023 6:44 PM, Stephen Hemminger wrote:
> The function rte_ring_free() accepts NULL as vaild input
> like free() and other functions.
>
> Found with null_free_check.cocci.
>
> Fixes: 16d6ebb65d59 ("crypto/ipsec_mb: fix null checks")
> Cc: kai.ji@intel.com
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
> index 71e02cd0513d..3e52f9567401 100644
> --- a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
> +++ b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
> @@ -139,15 +139,12 @@ int
> ipsec_mb_qp_release(struct rte_cryptodev *dev, uint16_t qp_id)
> {
> struct ipsec_mb_qp *qp = dev->data->queue_pairs[qp_id];
> - struct rte_ring *r = NULL;
>
> if (!qp)
> return 0;
>
> if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
> - r = rte_ring_lookup(qp->name);
> - if (r)
> - rte_ring_free(r);
> + rte_ring_free(rte_ring_lookup(qp->name));
>
> #if IMB_VERSION(1, 1, 0) > IMB_VERSION_NUM
> if (qp->mb_mgr)
Acked-by: Fan Zhang <fanzhang.oss@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* RE: [PATCH] ipsec: remove unneccessary null check
2023-01-13 18:44 [PATCH] ipsec: remove unneccessary null check Stephen Hemminger
2023-01-13 19:04 ` Tyler Retzlaff
2023-01-16 9:16 ` Zhang, Fan
@ 2023-01-16 23:28 ` Ji, Kai
2023-01-31 8:17 ` [EXT] " Akhil Goyal
3 siblings, 0 replies; 5+ messages in thread
From: Ji, Kai @ 2023-01-16 23:28 UTC (permalink / raw)
To: Stephen Hemminger, dev; +Cc: De Lara Guarch, Pablo, Power, Ciara
Acked-by: Kai Ji <kai.ji@intel.com>
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Friday, January 13, 2023 6:44 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; Ji, Kai
> <kai.ji@intel.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> Power, Ciara <ciara.power@intel.com>
> Subject: [PATCH] ipsec: remove unneccessary null check
>
> The function rte_ring_free() accepts NULL as vaild input like free() and
> other functions.
>
> Found with null_free_check.cocci.
>
> Fixes: 16d6ebb65d59 ("crypto/ipsec_mb: fix null checks")
> Cc: kai.ji@intel.com
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
> b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
> index 71e02cd0513d..3e52f9567401 100644
> --- a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
> +++ b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
> @@ -139,15 +139,12 @@ int
> ipsec_mb_qp_release(struct rte_cryptodev *dev, uint16_t qp_id) {
> struct ipsec_mb_qp *qp = dev->data->queue_pairs[qp_id];
> - struct rte_ring *r = NULL;
>
> if (!qp)
> return 0;
>
> if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
> - r = rte_ring_lookup(qp->name);
> - if (r)
> - rte_ring_free(r);
> + rte_ring_free(rte_ring_lookup(qp->name));
>
> #if IMB_VERSION(1, 1, 0) > IMB_VERSION_NUM
> if (qp->mb_mgr)
> --
> 2.39.0
^ permalink raw reply [flat|nested] 5+ messages in thread* RE: [EXT] [PATCH] ipsec: remove unneccessary null check
2023-01-13 18:44 [PATCH] ipsec: remove unneccessary null check Stephen Hemminger
` (2 preceding siblings ...)
2023-01-16 23:28 ` Ji, Kai
@ 2023-01-31 8:17 ` Akhil Goyal
3 siblings, 0 replies; 5+ messages in thread
From: Akhil Goyal @ 2023-01-31 8:17 UTC (permalink / raw)
To: Stephen Hemminger, dev; +Cc: kai.ji, Pablo de Lara, Ciara Power
> Subject: [EXT] [PATCH] ipsec: remove unneccessary null check
Changed subject to crypto/ipsec_mb: remove unnecessary null check
Fixed couple of spellings in description and title.
Applied to dpdk-next-crypto
Thanks.
>
> The function rte_ring_free() accepts NULL as vaild input
> like free() and other functions.
>
> Found with null_free_check.cocci.
>
> Fixes: 16d6ebb65d59 ("crypto/ipsec_mb: fix null checks")
> Cc: kai.ji@intel.com
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
> b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
> index 71e02cd0513d..3e52f9567401 100644
> --- a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
> +++ b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
> @@ -139,15 +139,12 @@ int
> ipsec_mb_qp_release(struct rte_cryptodev *dev, uint16_t qp_id)
> {
> struct ipsec_mb_qp *qp = dev->data->queue_pairs[qp_id];
> - struct rte_ring *r = NULL;
>
> if (!qp)
> return 0;
>
> if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
> - r = rte_ring_lookup(qp->name);
> - if (r)
> - rte_ring_free(r);
> + rte_ring_free(rte_ring_lookup(qp->name));
>
> #if IMB_VERSION(1, 1, 0) > IMB_VERSION_NUM
> if (qp->mb_mgr)
> --
> 2.39.0
^ permalink raw reply [flat|nested] 5+ messages in thread