From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 48B941CAF9 for ; Thu, 5 Apr 2018 13:17:26 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Apr 2018 04:17:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,411,1517904000"; d="scan'208";a="39572636" Received: from tanjianf-mobl.ccr.corp.intel.com (HELO [10.255.27.107]) ([10.255.27.107]) by FMSMGA003.fm.intel.com with ESMTP; 05 Apr 2018 04:17:21 -0700 To: "Pattan, Reshma" , "dev@dpdk.org" References: <1520175844-55443-1-git-send-email-jianfeng.tan@intel.com> <1522854488-59678-1-git-send-email-jianfeng.tan@intel.com> <3AEA2BF9852C6F48A459DA490692831F2A2C0302@irsmsx110.ger.corp.intel.com> From: "Tan, Jianfeng" Message-ID: <06200725-4df7-74a0-42eb-7e19d30c5874@intel.com> Date: Thu, 5 Apr 2018 19:17:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A2C0302@irsmsx110.ger.corp.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] pdump: change to use generic multi-process channel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2018 11:17:27 -0000 On 4/5/2018 6:37 PM, Pattan, Reshma wrote: > Hi, > >> -----Original Message----- >> From: Tan, Jianfeng >> Sent: Wednesday, April 4, 2018 4:08 PM >> To: dev@dpdk.org >> Cc: Tan, Jianfeng ; Pattan, Reshma >> >> Subject: [PATCH v2] pdump: change to use generic multi-process channel >> >> The original code replies on the private channel for primary and secondary >> communication. Change to use the generic multi-process channel. >> >> Note with this change, dpdk-pdump will be not compatible with old version >> DPDK applications. >> >> Cc: reshma.pattan@intel.com >> >> Signed-off-by: Jianfeng Tan >> --- >> diff --git a/doc/guides/rel_notes/deprecation.rst >> b/doc/guides/rel_notes/deprecation.rst >> index 0c696f7..d55fd05 100644 >> --- a/doc/guides/rel_notes/deprecation.rst >> +++ b/doc/guides/rel_notes/deprecation.rst >> @@ -153,3 +153,7 @@ Deprecation Notices >> be added between the producer and consumer structures. The size of the >> structure and the offset of the fields will remain the same on >> platforms with 64B cache line, but will change on other platforms. >> + >> +* pdump: As we changed to use generic IPC, ``rte_pdump_set_socket_dir`` >> +will be >> + deprecated and removed in subsequent release; the parameter, path, of >> + ``rte_pdump_init`` will also be removed. > Do we need to mention about deprecation of below enums too? > enum rte_pdump_socktype { > RTE_PDUMP_SOCKET_SERVER = 1, > RTE_PDUMP_SOCKET_CLIENT = 2 > }; Nice catch, will add in next version. Thanks, Jianfeng > > Thanks, > Reshma