From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B2AAA0C55; Wed, 13 Oct 2021 13:29:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A97AC410DA; Wed, 13 Oct 2021 13:29:33 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 891F840E64 for ; Wed, 13 Oct 2021 13:29:32 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10135"; a="313604527" X-IronPort-AV: E=Sophos;i="5.85,370,1624345200"; d="scan'208";a="313604527" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 04:29:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,370,1624345200"; d="scan'208";a="717306451" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga005.fm.intel.com with ESMTP; 13 Oct 2021 04:29:31 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 04:29:31 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 04:29:30 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 13 Oct 2021 04:29:30 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.177) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 13 Oct 2021 04:29:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AWiFsS3HySSTiPNBG3hWLQWpySyuUCcCoTxA/clPlww2WwVman5O6OGqMVj5DZlzwmTIe+VdMV7jd50KYrsd70gv97yF/gQgrQArr2RP2f/x0aB/FZySBtnAoegVIRAqn9sLVfFaCNMm/49tosc91TApr0Dz8knbQmHsjvinLJFywJXLzv6zMaY15x4lmtN7iPbI7XAvjjU3BmaMCCjipV2v/80YhEAy779kdSqgXPi0i22cFQKl5I55J8cI7shxr4bJmuxpNchRhOxAXgLdssx+rUPwBcCHbYq1rmnoqU4WOVLUAT+zpSJYvTgq5j6i4TPFqO88BgJMeFFgXQXrZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=baIIEZzWJ4VtjxQ0GeBYnXr8qSOX6jmDQlweLgcfAHQ=; b=Yz+23ZqL/lf12aVQn+Qdlx0C0es+GXwO+U65JvYd+alQX83WP7Fo1RhP/APkEkMNbtxrbm6FfU18+G8Mggm9hMggs+BMM0xFqQKulX9lu/uhFITilBSJpzylHduxQsAKStvZsM4iqggsl1CA7PDQAIvUT3KU4Dydzw5AZz8hz5Ja9lYR4cmVtBQfTp6rGIDQ+SGVRUlMO5Nsnu5bbyySJ5MZCY4uIRyE817i8ijGgUu53Vx1AMPJkpOZh4PYrpGM7FFrtj+z+lnKyqq0YLUOHjw/MIWVq8P51b4beExB7VMalWMYpvpn87Liaqm/bJJCxp1Vy83Rvs4OhKPEKYHPTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=baIIEZzWJ4VtjxQ0GeBYnXr8qSOX6jmDQlweLgcfAHQ=; b=HXwziMIBLYDyNTZ5NtbX+XnjUcecT8mQKI/Ph91vj7RMeGKSjdeOCQSU8akJ/qOb7VY+UXfl60Fxvg3XwEe2Pg0H9vKXFNn/X28LkWaz6o99/B5E8OF7NOwu8MysB5Kw0g6R35rEsYJjkI9NZa69IHyF2BkOhpHTgkcVLQ96Cb8= Authentication-Results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5176.namprd11.prod.outlook.com (2603:10b6:510:3f::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24; Wed, 13 Oct 2021 11:29:29 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4608.016; Wed, 13 Oct 2021 11:29:29 +0000 Message-ID: <062cd66f-a5ef-ee83-fe33-00507262b989@intel.com> Date: Wed, 13 Oct 2021 12:29:23 +0100 Content-Language: en-US To: Thomas Monjalon , CC: Andrew Rybchenko , Ori Kam References: <20210915210444.3126008-1-thomas@monjalon.net> <20211013075236.3833915-1-thomas@monjalon.net> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211013075236.3833915-1-thomas@monjalon.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB8PR09CA0006.eurprd09.prod.outlook.com (2603:10a6:10:a0::19) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB8PR09CA0006.eurprd09.prod.outlook.com (2603:10a6:10:a0::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend Transport; Wed, 13 Oct 2021 11:29:28 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b6a70510-501c-4c2c-4715-08d98e3cb8a0 X-MS-TrafficTypeDiagnostic: PH0PR11MB5176: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EraD0TULkhXWoz6T4mgxVmVkRZJwigtHWrm3+PFO1eMTJPL2Q+fyJQ1KO1b9o9dMpTDG8Z4EvScxZYj0oQyZctHJW67DR8DPEJcthDr3yKfapXWvfKhkLsWw92AIkm4mwNEqGYfP1kCTB4l49CU3WyxNo/qA0SWohc6h51WNnD7gfWdcSvuXSi/DEMRSVLME9N++vEkU1gMcNt15djdulU28PpN7YUgfdlBJRKpTJGnd7JIPxB6LSMarcJfrcf0TuhMSoNn2I/6FLa4jHcqsLkmAYjOaFOxLKDuSHnmvI0E6pEUJrqYHW44UEmCaIhzzw8w/pb0PuOYakCAPrDnA11E8uZHSO1s5qjSs75Osp4dvLfKDZaiT/2nZ6Yu4Vw/EwCf7nfTdn5Kp6PSQhf6qy+HiVsQT+RYNYmzLyXO7j3l9xTv0QxqoBrZpJ3NL4S0Erdi7gpOuy+CnsJPxuGFXIMNFowrCgCnhCTNb2utoGImBlezyoOksA59iq5S+lVUMian42d7gGOqzr26fuN2lznN/qkXyTcTPKo3jIEr5g9mdTUZ0E55SebOfqU4hoV/yFGjRRYq9/AriuNMcTYoGW0sy3N16Nudw4OfAP0o1RNrPr0i9CypijMl0gMye5AtVN6OPkX5RgzG0GUremMvJWvyvXXvMUNC/tcX9non5BgI4q6FhdE4CTfyi0CznxhanuWh0wslsH+5VVnZR1PGk0g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6666004)(66946007)(4744005)(83380400001)(36756003)(31696002)(31686004)(8676002)(5660300002)(186003)(66556008)(86362001)(53546011)(66476007)(508600001)(6486002)(26005)(2906002)(54906003)(16576012)(8936002)(44832011)(82960400001)(38100700002)(956004)(316002)(4326008)(2616005)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWNDbFU5Qy9pYnJsc24xay9IblNINEFWUW82bVRPdzdsbk9INExpV2Y0TnBR?= =?utf-8?B?SmVzbUZkejZRSUhXZTlQSmdHY2R4YVVyek1Qa0dNa2Rvby9oZUdkT2h4ejBs?= =?utf-8?B?QTRYUDlZTk5oVldpaTl1dW1lcFo0aSswV2l0S252TkF3a0xhamF2K09FQmNB?= =?utf-8?B?UHJVVGFCN3o3QnhKVDh1TklQUWY1ZzhCS3kxa09pY0QyVnhRa0RQZ3pvaC9t?= =?utf-8?B?M3JHV1ZRUjB3RnROdDdFWFJ5eXFVd2pkQUFyKzRpL0tDek10WUovMnpLM1E3?= =?utf-8?B?bzdXZFZBL2hZWkFESitQMFhMWkszTHFKT3lReWJ1R215WWRQM29TWXk4NTFH?= =?utf-8?B?SytWaUpjUTRsYnpQSFl4Z2JlWmM2SXhuVmJSc0N6ajQ5T3RZb2lGTEJHcEZQ?= =?utf-8?B?YnlCM1Z5U3YyOGtEZzU3MkllTDVkNXg3Ky9hVWRyTFZxNVNONnR2ZEMvWGlo?= =?utf-8?B?ZkwxMWJDRWNCZ29XbXRQQXNGVTZkRGlvb0FDbjhWbkhNaHlpTDF5L3VyeVVG?= =?utf-8?B?NEpLeHROa2t4TE1Ba1B5MnBEMmtVZm5Xdm5CVHJaVnJjSEhxNW9FaFV5ZmNj?= =?utf-8?B?Yy9kTy95ZG1MVmlWUEhqaHZML0d6Q093YTIrelRDRVNKTU1DM3h0ZmRVdi9x?= =?utf-8?B?RmlLNzJ1anZ3K0xscjgrV1hORGJldDBzRDBrY0s4T0lXWkFKK09EV1oyZ0xZ?= =?utf-8?B?QjlTNWoxODdUcnNtZlVmTzFoVGpxQXQ4RjdCT1ZkOHJjdXR5K2MvS2ZYbjlK?= =?utf-8?B?VzNGV2V1aHoxQWNiMHFqSGlYTWJXNC85WlI1UHpKc3RNQkltSDZXanh1TDVl?= =?utf-8?B?TVovTDBmQ0FqWlJXVTFVMnVFcW9DaFZsL05kMGNQZStOelQrNnJ3UFY2cEdO?= =?utf-8?B?R3FRaGhEeUxTeHNraDV4Ky9zWDN5SndGS0pvbktGSUdJS0M1dTdBUVdtcGln?= =?utf-8?B?dHFFZEJVcWNZTWxqS0x1MDlPUGFiclM5ZmVoQTJBOTkrWGNhT1o3bGhhT3VM?= =?utf-8?B?dUxNTDVFc3RZakZPZklQR3lWdjBrOW9NTFhQMlBvZ3ora1BKa0hQZklFc2ts?= =?utf-8?B?ZUs5NEtJYjdocEhtbmh4QTJyMzVBVzlieFBWcjVlcHJGaW5hVXRZcEZ6Q0ph?= =?utf-8?B?c3JRR3prODZhbGQrOTNoNytaS2NGRi9PQmZzSDZnNHFPaHA2ZEJYUTVTeDZC?= =?utf-8?B?MWxtUk5JNmpoWDh4WVpGSHNBL3NidW9ueXBhd2hMUW9Fc2tKdVM4Vkd1TzVM?= =?utf-8?B?U0FqcmlBYTNaRjhjVTJsVTNiTkJvaHJENENDMjg1VVFWRjlTbHRFUnMySCts?= =?utf-8?B?U3VpWGwrUjcxNW5UTjM1cy9acmVjeUxMcm1lOStMVjRXbG1EVmJrMTNZNS9y?= =?utf-8?B?MDg5RG1RL00xMHRFL3BRWXpBRWRCSWlkcnczRXNiNmg0MCtRTkJmMTEveENu?= =?utf-8?B?eVd0QmM5WWY5WWg0NkFOR1NuVHJ3RC84Ykx5cjZPNngxS1lrMlFpQTYyT3Bt?= =?utf-8?B?M09Qc001cVl6d2NoaFE2b2Uzd1doNlYwT3Y4K0p2S01aaDdaQkYzSEJHQ0Rq?= =?utf-8?B?WHNZRWhBR2dxSG5qQWU2OUdadFpuYUVSRzdCaFU0MHJERXZVMWFlRlJ2WUE5?= =?utf-8?B?V3FyRDEwUzJPNlJmbk1DZnBGbllZeTA4TGtCeGdxcElmS0J3UlpqdnlhbHBQ?= =?utf-8?B?d2FJOUl4YXJKcW1SNUNndGU2aUc1eHBsUnYwL1BkSlQ2TkIzaW5EeGsyd2hV?= =?utf-8?Q?znTU220DxR+GV8FhO254VYltBudbXIG8BJc+DvU?= X-MS-Exchange-CrossTenant-Network-Message-Id: b6a70510-501c-4c2c-4715-08d98e3cb8a0 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 11:29:29.8599 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5uibHGxwAswI6MxrSE5FqH7Gxok7hUgJA5AdVXshCsBaGh/YTNUQLBvD+W9VMnXuvqpG17pv9H5hCoadLMczSw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5176 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v5] ethdev: replace bit shifts with macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/13/2021 8:52 AM, Thomas Monjalon wrote: > The macros RTE_BIT32 and RTE_BIT64 are used to replace bit shifts. > The macro UINT64C is also used to replace remaining occurrences of ULL. > > The bit shifts of ETH_RSS_LEVEL_* are kept for aesthetic reason. > > The API of rte_mtr and rte_tm is using enums for 64-bit variables. > As they are enums, unsigned bit cannot be used. > > Signed-off-by: Thomas Monjalon > Reviewed-by: Andrew Rybchenko > --- > v2: use RTE_BIT32 in enums > v3: rebase on main > v4: keep enums untouched > v5: convert new flag ETH_RSS_L4_CHKSUM Hi Thomas, Thanks for the update, but a recent commit [1] in ethdev is added a few more '<<', can you please rebase on the latest next-net. [1] Commit c4f4884b654b ("ethdev: negotiate delivery of packet metadata from HW to PMD")