From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6B13A04E7; Wed, 4 Nov 2020 10:49:31 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0E941C88E; Wed, 4 Nov 2020 10:49:30 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 5D31EC884 for ; Wed, 4 Nov 2020 10:49:26 +0100 (CET) IronPort-SDR: HxAJyrDIZVZOIJHkPGvpaCd4Wvi2tcl5TRdXt529POd6c+tdEBtjh01/xJHVvhHEePBcQHKKxY 5nIhvJb9BM4g== X-IronPort-AV: E=McAfee;i="6000,8403,9794"; a="148468534" X-IronPort-AV: E=Sophos;i="5.77,450,1596524400"; d="scan'208";a="148468534" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2020 01:49:24 -0800 IronPort-SDR: PgRBDGO7+kuwLkdUH19VzTtUnAJ42X5e/s/LHEMFZgKHAk+ESPtXZepPGBo0I8ZV+fsLZwcRiA Mr3O3EY5RSrQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,450,1596524400"; d="scan'208";a="306356965" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga007.fm.intel.com with ESMTP; 04 Nov 2020 01:49:24 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 4 Nov 2020 01:49:23 -0800 Received: from shsmsx605.ccr.corp.intel.com (10.109.6.215) by SHSMSX601.ccr.corp.intel.com (10.109.6.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 4 Nov 2020 17:49:21 +0800 Received: from shsmsx605.ccr.corp.intel.com ([10.109.6.215]) by SHSMSX605.ccr.corp.intel.com ([10.109.6.215]) with mapi id 15.01.1713.004; Wed, 4 Nov 2020 17:49:21 +0800 From: "Di, ChenxuX" To: "Guo, Jia" , "dev@dpdk.org" CC: "Xing, Beilei" , "Wang, Haiyue" Thread-Topic: [PATCH 1/2] net/i40e: fix incorrect FDIR flex mask Thread-Index: AQHWsoa+o2P8WHzWc0y4uZL+VTUg9Km3MeqAgACIV7A= Date: Wed, 4 Nov 2020 09:49:21 +0000 Message-ID: <0655e6d1fbbc4b6883ede31c832c7766@intel.com> References: <20201104082959.63800-1-chenxux.di@intel.com> <20201104082959.63800-2-chenxux.di@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix incorrect FDIR flex mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Jia > -----Original Message----- > From: Guo, Jia > Sent: Wednesday, November 4, 2020 5:41 PM > To: Di, ChenxuX ; dev@dpdk.org > Cc: Xing, Beilei ; Wang, Haiyue > ; Di, ChenxuX ; > stable@dpdk.org > Subject: RE: [PATCH 1/2] net/i40e: fix incorrect FDIR flex mask >=20 > Hi, chenxu >=20 > > -----Original Message----- > > From: Chenxu Di > > Sent: Wednesday, November 4, 2020 4:30 PM > > To: dev@dpdk.org > > Cc: Xing, Beilei ; Guo, Jia > > ; Wang, Haiyue ; Di, ChenxuX > > ; stable@dpdk.org > > Subject: [PATCH 1/2] net/i40e: fix incorrect FDIR flex mask > > > > The register of FDIR flex mask should not be set during flow validate. > > It should be set when flow create. > > > > Fixes: 6ced3dd72f5f ("net/i40e: support flexible payload parsing for > > FDIR") >=20 > Seems that you move the place of flexible payload parsing from flow valid= ate to > create, you delete something but miss some useless parameter deleting, su= ch as > " off_arr/len_arr" etc in this [PATCH 1/2] or [PATCH 2/3]. Please double = check if > anything related remove and if you want you could merge into 1 remove pat= ch if > it could be. >=20 Got it, I will double check it. > > Cc: stable@dpdk.org > > > > Signed-off-by: Chenxu Di > > --- > > drivers/net/i40e/i40e_ethdev.h | 1 + > > drivers/net/i40e/i40e_fdir.c | 94 ++++++++++++++++++++++++++++++++ > > drivers/net/i40e/i40e_flow.c | 97 +--------------------------------- > > 3 files changed, 97 insertions(+), 95 deletions(-) > > >=20 > <...>