From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CFB1AA0546; Mon, 8 Mar 2021 11:42:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5ED324068A; Mon, 8 Mar 2021 11:42:22 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 83D6640141 for ; Mon, 8 Mar 2021 11:42:20 +0100 (CET) IronPort-SDR: 2BiGTE3xsPQ7KzyCrTdQQ8BXvLerKh38YM0oDWO6qgmoD9snZMSYnUozSBk4QLfC3smUcTw3Cy cOmFNJzG64HQ== X-IronPort-AV: E=McAfee;i="6000,8403,9916"; a="185617802" X-IronPort-AV: E=Sophos;i="5.81,232,1610438400"; d="scan'208";a="185617802" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2021 02:42:19 -0800 IronPort-SDR: AaiEgFejYD296T/lvzZSyLu6lqs3FVgN/REJyc468zuv8wQRvVtEQ0af4dxYPv28SLd8PGYH9C WdF7OK+Fhpog== X-IronPort-AV: E=Sophos;i="5.81,232,1610438400"; d="scan'208";a="409251287" Received: from vmedvedk-mobl.ger.corp.intel.com (HELO [10.214.231.108]) ([10.214.231.108]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2021 02:42:16 -0800 To: "Walsh, Conor" , "jerinj@marvell.com" , "stephen@networkplumber.org" , "Iremonger, Bernard" , "Ananyev, Konstantin" Cc: "dev@dpdk.org" References: <20210218152056.1893590-1-conor.walsh@intel.com> <20210219150945.2071651-1-conor.walsh@intel.com> <20210219150945.2071651-2-conor.walsh@intel.com> From: "Medvedkin, Vladimir" Message-ID: <066f0759-15a7-ef50-f28e-b936d8b821b4@intel.com> Date: Mon, 8 Mar 2021 10:41:56 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210219150945.2071651-2-conor.walsh@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/5] examples/l3fwd: fix LPM IPv6 subnets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 19/02/2021 15:09, Walsh, Conor wrote: > The IPv6 subnets used were not within the 2001:200::/48 subnet > Changed to 2001:200:0:{0-7}::/64 where 0-7 is the port ID > > Fixes: 37afe381bde4 ("examples/l3fwd: use reserved IP addresses") > > Signed-off-by: Conor Walsh > --- > examples/l3fwd/l3fwd_lpm.c | 26 ++++++++++++++++---------- > 1 file changed, 16 insertions(+), 10 deletions(-) > > diff --git a/examples/l3fwd/l3fwd_lpm.c b/examples/l3fwd/l3fwd_lpm.c > index 3dcf1fef18..1cfaf36572 100644 > --- a/examples/l3fwd/l3fwd_lpm.c > +++ b/examples/l3fwd/l3fwd_lpm.c > @@ -42,7 +42,10 @@ struct ipv6_l3fwd_lpm_route { > uint8_t if_out; > }; > > -/* 198.18.0.0/16 are set aside for RFC2544 benchmarking (RFC5735). */ > +/* > + * 198.18.0.0/16 are set aside for RFC2544 benchmarking (RFC5735). > + * 198.18.{0-7}.0/24 = Port {0-7} > + */ > static const struct ipv4_l3fwd_lpm_route ipv4_l3fwd_lpm_route_array[] = { > {RTE_IPV4(198, 18, 0, 0), 24, 0}, > {RTE_IPV4(198, 18, 1, 0), 24, 1}, > @@ -54,16 +57,19 @@ static const struct ipv4_l3fwd_lpm_route ipv4_l3fwd_lpm_route_array[] = { > {RTE_IPV4(198, 18, 7, 0), 24, 7}, > }; > > -/* 2001:0200::/48 is IANA reserved range for IPv6 benchmarking (RFC5180) */ > +/* > + * 2001:200::/48 is IANA reserved range for IPv6 benchmarking (RFC5180). > + * 2001:200:0:{0-7}::/64 = Port {0-7} > + */ > static const struct ipv6_l3fwd_lpm_route ipv6_l3fwd_lpm_route_array[] = { > -{{32, 1, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}, 48, 0}, > -{{32, 1, 2, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0}, 48, 1}, > -{{32, 1, 2, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0}, 48, 2}, > -{{32, 1, 2, 0, 0, 0, 0, 0, 0, 3, 0, 0, 0, 0, 0, 0}, 48, 3}, > -{{32, 1, 2, 0, 0, 0, 0, 0, 0, 4, 0, 0, 0, 0, 0, 0}, 48, 4}, > -{{32, 1, 2, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0}, 48, 5}, > -{{32, 1, 2, 0, 0, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0}, 48, 6}, > -{{32, 1, 2, 0, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0}, 48, 7}, > +{{32, 1, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}, 64, 0}, > +{{32, 1, 2, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0}, 64, 1}, > +{{32, 1, 2, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0}, 64, 2}, > +{{32, 1, 2, 0, 0, 0, 0, 3, 0, 0, 0, 0, 0, 0, 0, 0}, 64, 3}, > +{{32, 1, 2, 0, 0, 0, 0, 4, 0, 0, 0, 0, 0, 0, 0, 0}, 64, 4}, > +{{32, 1, 2, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0, 0}, 64, 5}, > +{{32, 1, 2, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0, 0, 0}, 64, 6}, > +{{32, 1, 2, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0, 0}, 64, 7}, > }; > > #define IPV4_L3FWD_LPM_MAX_RULES 1024 > -- > 2.25.1 > Acked-by: Vladimir Medvedkin -- Regards, Vladimir