* [dpdk-dev] [PATCH] net/i40e: fix link update delay
@ 2017-02-08 9:14 Qiming Yang
2017-02-08 15:30 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Qiming Yang @ 2017-02-08 9:14 UTC (permalink / raw)
To: dev; +Cc: jingjing.wu, cunming.liang, Qiming Yang
This patch fixed the redundant delay in function link update. There is
no need to call rte_delay_ms and hold CPU for 100ms when link status is up.
Fixes: 263333bbb7a9 ("i40e: fix link status timeout")
Signed-off-by: Qiming Yang <qiming.yang@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 4492bcc..75d092f 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -2220,11 +2220,11 @@ i40e_dev_link_update(struct rte_eth_dev *dev,
}
link.link_status = link_status.link_info & I40E_AQ_LINK_UP;
- if (!wait_to_complete)
+ if (!wait_to_complete || link.link_status)
break;
rte_delay_ms(CHECK_INTERVAL);
- } while (!link.link_status && rep_cnt--);
+ } while (--rep_cnt);
if (!link.link_status)
goto out;
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix link update delay
2017-02-08 9:14 [dpdk-dev] [PATCH] net/i40e: fix link update delay Qiming Yang
@ 2017-02-08 15:30 ` Ferruh Yigit
2017-02-08 15:37 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2017-02-08 15:30 UTC (permalink / raw)
To: Qiming Yang, dev; +Cc: jingjing.wu, cunming.liang
On 2/8/2017 9:14 AM, Qiming Yang wrote:
> This patch fixed the redundant delay in function link update. There is
> no need to call rte_delay_ms and hold CPU for 100ms when link status is up.
>
> Fixes: 263333bbb7a9 ("i40e: fix link status timeout")
>
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix link update delay
2017-02-08 15:30 ` Ferruh Yigit
@ 2017-02-08 15:37 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-02-08 15:37 UTC (permalink / raw)
To: Qiming Yang, dev; +Cc: jingjing.wu, cunming.liang
On 2/8/2017 3:30 PM, Ferruh Yigit wrote:
> On 2/8/2017 9:14 AM, Qiming Yang wrote:
>> This patch fixed the redundant delay in function link update. There is
>> no need to call rte_delay_ms and hold CPU for 100ms when link status is up.
>>
>> Fixes: 263333bbb7a9 ("i40e: fix link status timeout")
>>
>> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-08 15:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-08 9:14 [dpdk-dev] [PATCH] net/i40e: fix link update delay Qiming Yang
2017-02-08 15:30 ` Ferruh Yigit
2017-02-08 15:37 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).