From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 239DE11D9; Mon, 9 Jan 2017 09:05:49 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 09 Jan 2017 00:05:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,339,1477983600"; d="scan'208";a="1080785842" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga001.jf.intel.com with ESMTP; 09 Jan 2017 00:05:48 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 9 Jan 2017 00:05:48 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 9 Jan 2017 00:05:48 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.177]) by shsmsx102.ccr.corp.intel.com ([169.254.2.88]) with mapi id 14.03.0248.002; Mon, 9 Jan 2017 16:05:45 +0800 From: "Wei, FangfangX" To: "Xu, Qian Q" , Yuanhan Liu , Stephen Hemminger CC: "dev@dpdk.org" , "stable@dpdk.org" , "Liu, Yong" Thread-Topic: [dpdk-dev] [PATCH v3 2/6] net/virtio: fix wrong Rx/Tx method for secondary process Thread-Index: AQHSagUc3Zwen2ApvkWoX5j9/MJWe6EvFbSAgACx1XCAAAKT8A== Date: Mon, 9 Jan 2017 08:05:44 +0000 Message-ID: <067B569323FEB248B5CB480E1954F4346E9F8841@SHSMSX101.ccr.corp.intel.com> References: <1482922962-21036-1-git-send-email-yuanhan.liu@linux.intel.com> <1483697780-12088-1-git-send-email-yuanhan.liu@linux.intel.com> <1483697780-12088-3-git-send-email-yuanhan.liu@linux.intel.com> <20170108151500.3272484c@xeon-e3> <20170109051919.GB21228@yliu-dev.sh.intel.com> <82F45D86ADE5454A95A89742C8D1410E3B4D643B@shsmsx102.ccr.corp.intel.com> In-Reply-To: <82F45D86ADE5454A95A89742C8D1410E3B4D643B@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTQ1N2M0ZDQtNWVjZS00OTUyLWE3NmYtZjRiNDE4ZjM5NjAwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Im05RGlnWjk2Tng5NmpwbnJwQVA3ajB2YmtTOEJkaDhlMWpRQ2pWZThGMnc9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 2/6] net/virtio: fix wrong Rx/Tx method for secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2017 08:05:51 -0000 I've re-build it manually, it passed with this patch. -----Original Message----- From: Xu, Qian Q=20 Sent: Monday, January 9, 2017 4:02 PM To: Yuanhan Liu ; Stephen Hemminger ; Wei, FangfangX Cc: dev@dpdk.org; stable@dpdk.org; Liu, Yong Subject: RE: [dpdk-dev] [PATCH v3 2/6] net/virtio: fix wrong Rx/Tx method f= or secondary process Fangfang, Could you help double confirm below error and the patchset ? Thanks.=20 http://dpdk.org/patch/18975 > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Monday, January 9, 2017 1:19 PM > To: Stephen Hemminger > Cc: dev@dpdk.org; stable@dpdk.org; Xu, Qian Q ;=20 > Liu, Yong > Subject: Re: [dpdk-dev] [PATCH v3 2/6] net/virtio: fix wrong Rx/Tx=20 > method for secondary process >=20 > On Sun, Jan 08, 2017 at 03:15:00PM -0800, Stephen Hemminger wrote: > > On Fri, 6 Jan 2017 18:16:16 +0800 > > Yuanhan Liu wrote: > > > > > If the primary enables the vector Rx/Tx path, the current code=20 > > > would let the secondary always choose the non vector Rx/Tx path.=20 > > > This results to a Rx/Tx method mismatch between primary and=20 > > > secondary process. Werid errors then may happen, something like: > > > > > > PMD: virtio_xmit_pkts() tx: virtqueue_enqueue error: -14 > > > > > > Fix it by choosing the correct Rx/Tx callbacks for the secondary proc= ess. > > > That is, use vector path if it's given. > > > > > > Fixes: 8d8393fb1861 ("virtio: pick simple Rx/Tx") > > > > > > Cc: stable@dpdk.org > > > Signed-off-by: Yuanhan Liu > > > > This is failing on intel compile tests. > > > > > > http://dpdk.org/patch/18975 >=20 > Thanks, but it looks like a false alarm to me, for reasons below. >=20 > > Failed Build #2: > > OS: RHEL7.2_64 > > Target: x86_64-native-linuxapp-gcc > > MKRES test_resource_c.res.o /home/patchWorkOrg/compilation/x86_64- > native-linuxapp-gcc/lib/librte_ethdev.a(rte_ethdev.o): In function > `rte_eth_dev_pci_probe': > > rte_ethdev.c:(.text+0x9c4): undefined reference to > `eth_dev_attach_secondary' > > collect2: error: ld returned 1 exit status >=20 > - eth_dev_attach_secondary is not defined in this patch, it's defined > (and used) in the first patch. >=20 > - eth_dev_attach_secondary is actually defined; The report even shows > it fails to build with gcc: the gcc build passes on my dev box. >=20 > Honestly, I seldom trusted the build reports from STV. >=20 > --yliu