* [dpdk-dev] [PATCH] net/bonding: validate bonded port id before access its data
@ 2017-07-31 3:24 Herbert Guan
2017-07-31 9:59 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Herbert Guan @ 2017-07-31 3:24 UTC (permalink / raw)
To: dev; +Cc: Herbert Guan
Fixes: 4c42498d916d ("net/bonding: allow slaves to also be bonded devices")
Signed-off-by: Herbert Guan <herbert.guan@arm.com>
---
drivers/net/bonding/rte_eth_bond_api.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c
index 824ab4f..6039500 100644
--- a/drivers/net/bonding/rte_eth_bond_api.c
+++ b/drivers/net/bonding/rte_eth_bond_api.c
@@ -514,11 +514,11 @@
{
struct bond_dev_private *internals;
- internals = rte_eth_devices[bonded_port_id].data->dev_private;
-
if (valid_bonded_port_id(bonded_port_id) != 0)
return -1;
+ internals = rte_eth_devices[bonded_port_id].data->dev_private;
+
if (valid_slave_port_id(slave_port_id, internals->mode) != 0)
return -1;
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/bonding: validate bonded port id before access its data
2017-07-31 3:24 [dpdk-dev] [PATCH] net/bonding: validate bonded port id before access its data Herbert Guan
@ 2017-07-31 9:59 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2017-07-31 9:59 UTC (permalink / raw)
To: Herbert Guan, dev
On 7/31/2017 4:24 AM, Herbert Guan wrote:
> Fixes: 4c42498d916d ("net/bonding: allow slaves to also be bonded devices")
>
> Signed-off-by: Herbert Guan <herbert.guan@arm.com>
Thanks for the patch, this looks like duplicate [1], I will get the
other one since it has been sent earlier.
[1]
http://dpdk.org/dev/patchwork/patch/27225/
Thanks,
ferruh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-31 9:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-31 3:24 [dpdk-dev] [PATCH] net/bonding: validate bonded port id before access its data Herbert Guan
2017-07-31 9:59 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).