DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Beilei Xing <beilei.xing@intel.com>, jingjing.wu@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix tunnel filter issue
Date: Tue, 7 Feb 2017 14:11:15 +0000	[thread overview]
Message-ID: <068de103-393e-7192-c230-e912494d96a2@intel.com> (raw)
In-Reply-To: <1486371167-36839-1-git-send-email-beilei.xing@intel.com>

On 2/6/2017 8:52 AM, Beilei Xing wrote:
> Creating IPv4 flow and IPv6 flow will cause confilct error.
> Root cause is there's no IP info included in tunnel filter
> input.
> 
> Fixes: 425c3325f0b0 ("net/i40e: store tunnel filter")
> Fixes: d416530e6358 ("net/i40e: parse tunnel filter")
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>

<...>

> +enum i40e_tunnel_iptype {
> +	I40E_TUNNEL_IPTYPE_IPV4 = 0, /* IPv4. */

No need to assign the value, it will be already zero. And comments are
not adding something new.
Since these are minor issues, I can update while applying.

> +	I40E_TUNNEL_IPTYPE_IPV6,     /* IPv6. */
> +};
> +
<...>

  reply	other threads:[~2017-02-07 14:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-06  8:52 Beilei Xing
2017-02-07 14:11 ` Ferruh Yigit [this message]
2017-02-07 14:12 ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=068de103-393e-7192-c230-e912494d96a2@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).