From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 734EC376C
 for <dev@dpdk.org>; Tue,  7 Feb 2017 15:11:18 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga105.fm.intel.com with ESMTP; 07 Feb 2017 06:11:17 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,346,1477983600"; d="scan'208";a="818060208"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.137])
 ([10.237.220.137])
 by FMSMGA003.fm.intel.com with ESMTP; 07 Feb 2017 06:11:16 -0800
To: Beilei Xing <beilei.xing@intel.com>, jingjing.wu@intel.com
References: <1486371167-36839-1-git-send-email-beilei.xing@intel.com>
Cc: dev@dpdk.org
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <068de103-393e-7192-c230-e912494d96a2@intel.com>
Date: Tue, 7 Feb 2017 14:11:15 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <1486371167-36839-1-git-send-email-beilei.xing@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix tunnel filter issue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Feb 2017 14:11:18 -0000

On 2/6/2017 8:52 AM, Beilei Xing wrote:
> Creating IPv4 flow and IPv6 flow will cause confilct error.
> Root cause is there's no IP info included in tunnel filter
> input.
> 
> Fixes: 425c3325f0b0 ("net/i40e: store tunnel filter")
> Fixes: d416530e6358 ("net/i40e: parse tunnel filter")
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>

<...>

> +enum i40e_tunnel_iptype {
> +	I40E_TUNNEL_IPTYPE_IPV4 = 0, /* IPv4. */

No need to assign the value, it will be already zero. And comments are
not adding something new.
Since these are minor issues, I can update while applying.

> +	I40E_TUNNEL_IPTYPE_IPV6,     /* IPv6. */
> +};
> +
<...>