DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ilya Maximets <i.maximets@samsung.com>
To: Changpeng Liu <changpeng.liu@intel.com>, dev@dpdk.org
Cc: dariusz.stojaczyk@intel.com, maxime.coquelin@redhat.com,
	tiwei.bie@intel.com, zhihong.wang@intel.com,
	Jason Wang <jasowang@redhat.com>
Subject: Re: [dpdk-dev] vhost: add virtio configuration space access socket messages
Date: Mon, 25 Feb 2019 16:53:26 +0300	[thread overview]
Message-ID: <06988862-778e-3ab4-880b-0dfb35fc4d4e@samsung.com> (raw)
In-Reply-To: <1551081095-14286-1-git-send-email-changpeng.liu@intel.com>

On 25.02.2019 10:51, Changpeng Liu wrote:
> This patch adds new vhost user messages GET_CONFIG and SET_CONFIG
> used to get/set virtio device's PCI configuration space.
> 
> Signed-off-by: Changpeng Liu <changpeng.liu@intel.com>
> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
> ---
>  lib/librte_vhost/rte_vhost.h  |  8 ++++++++
>  lib/librte_vhost/vhost_user.c | 44 +++++++++++++++++++++++++++++++++++++++++++
>  lib/librte_vhost/vhost_user.h | 16 ++++++++++++++++
>  3 files changed, 68 insertions(+)
> 
> diff --git a/lib/librte_vhost/rte_vhost.h b/lib/librte_vhost/rte_vhost.h
> index 2753670..ab710ce 100644
> --- a/lib/librte_vhost/rte_vhost.h
> +++ b/lib/librte_vhost/rte_vhost.h
> @@ -63,6 +63,10 @@
>  #define VHOST_USER_PROTOCOL_F_PAGEFAULT 8
>  #endif
>  
> +#ifndef VHOST_USER_PROTOCOL_F_CONFIG
> +#define VHOST_USER_PROTOCOL_F_CONFIG 9
> +#endif
> +
>  #ifndef VHOST_USER_PROTOCOL_F_SLAVE_SEND_FD
>  #define VHOST_USER_PROTOCOL_F_SLAVE_SEND_FD 10
>  #endif
> @@ -173,6 +177,10 @@ struct vhost_device_ops {
>  
>  	int (*vring_state_changed)(int vid, uint16_t queue_id, int enable);	/**< triggered when a vring is enabled or disabled */
>  
> +	int (*get_config)(int vid, uint8_t *config, uint32_t config_len);
> +	int (*set_config)(int vid, uint8_t *config, uint32_t offset,
> +			  uint32_t len, uint32_t flags);

'struct vhost_device_ops' is user visible. This changes API and ABI.
You need to update docs/rel_notes and bump the library version accordingly.

Best regards, Ilya Maximets.

  parent reply	other threads:[~2019-02-25 13:53 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-25  7:51 [dpdk-dev] [PATCH] " Changpeng Liu
2019-02-25  7:48 ` Jason Wang
2019-02-25 11:49   ` Stojaczyk, Dariusz
2019-02-25 12:05 ` Stojaczyk, Dariusz
     [not found] ` <CGME20190225132001eucas1p25c1e925b895b3ab36da0aca27110e15c@eucas1p2.samsung.com>
2019-02-25 13:19   ` [dpdk-dev] " Ilya Maximets
2019-02-26  7:01     ` Liu, Changpeng
2019-02-26  7:39       ` Ilya Maximets
2019-02-26  8:13         ` Liu, Changpeng
2019-02-26  8:42           ` Ilya Maximets
2019-02-26 12:32             ` Maxime Coquelin
2019-02-26 13:36               ` Ilya Maximets
2019-02-26 13:43                 ` Maxime Coquelin
2019-02-26 14:07                   ` Ilya Maximets
2019-02-27  9:04                     ` Maxime Coquelin
2019-02-27 11:48                       ` Ilya Maximets
2019-02-27  1:31               ` Liu, Changpeng
2019-02-27  9:12                 ` Maxime Coquelin
2019-02-27  9:50                   ` Liu, Changpeng
2019-02-27 10:04                     ` Maxime Coquelin
2019-02-28 12:49                       ` Liu, Changpeng
2019-02-27  1:41               ` Tiwei Bie
     [not found] ` <CGME20190225135328eucas1p1560252488ef0f0db87f0509d2bb7813c@eucas1p1.samsung.com>
2019-02-25 13:53   ` Ilya Maximets [this message]
2019-02-26  7:02     ` Liu, Changpeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06988862-778e-3ab4-880b-0dfb35fc4d4e@samsung.com \
    --to=i.maximets@samsung.com \
    --cc=changpeng.liu@intel.com \
    --cc=dariusz.stojaczyk@intel.com \
    --cc=dev@dpdk.org \
    --cc=jasowang@redhat.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=tiwei.bie@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).