From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 25A841B480 for ; Tue, 12 Feb 2019 12:36:37 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Feb 2019 03:36:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,361,1544515200"; d="scan'208";a="121811040" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga007.fm.intel.com with ESMTP; 12 Feb 2019 03:36:36 -0800 Received: from hasmsx106.ger.corp.intel.com (10.184.198.20) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 12 Feb 2019 03:36:36 -0800 Received: from HASMSX109.ger.corp.intel.com ([169.254.3.174]) by HASMSX106.ger.corp.intel.com ([169.254.10.140]) with mapi id 14.03.0415.000; Tue, 12 Feb 2019 13:36:33 +0200 From: "Kusztal, ArkadiuszX" To: Shally Verma , Ayuj Verma , "Trahe, Fiona" CC: "akhil.goyal@nxp.com" , Kanaka Durga Kotamarthy , Sunila Sahu , "dev@dpdk.org" Thread-Topic: [PATCH 0/3] adding op-type crt sign and decrypt Thread-Index: AQHUvg1gQkJoFzcev0ymVfke48+GsaXVmWXEgACVmtCAA+zJ5IAAVXaggAAS47CAAYLbIIAABUYAgAAF7LA= Date: Tue, 12 Feb 2019 11:36:33 +0000 Message-ID: <06EE24DD0B19E248B53F6DC8657831551B13B242@hasmsx109.ger.corp.intel.com> References: <20190206111405.30860-1-ayverma@marvell.com> , <348A99DA5F5B7549AA880327E580B435896EBE65@IRSMSX101.ger.corp.intel.com> <06EE24DD0B19E248B53F6DC8657831551B13B064@hasmsx109.ger.corp.intel.com> <06EE24DD0B19E248B53F6DC8657831551B13B21B@hasmsx109.ger.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.104.14.186] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/3] adding op-type crt sign and decrypt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2019 11:36:38 -0000 > -----Original Message----- > From: Shally Verma [mailto:shallyv@marvell.com] > Sent: Tuesday, February 12, 2019 12:19 PM > To: Kusztal, ArkadiuszX ; Ayuj Verma > ; Trahe, Fiona > Cc: akhil.goyal@nxp.com; Kanaka Durga Kotamarthy > ; Sunila Sahu ; > dev@dpdk.org > Subject: RE: [PATCH 0/3] adding op-type crt sign and decrypt >=20 > Hi Arek >=20 > >-----Original Message----- > >From: Kusztal, ArkadiuszX > >Sent: 12 February 2019 16:42 > >To: Shally Verma ; Ayuj Verma > >; Trahe, Fiona > >Cc: akhil.goyal@nxp.com; Kanaka Durga Kotamarthy > >; Sunila Sahu ; > >dev@dpdk.org > >Subject: RE: [PATCH 0/3] adding op-type crt sign and decrypt > > > >Hi Shally, Ayuj > > > >Answers with [AK] > > > >> -----Original Message----- > >> From: Shally Verma [mailto:shallyv@marvell.com] > >> Sent: Tuesday, February 12, 2019 6:27 AM > >> To: Kusztal, ArkadiuszX ; Ayuj Verma > >> ; Trahe, Fiona > >> Cc: akhil.goyal@nxp.com; Kanaka Durga Kotamarthy > >> ; Sunila Sahu ; > >> dev@dpdk.org > >> Subject: RE: [PATCH 0/3] adding op-type crt sign and decrypt > >> > >> HI Arek, > >> > >> From: Kusztal, ArkadiuszX > >> Sent: 11 February 2019 17:11 > >> To: Ayuj Verma ; Trahe, Fiona > >> ; Shally Verma > >> Cc: akhil.goyal@nxp.com > >> Subject: [EXT] RE: [PATCH 0/3] adding op-type crt sign and decrypt > >> > >> External Email > >> ________________________________________ > >> Hi Ayuj, > >> > >> Few comments from me. > >> > >> Some PMDs can only support RSA private key operations using CRT keys > >> (quintuple) only. Thus it is required to add in PMD RSA xform > >> capability which key type is supported to perform sign and decrypt ops= . > >> > >> > >> Thus add an another op_type RTE_CRYPTO_OP_TYPE_SIGN_CRT and > >> RTE_CRYPTO_OP_TYPE_DECRYPT_CRT, which would mean perform an > private > >> key op using CRT keys (quintuple) only. > >> [AK] - What would be the purpose of enum rte_crypto_rsa_priv_key_type > >> key_type in RSA XFORM then? > >> > >> [Shally] PMDs, like openssl, can support private key ops with both > >> key type i.e. one can invoke RSA_Sign() with quintuple keys or exponen= t > keys. > >> Openssl in its capability would reflect it support ops with both key t= ypes. > >> that's why key_type is still required in xform. > > > >[AK] But still I wonder if we could not just use this enum to distinguis= h > between crt and mod exp rsa? > >I am not very keen on adding SIGN_CRT op type as it is RSA only. > >Another option would be to add flags to rsa op like uint64_t flags; > [Shally] Ok .. you mean as feature flag? Example, > RTE_CRYPTODEV_ASYM_FF_RSA_PRIV_KEY_OP_CRT? [AK] Yes. >=20 > Thanks > Shally > ... > >> Regards, > >> Arek